Http::prepareQuery() - Code Metrics - Inspection of "- Add curl set setStdErrOut" - smi2/phpClickHouse - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 48f8d7...e8e671 )

by Igor

created 2022-04-20 19:29 UTC

Http::prepareQuery() A

↳ Parent: Http

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	2
eloc	3
c	3
b	0
f	1
nc	2
nop	2
dl	0
loc	9
ccs	3
cts	4
cp	0.75
crap	2.0625
rs	10

<?php

introduced 2019-03-13 07:05 UTC by

Missing declare(strict_types=1).

namespace ClickHouseDB\Transport;

use ClickHouseDB\Exception\TransportException;

use ClickHouseDB\Query\Degeneration;

use ClickHouseDB\Query\Query;

use ClickHouseDB\Query\WhereInFile;

use ClickHouseDB\Query\WriteToFile;

use ClickHouseDB\Settings;

use ClickHouseDB\Statement;

use const PHP_EOL;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines between different types of use statement, found 0.

class Http

    const AUTH_METHOD_HEADER       = 1;

introduced 2020-06-21 08:15 UTC by

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_HEADER visibility missing.

    const AUTH_METHOD_QUERY_STRING = 2;

introduced 2020-06-21 08:15 UTC by

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_QUERY_STRING visibility missing.

    const AUTH_METHOD_BASIC_AUTH   = 3;

introduced 2020-06-21 08:15 UTC by

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_BASIC_AUTH visibility missing.

    const AUTH_METHODS_LIST = [

introduced 2020-06-21 08:15 UTC by

Constant \ClickHouseDB\Transport\Http::AUTH_METHODS_LIST visibility missing.

        self::AUTH_METHOD_HEADER,

        self::AUTH_METHOD_QUERY_STRING,

        self::AUTH_METHOD_BASIC_AUTH,

];

/**

introduced 2020-06-21 08:15 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_username with single line content, use one-line comment instead.

     * @var string

*/

    private $_username = null;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_password with single line content, use one-line comment instead.

     * @var string

*/

    private $_password = null;

/**

     * The username and password can be indicated in one of three ways:

     *  - Using HTTP Basic Authentication.

     *  - In the ‘user’ and ‘password’ URL parameters.

     *  - Using ‘X-ClickHouse-User’ and ‘X-ClickHouse-Key’ headers (by default)

     * @see https://clickhouse.tech/docs/en/interfaces/http/

introduced 2020-06-21 08:15 UTC by

Incorrect annotations group.

     * @var int

*/

    private $_authMethod = self::AUTH_METHOD_HEADER;

/**

introduced 2020-06-21 08:15 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_host with single line content, use one-line comment instead.

     * @var string

*/

    private $_host = '';

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_port with single line content, use one-line comment instead.

     * @var int

*/

    private $_port = 0;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_verbose with single line content, use one-line comment instead.

     * @var bool|int

*/

    private $_verbose = false;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_curler with single line content, use one-line comment instead.

     * @var CurlerRolling

*/

    private $_curler = null;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_settings with single line content, use one-line comment instead.

     * @var Settings

*/

    private $_settings = null;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_query_degenerations with single line content, use one-line comment instead.

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\Http::$_query_degenerations does not specify type hint for its items.

*/

    private $_query_degenerations = [];

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "_query_degenerations" is not in valid camel caps format

/**

     * Count seconds (int)

     * @var int

*/

    private $_connectTimeOut = 5;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$xClickHouseProgress with single line content, use one-line comment instead.

     * @var callable

*/

    private $xClickHouseProgress = null;

/**

introduced 2019-11-28 14:43 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$sslCA with single line content, use one-line comment instead.

     * @var null|string

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|string".

*/

    private $sslCA = null;

/**

introduced 2022-04-20 19:38 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\Http::$stdErrOut with single line content, use one-line comment instead.

     * @var null|resource

introduced 2022-04-20 19:38 UTC by

Null type hint should be on last position in "null|resource".

*/

    private $stdErrOut = null;

/**

     * Http constructor.

introduced 2018-07-08 20:56 UTC by

Documentation comment contains forbidden comment "Http constructor.".

100

     * @param string $host

introduced 2018-09-26 10:27 UTC by

Expected 1 lines between description and annotations, found 0.

101

     * @param int $port

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 4 spaces after parameter type; 1 found

102

     * @param string $username

103

     * @param string $password

104

     * @param int $authMethod

Coding Style introduced 2020-06-21 08:15 UTC by

Expected 4 spaces after parameter type; 1 found

105

*/

106

    public function __construct($host, $port, $username, $password, $authMethod = null)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__construct() does not have native type hint for its parameter $host but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__construct() does not have native type hint for its parameter $port but it should be possible to add it based on @param annotation "int".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__construct() does not have native type hint for its parameter $username but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__construct() does not have native type hint for its parameter $password but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__construct() does not have native type hint for its parameter $authMethod but it should be possible to add it based on @param annotation "int".

Coding Style introduced 2022-04-20 19:38 UTC by

Expected 1 blank line before function; 0 found

107

108

        $this->setHost($host, $port);

109

110

        $this->_username = $username;

111

        $this->_password = $password;

112

        if ($authMethod) {

Bug Best Practice introduced 2020-09-29 12:51 UTC by

The expression $authMethod of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

113

            $this->_authMethod = $authMethod;

114

115

116

        $this->_settings = new Settings($this);

117

118

        $this->setCurler();

119

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

120

121

122

    public function setCurler() : void

introduced 2021-02-28 10:12 UTC by

There must be no whitespace between closing parenthesis and return type colon.

123

124

        $this->_curler = new CurlerRolling();

125

126

127

/**

128

     * @param CurlerRolling $curler

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::setDirtyCurler() has useless @param annotation for parameter $curler.

129

*/

130

    public function setDirtyCurler(CurlerRolling $curler) : void

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::setDirtyCurler() does not need documentation comment.

introduced 2021-02-28 10:12 UTC by

There must be no whitespace between closing parenthesis and return type colon.

131

132

        if ($curler instanceof CurlerRolling) {

introduced 2019-08-24 09:06 UTC by

$curler is always a sub-type of ClickHouseDB\Transport\CurlerRolling.

introduced 2019-08-24 09:06 UTC by

Use early exit to reduce code nesting.

133

            $this->_curler = $curler;

134

135

136

137

/**

138

     * @return CurlerRolling

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getCurler() has useless @return annotation.

139

*/

140

    public function getCurler(): ?CurlerRolling

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getCurler() does not need documentation comment.

141

142

        return $this->_curler;

143

144

145

/**

146

     * @param string $host

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::setHost() has useless @param annotation for parameter $host.

147

     * @param int $port

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 4 spaces after parameter type; 1 found

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::setHost() has useless @param annotation for parameter $port.

148

*/

149

    public function setHost(string $host, int $port = -1) : void

introduced 2021-02-28 10:12 UTC by

There must be no whitespace between closing parenthesis and return type colon.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::setHost() does not need documentation comment.

150

151

        if ($port > 0) {

152

            $this->_port = $port;

153

154

155

        $this->_host = $host;

156

157

158

/**

159

     * Sets client SSL certificate for Yandex Cloud

160

161

     * @param string $caPath

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::setSslCa() has useless @param annotation for parameter $caPath.

162

*/

163

    public function setSslCa(string $caPath) : void

introduced 2021-02-28 10:12 UTC by

There must be no whitespace between closing parenthesis and return type colon.

164

165

        $this->sslCA = $caPath;

166

167

168

/**

169

     * @return string

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getUri() has useless @return annotation.

170

*/

171

    public function getUri(): string

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getUri() does not need documentation comment.

172

173

        $proto = 'http';

174

        if ($this->settings()->isHttps()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

175

            $proto = 'https';

176

177

        $uri = $proto . '://' . $this->_host;

178

        if (stripos($this->_host, '/') !== false || stripos($this->_host, ':') !== false) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

introduced 2018-07-24 07:04 UTC by

Function stripos() should not be referenced via a fallback global name, but via a use statement.

179

            return $uri;

180

181

        if (intval($this->_port) > 0) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

introduced 2018-07-24 07:04 UTC by

Function intval() should not be referenced via a fallback global name, but via a use statement.

182

            return $uri . ':' . $this->_port;

183

184

        return $uri;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

185

186

187

/**

188

     * @return Settings

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::settings() has useless @return annotation.

189

*/

190

    public function settings(): Settings

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::settings() does not need documentation comment.

191

192

        return $this->_settings;

193

194

195

/**

196

     * @param bool $flag

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::verbose() has useless @param annotation for parameter $flag.

197

     * @return bool

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::verbose() has useless @return annotation.

198

*/

199

    public function verbose(bool $flag): bool

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::verbose() does not need documentation comment.

200

201

        $this->_verbose = $flag;

202

        return $flag;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

203

204

205

/**

206

     * @param array $params

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\Http::getUrl() does not specify type hint for items of its traversable parameter $params.

207

     * @return string

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getUrl() has useless @return annotation.

208

*/

209

    private function getUrl($params = []): string

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::getUrl() does not have native type hint for its parameter $params but it should be possible to add it based on @param annotation "array".

210

211

        $settings = $this->settings()->getSettings();

212

213

        if (is_array($params) && sizeof($params)) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 2.

introduced 2018-07-08 20:56 UTC by

Function is_array() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

214

            $settings = array_merge($settings, $params);

introduced 2018-07-08 20:56 UTC by

Function array_merge() should not be referenced via a fallback global name, but via a use statement.

215

216

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

217

218

        if ($this->settings()->isReadOnlyUser()) {

219

            unset($settings['extremes']);

220

            unset($settings['readonly']);

221

            unset($settings['enable_http_compression']);

222

            unset($settings['max_execution_time']);

223

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at end of control structure

224

225

226

        unset($settings['https']);

227

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

228

229

        return $this->getUri() . '?' . http_build_query($settings);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 2.

introduced 2018-07-08 20:56 UTC by

Function http_build_query() should not be referenced via a fallback global name, but via a use statement.

230

231

232

/**

233

     * @param array $extendinfo

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\Http::newRequest() does not specify type hint for items of its traversable parameter $extendinfo.

234

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::newRequest() has useless @return annotation.

235

*/

236

    private function newRequest($extendinfo): CurlerRequest

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::newRequest() does not have native type hint for its parameter $extendinfo but it should be possible to add it based on @param annotation "array".

237

238

        $new = new CurlerRequest();

239

240

        switch ($this->_authMethod) {

241

            case self::AUTH_METHOD_QUERY_STRING:

242

                /* @todo: Move this implementation to CurlerRequest class. Possible options: the authentication method

243

                 *        should be applied in method `CurlerRequest:prepareRequest()`.

244

*/

245

                $this->settings()->set('user', $this->_username);

246

                $this->settings()->set('password', $this->_password);

247

                break;

248

            case self::AUTH_METHOD_BASIC_AUTH:

249

                $new->authByBasicAuth($this->_username, $this->_password);

250

                break;

251

            default:

252

                // Auth with headers by default

253

                $new->authByHeaders($this->_username, $this->_password);

254

                break;

255

256

257

        $new->POST()->setRequestExtendedInfo($extendinfo);

258

259

        $new->httpCompression($this->settings()->isEnableHttpCompression());

Bug introduced 2022-04-20 19:38 UTC by

It seems like $this->settings()->isEnableHttpCompression() can also be of type null; however, parameter $flag of ClickHouseDB\Transport\C...uest::httpCompression() does only seem to accept boolean, maybe add an additional type check? ( Ignorable by Annotation )

260

261

        if ($this->settings()->getSessionId()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

262

            $new->persistent();

263

264

        if ($this->sslCA) {

265

            $new->setSslCa($this->sslCA);

266

267

268

        $new->timeOut($this->settings()->getTimeOut());

269

        $new->connectTimeOut($this->_connectTimeOut);//->keepAlive(); // one sec

270

        $new->verbose(boolval($this->_verbose));

introduced 2018-07-08 20:56 UTC by

Function boolval() should not be referenced via a fallback global name, but via a use statement.

271

272

        return $new;

273

274

275

/**

276

     * @param Query $query

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::makeRequest() has useless @param annotation for parameter $query.

277

     * @param array $urlParams

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\Http::makeRequest() does not specify type hint for items of its traversable parameter $urlParams.

278

     * @param bool $query_as_string

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 2 spaces after parameter type; 1 found

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::makeRequest() has useless @param annotation for parameter $query_as_string.

279

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::makeRequest() has useless @return annotation.

280

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

281

*/

282

    private function makeRequest(Query $query, array $urlParams = [], bool $query_as_string = false): CurlerRequest

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

283

284

        $sql = $query->toSql();

285

286

        if ($query_as_string) {

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

287

            $urlParams['query'] = $sql;

288

289

290

        $extendInfo = [

291

            'sql' => $sql,

292

            'query' => $query,

293

            'format' => $query->getFormat()

introduced 2020-12-21 16:16 UTC by

Multi-line arrays must have a trailing comma after the last element.

294

];

295

296

        $new = $this->newRequest($extendInfo);

297

298

/*

299

         * Build URL after request making, since URL may contain auth data. This will not matter after the

300

         * implantation of the todo in the `HTTP:newRequest()` method.

301

*/

302

        $url = $this->getUrl($urlParams);

303

        $new->url($url);

304

Coding Style introduced 2019-11-28 14:43 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

305

306

        if (!$query_as_string) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

307

            $new->parameters_json($sql);

308

309

        $new->httpCompression($this->settings()->isEnableHttpCompression());

Bug introduced 2022-04-20 19:38 UTC by

310

311

        return $new;

312

313

314

/**

315

     * @param resource $stream

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

316

     * @return void

317

*/

318

    public function setStdErrOut($stream)

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\Http::setStdErrOut() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "void".

319

320

        if (is_resource($stream)) {

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "if", found 1.

introduced 2018-07-08 20:56 UTC by

Use early exit to reduce code nesting.

introduced 2018-07-08 20:56 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

321

            $this->stdErrOut=$stream;

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space before "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space after "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Equals sign not aligned correctly; expected 1 space but found 0 spaces

322

323

324

Coding Style introduced 2018-07-08 20:56 UTC by

Function closing brace must go on the next line following the body; found 1 blank lines before brace

325

326

/**

327

     * @param string|Query $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

328

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::writeStreamData() has useless @return annotation.

329

*/

330

    public function writeStreamData($sql): CurlerRequest

331

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 0 blank lines after opening function brace; 1 found

332

333

        if ($sql instanceof Query) {

334

            $query = $sql;

335

        } else {

336

            $query = new Query($sql);

337

338

339

        $extendInfo = [

340

            'sql' => $sql,

341

            'query' => $query,

342

            'format' => $query->getFormat()

introduced 2020-12-21 16:16 UTC by

Multi-line arrays must have a trailing comma after the last element.

343

];

344

345

        $request = $this->newRequest($extendInfo);

346

347

/*

348

         * Build URL after request making, since URL may contain auth data. This will not matter after the

349

         * implantation of the todo in the `HTTP:newRequest()` method.

350

*/

351

        $url = $this->getUrl([

352

            'readonly' => 0,

353

            'query' => $query->toSql()

introduced 2020-12-21 16:16 UTC by

Multi-line arrays must have a trailing comma after the last element.

354

]);

355

356

        $request->url($url);

357

        return $request;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

358

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

359

360

361

/**

362

     * @param string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

363

     * @param string $file_name

364

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() has useless @return annotation.

365

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

366

*/

367

    public function writeAsyncCSV($sql, $file_name): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() does not have native type hint for its parameter $file_name but it should be possible to add it based on @param annotation "string".

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_name should be in camel caps format.

368

369

        $query = new Query($sql);

370

371

        $extendinfo = [

372

            'sql' => $sql,

373

            'query' => $query,

374

            'format' => $query->getFormat()

introduced 2020-12-21 16:16 UTC by

Multi-line arrays must have a trailing comma after the last element.

375

];

376

377

        $request = $this->newRequest($extendinfo);

378

379

/*

380

         * Build URL after request making, since URL may contain auth data. This will not matter after the

381

         * implantation of the todo in the `HTTP:newRequest()` method.

382

*/

383

        $url = $this->getUrl([

384

            'readonly' => 0,

385

            'query' => $query->toSql()

introduced 2020-12-21 16:16 UTC by

Multi-line arrays must have a trailing comma after the last element.

386

]);

387

388

        $request->url($url);

389

390

        $request->setCallbackFunction(function (CurlerRequest $request) {

introduced 2018-09-26 10:27 UTC by

Closure not using "$this" should be declared static.

introduced 2020-12-21 16:16 UTC by

Closure does not have void return type hint.

391

            $handle = $request->getInfileHandle();

392

            if (is_resource($handle)) {

introduced 2018-07-08 20:56 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

introduced 2022-04-20 19:38 UTC by

Use early exit to reduce code nesting.

393

                fclose($handle);

introduced 2018-07-08 20:56 UTC by

Function fclose() should not be referenced via a fallback global name, but via a use statement.

394

395

});

396

397

        $request->setInfile($file_name);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_name should be in camel caps format.

398

        $this->_curler->addQueLoop($request);

399

400

        return new Statement($request);

401

402

403

/**

404

     * get Count Pending Query in Queue

405

406

     * @return int

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getCountPendingQueue() has useless @return annotation.

407

*/

408

    public function getCountPendingQueue(): int

409

410

        return $this->_curler->countPending();

411

412

413

/**

414

     * set Connect TimeOut in seconds [CURLOPT_CONNECTTIMEOUT] ( int )

415

416

     * @param int $connectTimeOut

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::setConnectTimeOut() has useless @param annotation for parameter $connectTimeOut.

417

*/

418

    public function setConnectTimeOut(int $connectTimeOut)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::setConnectTimeOut() does not have void return type hint.

419

420

        $this->_connectTimeOut = $connectTimeOut;

421

422

423

/**

424

     * get ConnectTimeOut in seconds

425

426

     * @return int

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getConnectTimeOut() has useless @return annotation.

427

*/

428

    public function getConnectTimeOut(): int

429

430

        return $this->_connectTimeOut;

431

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

432

433

434

    public function __findXClickHouseProgress($handle): bool

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::__findXClickHouseProgress() does not have parameter type hint nor @param annotation for its parameter $handle.

435

436

        $code = curl_getinfo($handle, CURLINFO_HTTP_CODE);

introduced 2018-07-08 20:56 UTC by

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURLINFO_HTTP_CODE should not be referenced via a fallback global name, but via a use statement.

437

438

        // Search X-ClickHouse-Progress

439

        if ($code == 200) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

introduced 2020-12-21 16:16 UTC by

Operator == is disallowed, use === instead.

440

            $response = curl_multi_getcontent($handle);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function curl_multi_getcontent() should not be referenced via a fallback global name, but via a use statement.

441

            $header_size = curl_getinfo($handle, CURLINFO_HEADER_SIZE);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURLINFO_HEADER_SIZE should not be referenced via a fallback global name, but via a use statement.

442

            if (!$header_size) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

443

                return false;

444

445

446

            $header = substr($response, 0, $header_size);

introduced 2018-07-08 20:56 UTC by

Function substr() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

447

            if (!$header_size) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

448

                return false;

449

450

451

            $pos = strrpos($header, 'X-ClickHouse-Summary:');

introduced 2021-01-19 17:19 UTC by

Function strrpos() should not be referenced via a fallback global name, but via a use statement.

452

            if (!$pos) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

453

                return false;

454

455

456

            $last = substr($header, $pos);

introduced 2018-07-08 20:56 UTC by

Function substr() should not be referenced via a fallback global name, but via a use statement.

457

            $data = @json_decode(str_ireplace('X-ClickHouse-Summary:', '', $last), true);

Bug introduced 2021-01-19 17:19 UTC by

It seems like str_ireplace('X-ClickHouse-Summary:', '', $last) can also be of type array; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

introduced 2018-07-08 20:56 UTC by

Function json_decode() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function str_ireplace() should not be referenced via a fallback global name, but via a use statement.

458

459

            if ($data && is_callable($this->xClickHouseProgress)) {

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "if", found 1.

introduced 2018-07-08 20:56 UTC by

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

460

461

                if (is_array($this->xClickHouseProgress)) {

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "if", found 2.

introduced 2018-07-08 20:56 UTC by

Function is_array() should not be referenced via a fallback global name, but via a use statement.

462

                    call_user_func_array($this->xClickHouseProgress, [$data]);

introduced 2018-07-08 20:56 UTC by

Function call_user_func_array() should not be referenced via a fallback global name, but via a use statement.

463

                } else {

464

                    call_user_func($this->xClickHouseProgress, $data);

introduced 2018-07-08 20:56 UTC by

Function call_user_func() should not be referenced via a fallback global name, but via a use statement.

465

466

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

467

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at end of control structure

468

469

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at end of control structure

470

471

        return false;

introduced 2021-02-28 10:12 UTC by

Expected 1 lines before "return", found 0.

472

473

474

/**

475

     * @param Query $query

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::getRequestRead() has useless @param annotation for parameter $query.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 12 spaces after parameter type; 1 found

476

     * @param null|WhereInFile $whereInFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WhereInFile".

477

     * @param null|WriteToFile $writeToFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WriteToFile".

478

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getRequestRead() has useless @return annotation.

479

     * @throws \Exception

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

480

*/

481

    public function getRequestRead(Query $query, $whereInFile = null, $writeToFile = null): CurlerRequest

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have native type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have native type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

482

483

        $urlParams = ['readonly' => 2];

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

484

        $query_as_string = false;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

485

        // ---------------------------------------------------------------------------------

486

        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {

introduced 2021-02-28 10:12 UTC by

Expected 1 lines after "if", found 0.

487

            // $request = $this->prepareSelectWhereIn($request, $whereInFile);

488

            $structure = $whereInFile->fetchUrlParams();

489

            // $structure = [];

490

            $urlParams = array_merge($urlParams, $structure);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function array_merge() should not be referenced via a fallback global name, but via a use statement.

491

            $query_as_string = true;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

492

493

        // ---------------------------------------------------------------------------------

494

        // if result to file

495

        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

496

            $query->setFormat($writeToFile->fetchFormat());

497

            unset($urlParams['extremes']);

498

499

        // ---------------------------------------------------------------------------------

500

        // makeRequest read

501

        $request = $this->makeRequest($query, $urlParams, $query_as_string);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $query_as_string should be in camel caps format.

502

        // ---------------------------------------------------------------------------------

503

        // attach files

504

        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

505

            $request->attachFiles($whereInFile->fetchFiles());

506

507

        // ---------------------------------------------------------------------------------

508

        // result to file

509

        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

510

511

            $fout = fopen($writeToFile->fetchFile(), 'w');

introduced 2018-07-08 20:56 UTC by

Function fopen() should not be referenced via a fallback global name, but via a use statement.

512

            if (is_resource($fout)) {

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

introduced 2022-04-20 19:38 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

513

514

                $isGz = $writeToFile->getGzip();

515

516

                if ($isGz) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 2.

517

                    // write gzip header

518

                    // "\x1f\x8b\x08\x00\x00\x00\x00\x00"

519

                    // fwrite($fout, "\x1F\x8B\x08\x08".pack("V", time())."\0\xFF", 10);

520

                    // write the original file name

521

                    // $oname = str_replace("\0", "", basename($writeToFile->fetchFile()));

522

                    // fwrite($fout, $oname."\0", 1+strlen($oname));

523

524

                    fwrite($fout, "\x1f\x8b\x08\x00\x00\x00\x00\x00");

introduced 2018-07-08 20:56 UTC by

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

525

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at end of control structure

526

527

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

528

529

                $request->setResultFileHandle($fout, $isGz)->setCallbackFunction(function (CurlerRequest $request) {

introduced 2018-09-26 10:27 UTC by

Closure not using "$this" should be declared static.

introduced 2020-12-21 16:16 UTC by

Closure does not have void return type hint.

530

                    fclose($request->getResultFileHandle());

introduced 2018-07-08 20:56 UTC by

Function fclose() should not be referenced via a fallback global name, but via a use statement.

531

});

532

533

534

535

        if ($this->stdErrOut) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

536

            $request->setStdErrOut($this->stdErrOut);

537

538

        if ($this->xClickHouseProgress) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

539

            $request->setFunctionProgress([$this, '__findXClickHouseProgress']);

540

541

        // ---------------------------------------------------------------------------------

542

        return $request;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "return", found 1.

543

544

Coding Style introduced 2020-12-21 16:16 UTC by

Function closing brace must go on the next line following the body; found 1 blank lines before brace

545

546

    public function cleanQueryDegeneration(): bool

547

548

        $this->_query_degenerations = [];

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_query_degenerations" is not in valid camel caps format

549

        return true;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

550

551

552

    public function addQueryDegeneration(Degeneration $degeneration): bool

553

554

        $this->_query_degenerations[] = $degeneration;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_query_degenerations" is not in valid camel caps format

555

        return true;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

556

557

558

/**

559

     * @param Query $query

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::getRequestWrite() has useless @param annotation for parameter $query.

560

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::getRequestWrite() has useless @return annotation.

561

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

562

*/

563

    public function getRequestWrite(Query $query): CurlerRequest

564

565

        $urlParams = ['readonly' => 0];

566

        return $this->makeRequest($query, $urlParams);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

567

568

569

/**

570

     * @throws TransportException

571

*/

572

    public function ping(): bool

573

574

        $request = new CurlerRequest();

575

        $request->url($this->getUri())->verbose(false)->GET()->connectTimeOut($this->getConnectTimeOut());

576

        $this->_curler->execOne($request);

577

578

        return $request->response()->body() === 'Ok.' . PHP_EOL;

579

580

581

/**

582

     * @param string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 2 spaces after parameter type; 1 found

583

     * @param mixed[] $bindings

584

     * @return Query

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::prepareQuery() has useless @return annotation.

585

*/

586

    private function prepareQuery($sql, $bindings): Query

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareQuery() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareQuery() does not have native type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

587

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 0 blank lines after opening function brace; 1 found

588

589

        // add Degeneration query

590

        foreach ($this->_query_degenerations as $degeneration) {

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_query_degenerations" is not in valid camel caps format

591

            $degeneration->bindParams($bindings);

592

593

594

        return new Query($sql, $this->_query_degenerations);

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_query_degenerations" is not in valid camel caps format

595

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

596

597

598

/**

599

     * @param Query|string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 5 spaces after parameter type; 1 found

600

     * @param mixed[] $bindings

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 10 spaces after parameter type; 1 found

601

     * @param null|WhereInFile $whereInFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WhereInFile".

602

     * @param null|WriteToFile $writeToFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WriteToFile".

603

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::prepareSelect() has useless @return annotation.

604

     * @throws \Exception

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

605

*/

606

    private function prepareSelect($sql, $bindings, $whereInFile, $writeToFile = null): CurlerRequest

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareSelect() does not have native type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareSelect() does not have native type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareSelect() does not have native type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

607

608

        if ($sql instanceof Query) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

609

            return $this->getRequestWrite($sql);

610

611

        $query = $this->prepareQuery($sql, $bindings);

612

        $query->setFormat('JSON');

613

        return $this->getRequestRead($query, $whereInFile, $writeToFile);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

614

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

615

616

617

/**

618

     * @param Query|string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

619

     * @param mixed[] $bindings

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 6 spaces after parameter type; 1 found

620

     * @return CurlerRequest

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::prepareWrite() has useless @return annotation.

621

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

622

*/

623

    private function prepareWrite($sql, $bindings = []): CurlerRequest

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::prepareWrite() does not have native type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

624

625

        if ($sql instanceof Query) {

626

            return $this->getRequestWrite($sql);

627

628

629

        $query = $this->prepareQuery($sql, $bindings);

630

        return $this->getRequestWrite($query);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

631

632

633

/**

634

     * @return bool

introduced 2018-10-17 23:01 UTC by

Incorrect annotations group.

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::executeAsync() has useless @return annotation.

635

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

636

*/

637

    public function executeAsync(): bool

638

639

        return $this->_curler->execLoopWait();

640

641

642

/**

643

     * @param Query|string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 5 spaces after parameter type; 1 found

644

     * @param mixed[] $bindings

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 10 spaces after parameter type; 1 found

645

     * @param null|WhereInFile $whereInFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WhereInFile".

646

     * @param null|WriteToFile $writeToFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WriteToFile".

647

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::select() has useless @return annotation.

648

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

649

     * @throws \Exception

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

650

*/

651

    public function select($sql, array $bindings = [], $whereInFile = null, $writeToFile = null): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::select() does not have native type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::select() does not have native type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

652

653

        $request = $this->prepareSelect($sql, $bindings, $whereInFile, $writeToFile);

654

        $this->_curler->execOne($request);

655

        return new Statement($request);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

656

657

658

/**

659

     * @param Query|string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 5 spaces after parameter type; 1 found

660

     * @param mixed[] $bindings

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 10 spaces after parameter type; 1 found

661

     * @param null|WhereInFile $whereInFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WhereInFile".

662

     * @param null|WriteToFile $writeToFile

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|WriteToFile".

663

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::selectAsync() has useless @return annotation.

664

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

665

     * @throws \Exception

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

666

*/

667

    public function selectAsync($sql, array $bindings = [], $whereInFile = null, $writeToFile = null): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::selectAsync() does not have native type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::selectAsync() does not have native type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

668

669

        $request = $this->prepareSelect($sql, $bindings, $whereInFile, $writeToFile);

670

        $this->_curler->addQueLoop($request);

671

        return new Statement($request);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

672

673

674

/**

675

     * @param callable $callback

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::setProgressFunction() has useless @param annotation for parameter $callback.

676

*/

677

    public function setProgressFunction(callable $callback) : void

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::setProgressFunction() does not need documentation comment.

introduced 2021-01-19 17:19 UTC by

There must be no whitespace between closing parenthesis and return type colon.

678

679

        $this->xClickHouseProgress = $callback;

680

681

682

/**

683

     * @param string $sql

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 2 spaces after parameter type; 1 found

684

     * @param mixed[] $bindings

685

     * @param bool $exception

Coding Style introduced 2018-09-26 10:51 UTC by

Expected 4 spaces after parameter type; 1 found

686

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::write() has useless @return annotation.

687

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-15 14:29 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

688

*/

689

    public function write($sql, array $bindings = [], $exception = true): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::write() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::write() does not have native type hint for its parameter $exception but it should be possible to add it based on @param annotation "bool".

690

691

        $request = $this->prepareWrite($sql, $bindings);

692

        $this->_curler->execOne($request);

693

        $response = new Statement($request);

694

        if ($exception) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

695

            if ($response->isError()) {

696

                $response->error();

697

698

699

        return $response;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

700

701

702

/**

703

     * @param Stream $streamRW

introduced 2020-12-21 16:16 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streaming() has useless @param annotation for parameter $streamRW.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 8 spaces after parameter type; 1 found

704

     * @param CurlerRequest $request

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streaming() has useless @param annotation for parameter $request.

705

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::streaming() has useless @return annotation.

706

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

707

*/

708

    private function streaming(Stream $streamRW, CurlerRequest $request): Statement

709

710

        $callable = $streamRW->getClosure();

711

        $stream = $streamRW->getStream();

Coding Style introduced 2019-11-28 14:43 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

712

Coding Style introduced 2019-11-28 14:43 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

713

714

        try {

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "try", found 2.

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

715

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

716

717

            if (!is_callable($callable)) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

718

                if ($streamRW->isWrite()) {

Coding Style introduced 2018-10-17 23:01 UTC by

Blank line found at start of control structure

719

720

                    $callable = function ($ch, $fd, $length) use ($stream) {

introduced 2018-09-26 10:27 UTC by

Closure not using "$this" should be declared static.

721

                        return ($line = fread($stream, $length)) ? $line : '';

introduced 2018-07-08 20:56 UTC by

Function fread() should not be referenced via a fallback global name, but via a use statement.

722

};

723

                } else {

724

                    $callable = function ($ch, $fd) use ($stream) {

introduced 2018-09-26 10:27 UTC by

Closure not using "$this" should be declared static.

725

                        return fwrite($stream, $fd);

introduced 2018-07-08 20:56 UTC by

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

726

};

727

728

729

730

            if ($streamRW->isGzipHeader()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 2.

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

731

732

                if ($streamRW->isWrite()) {

introduced 2022-04-20 19:38 UTC by

Expected 0 lines after "if", found 1.

733

                    $request->header('Content-Encoding', 'gzip');

734

                    $request->header('Content-Type', 'application/x-www-form-urlencoded');

735

                } else {

736

                    $request->header('Accept-Encoding', 'gzip');

737

738

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at end of control structure

739

740

Coding Style introduced 2019-11-28 14:43 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

741

742

            $request->header('Transfer-Encoding', 'chunked');

743

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

744

745

            if ($streamRW->isWrite()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 2.

746

                $request->setReadFunction($callable);

747

            } else {

748

                $request->setWriteFunction($callable);

749

Coding Style introduced 2019-11-28 14:43 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

750

751

//                $request->setHeaderFunction($callableHead);

752

753

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

754

755

            $this->_curler->execOne($request, true);

756

            $response = new Statement($request);

757

            if ($response->isError()) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

758

                $response->error();

759

760

            return $response;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

761

        } finally {

762

            if ($streamRW->isWrite())

Coding Style Best Practice introduced 2018-07-08 20:56 UTC by

It is generally a best practice to always use braces with control structures.

763

                fclose($stream);

introduced 2018-07-08 20:56 UTC by

Function fclose() should not be referenced via a fallback global name, but via a use statement.

764

765

Coding Style introduced 2020-12-21 16:16 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

766

767

Coding Style introduced 2018-07-08 20:56 UTC by

Function closing brace must go on the next line following the body; found 2 blank lines before brace

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

768

769

770

/**

771

     * @param Stream $streamRead

introduced 2020-12-21 16:16 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamRead() has useless @param annotation for parameter $streamRead.

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 2 spaces after parameter type; 1 found

772

     * @param string $sql

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 2 spaces after parameter type; 1 found

773

     * @param mixed[] $bindings

774

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::streamRead() has useless @return annotation.

775

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

776

*/

777

    public function streamRead(Stream $streamRead, $sql, $bindings = []): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamRead() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamRead() does not have native type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

778

779

        $sql = $this->prepareQuery($sql, $bindings);

Coding Style introduced 2020-12-21 16:16 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

780

        $request = $this->getRequestRead($sql);

781

        return $this->streaming($streamRead, $request);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

introduced 2020-12-21 16:16 UTC by

Expected 0 lines after "return", found 1.

782

783

Coding Style introduced 2022-04-20 19:38 UTC by

Function closing brace must go on the next line following the body; found 1 blank lines before brace

784

785

/**

786

     * @param Stream $streamWrite

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamWrite() has useless @param annotation for parameter $streamWrite.

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 2 spaces after parameter type; 1 found

introduced 2022-04-20 19:38 UTC by

Incorrect annotations group.

787

     * @param string $sql

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 2 spaces after parameter type; 1 found

788

     * @param mixed[] $bindings

789

     * @return Statement

introduced 2021-02-28 10:12 UTC by

Method \ClickHouseDB\Transport\Http::streamWrite() has useless @return annotation.

790

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

791

*/

792

    public function streamWrite(Stream $streamWrite, $sql, $bindings = []): Statement

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamWrite() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\Http::streamWrite() does not have native type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

793

794

        $sql = $this->prepareQuery($sql, $bindings);

Coding Style introduced 2020-12-21 16:16 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

795

        $request = $this->writeStreamData($sql);

796

        return $this->streaming($streamWrite, $request);

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

797

798

799

smi2 / phpClickHouse

Push — master ( 48f8d7...e8e671 )

Http::prepareQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like