ClickHouseDB\Transport\StreamInsert::insert()

Complexity

Conditions	2
Paths	8

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function insert($callback)

Method \ClickHouseDB\Transport\StreamInsert::insert() does not have native type hint for its parameter $callback but it should be possible to add it based on @param annotation "callable".

Method \ClickHouseDB\Transport\StreamInsert::insert() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "\ClickHouseDB\Statement".

    {
        try {
            if (!is_callable($callback)) {

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

Expected 1 space after NOT operator; 0 found

                throw new \InvalidArgumentException('Argument $callback can not be called as a function');

Class \InvalidArgumentException should not be referenced via a fully qualified name, but via a use statement.

            }

            //

Empty comment

            $this->request->header('Transfer-Encoding', 'chunked');
            $this->request->setReadFunction($callback);
            $this->curlerRolling->execOne($this->request, true);
            $statement = new Statement($this->request);
            $statement->error();
            return $statement;

Expected 1 lines before "return", found 0.

        } finally {
            fclose($this->source);

Function fclose() should not be referenced via a fallback global name, but via a use statement.

        }