ClickHouseDB\Transport\Http::getRequestRead()

Complexity

Conditions	13
Paths	128

Size

Total Lines	62
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	13.0976

Importance

Changes	7
Bugs	0	Features	1

<?php
    public function getRequestRead(Query $query, $whereInFile = null, $writeToFile = null): CurlerRequest

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have native type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have native type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

    {
        $urlParams = ['readonly' => 2];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $query_as_string = false;

The variable $query_as_string should be in camel caps format.

        // ---------------------------------------------------------------------------------
        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {

Expected 1 lines after "if", found 0.

            // $request = $this->prepareSelectWhereIn($request, $whereInFile);
            $structure = $whereInFile->fetchUrlParams();
            // $structure = [];
            $urlParams = array_merge($urlParams, $structure);

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

Function array_merge() should not be referenced via a fallback global name, but via a use statement.

            $query_as_string = true;

The variable $query_as_string should be in camel caps format.

        }
        // ---------------------------------------------------------------------------------
        // if result to file
        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {

Expected 1 lines after "if", found 0.

            $query->setFormat($writeToFile->fetchFormat());
            unset($urlParams['extremes']);
        }
        // ---------------------------------------------------------------------------------
        // makeRequest read
        $request = $this->makeRequest($query, $urlParams, $query_as_string);

The variable $query_as_string should be in camel caps format.

        // ---------------------------------------------------------------------------------
        // attach files
        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {

Expected 1 lines after "if", found 0.

            $request->attachFiles($whereInFile->fetchFiles());
        }
        // ---------------------------------------------------------------------------------
        // result to file
        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {

Blank line found at start of control structure

            $fout = fopen($writeToFile->fetchFile(), 'w');

Function fopen() should not be referenced via a fallback global name, but via a use statement.

            if (is_resource($fout)) {

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

Blank line found at start of control structure

                $isGz = $writeToFile->getGzip();

                if ($isGz) {

Expected 1 lines after "if", found 2.

                    // write gzip header
                    // "\x1f\x8b\x08\x00\x00\x00\x00\x00"
                    // fwrite($fout, "\x1F\x8B\x08\x08".pack("V", time())."\0\xFF", 10);
                    // write the original file name
                    // $oname = str_replace("\0", "", basename($writeToFile->fetchFile()));
                    // fwrite($fout, $oname."\0", 1+strlen($oname));

                    fwrite($fout, "\x1f\x8b\x08\x00\x00\x00\x00\x00");

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

Blank line found at end of control structure

                }

Functions must not contain multiple empty lines in a row; found 2 empty lines

                $request->setResultFileHandle($fout, $isGz)->setCallbackFunction(function (CurlerRequest $request) {

Closure not using "$this" should be declared static.

Closure does not have void return type hint.

                    fclose($request->getResultFileHandle());

Function fclose() should not be referenced via a fallback global name, but via a use statement.

                });
            }
        }

        if ($this->stdErrOut) {

Expected 1 lines after "if", found 0.

            $request->setStdErrOut($this->stdErrOut);
        }
        if ($this->xClickHouseProgress) {

Expected 1 lines after "if", found 0.

            $request->setFunctionProgress([$this, '__findXClickHouseProgress']);
        }
        // ---------------------------------------------------------------------------------
        return $request;

Expected 1 lines before "return", found 0.

Expected 0 lines after "return", found 1.