ClickHouseDB\Transport\CurlerRequest::prepareRequest()

Complexity

Conditions	18
Paths	4032

Size

Total Lines	76
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	18.0207

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function prepareRequest()

Method \ClickHouseDB\Transport\CurlerRequest::prepareRequest() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        if (!$this->handle) {

Expected 1 space after NOT operator; 0 found

            $this->handle = curl_init();

It seems like curl_init() can also be of type CurlHandle. However, the property $handle is declared as type null|resource. Maybe add an additional type check?

Function curl_init() should not be referenced via a fallback global name, but via a use statement.

        }

        $curl_opt = $this->options;

The variable $curl_opt should be in camel caps format.

        $method = $this->method;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        if ($this->_attachFiles) {

Expected 1 lines after "if", found 2.

            $curl_opt[CURLOPT_SAFE_UPLOAD] = true;

The constant CURLOPT_SAFE_UPLOAD has been deprecated: 7.0 Use <b>CURLFile</b> for uploads instead.

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_SAFE_UPLOAD should not be referenced via a fallback global name, but via a use statement.

        }

Functions must not contain multiple empty lines in a row; found 2 empty lines

        if (strtoupper($method) == 'GET') {

Expected 1 lines after "if", found 0.

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

Operator == is disallowed, use === instead.

            $curl_opt[CURLOPT_HTTPGET] = true;

The variable $curl_opt should be in camel caps format.

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

            $curl_opt[CURLOPT_CUSTOMREQUEST] = strtoupper($method);

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_CUSTOMREQUEST should not be referenced via a fallback global name, but via a use statement.

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

            $curl_opt[CURLOPT_POSTFIELDS] = false;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        } else {
            if (strtoupper($method) === 'POST') {

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

                $curl_opt[CURLOPT_POST] = true;

The variable $curl_opt should be in camel caps format.

            }

            $curl_opt[CURLOPT_CUSTOMREQUEST] = strtoupper($method);

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_CUSTOMREQUEST should not be referenced via a fallback global name, but via a use statement.

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

            if ($this->parameters) {
                $curl_opt[CURLOPT_POSTFIELDS] = $this->parameters;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

                if (!is_array($this->parameters)) {

Function is_array() should not be referenced via a fallback global name, but via a use statement.

Expected 1 space after NOT operator; 0 found

                    $this->header('Content-Length',  mb_strlen($this->parameters, '8bit'));

Expected 1 space after comma in argument list; 2 found

Function mb_strlen() should not be referenced via a fallback global name, but via a use statement.

                }
            }
        }
        // CURLOPT_DNS_CACHE_TIMEOUT - Количество секунд, в течение которых в памяти хранятся DNS-записи.
        $curl_opt[CURLOPT_DNS_CACHE_TIMEOUT] = $this->getDnsCache();

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_DNS_CACHE_TIMEOUT should not be referenced via a fallback global name, but via a use statement.

        $curl_opt[CURLOPT_URL] = $this->url;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_URL should not be referenced via a fallback global name, but via a use statement.

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space

        if (!empty($this->headers) && sizeof($this->headers)) {

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

The use of function sizeof() is forbidden; use count() instead

Expected 1 space after NOT operator; 0 found

            $curl_opt[CURLOPT_HTTPHEADER] = [];

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_HTTPHEADER should not be referenced via a fallback global name, but via a use statement.

            foreach ($this->headers as $key => $value) {
                $curl_opt[CURLOPT_HTTPHEADER][] = sprintf("%s: %s", $key, $value);

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_HTTPHEADER should not be referenced via a fallback global name, but via a use statement.

Function sprintf() should not be referenced via a fallback global name, but via a use statement.

The string literal %s: %s does not require double quotes, as per coding-style, please use single quotes.

            }
        }

        if (!empty($curl_opt[CURLOPT_INFILE])) {

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_INFILE should not be referenced via a fallback global name, but via a use statement.

Blank line found at start of control structure

Expected 1 space after NOT operator; 0 found

            $curl_opt[CURLOPT_PUT] = true;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_PUT should not be referenced via a fallback global name, but via a use statement.

        }

        if (!empty($curl_opt[CURLOPT_WRITEFUNCTION])) {

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_WRITEFUNCTION should not be referenced via a fallback global name, but via a use statement.

Expected 1 space after NOT operator; 0 found

            $curl_opt[CURLOPT_HEADER] = false;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_HEADER should not be referenced via a fallback global name, but via a use statement.

        }

        if ($this->resultFileHandle) {
            $curl_opt[CURLOPT_FILE] = $this->resultFileHandle;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_FILE should not be referenced via a fallback global name, but via a use statement.

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $curl_opt[CURLOPT_HEADER] = false;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_HEADER should not be referenced via a fallback global name, but via a use statement.

        }

        if ($this->options[CURLOPT_VERBOSE]) {

Constant CURLOPT_VERBOSE should not be referenced via a fallback global name, but via a use statement.

            $msg="\n-----------BODY REQUEST----------\n" . $curl_opt[CURLOPT_POSTFIELDS] . "\n------END--------\n";

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

Expected at least 1 space before "="; 0 found

Expected at least 1 space after "="; 0 found

Equals sign not aligned correctly; expected 1 space but found 0 spaces

            if ($this->stdErrOut && is_resource($this->stdErrOut)) {

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

                fwrite($this->stdErrOut,$msg);

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

            } else {
                echo $msg;
            }
        }

        if ($this->stdErrOut) {
            if (is_resource($this->stdErrOut)) {

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

                $curl_opt[CURLOPT_STDERR]=$this->stdErrOut;

The variable $curl_opt should be in camel caps format.

Constant CURLOPT_STDERR should not be referenced via a fallback global name, but via a use statement.

Expected at least 1 space before "="; 0 found

Expected at least 1 space after "="; 0 found

Equals sign not aligned correctly; expected 1 space but found 0 spaces

            }
        }

        curl_setopt_array($this->handle, $curl_opt);

Function curl_setopt_array() should not be referenced via a fallback global name, but via a use statement.

The variable $curl_opt should be in camel caps format.

        return true;

Expected 1 lines before "return", found 0.

    }