Smart\EtlBundle\Generator\DiffGenerator

Complexity

Total Complexity

10

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	generateDiffs()	0	23	3
A	generateDiff()	0	31	6
A	__construct()	0	4	1

<?php

namespace Smart\EtlBundle\Generator;

use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\PropertyAccess\PropertyAccessor;

/**
 * @author Mathieu Ducrot <mathieu.ducrot@smartbooster.io>
 *
 * The DiffGenerator class is responsible for comparing a raw data with data pulled from the manager on the entity and
 * generating a diff preview with the changes needed to migrate from one data to the other.
 */
class DiffGenerator
{
    /** @var EntityManagerInterface */
    protected $entityManager;

    /** @var PropertyAccessor */
    protected $accessor;

    public function __construct(EntityManagerInterface $entityManager)
    {
        $this->entityManager = $entityManager;
        $this->accessor = PropertyAccess::createPropertyAccessor();
    }

    /**
     * @param array $multiArrayData multidimensional array data containing one entity data per row
     */
    public function generateDiffs(string $entityClass, array $multiArrayData)
    {
        $toReturn = [];
        if ($multiArrayData === []) {
            return $toReturn;
        }

        // todo amélioration en récupérant uniquement ceux dont l'identifier match ceux présent dans $data
        $identifier = array_keys($multiArrayData[0])[0];
        $entitiesFromDb = $this->entityManager->getRepository($entityClass)
            ->createQueryBuilder('o', "o.$identifier")
            ->getQuery()
            ->getResult()
        ;

        foreach ($multiArrayData as $key => $row) {
            $toReturn[$key] = $this->generateDiff(
                $entitiesFromDb[reset($row)] ?? null,
                $row
            );
        }

        return $toReturn;
    }

    /**
     * @param mixed $entity
     */
    public function generateDiff($entity, array $data): array
    {
        $isNew = ($entity === null);
        $toReturn['diff_type'] = 'new';

$toReturn was never initialized. Although not strictly required by PHP, it is generally a good practice to add $toReturn = array(); before regardless.

        $hasDataChange = false;
        foreach ($data as $property => $value) {
            $toReturn['diff'][$property] = $value;

            if (!$isNew) {
                $toReturn['diff_type'] = 'change';

                $originValue = $this->accessor->getValue($entity, $property);
                $hasChange = ($originValue != $value);
                $toReturn['diff'][$property] = [
                    'value' => $value,
                    'origin_value' => $originValue,
                    'has_change' => $hasChange,
                ];

                if ($hasChange) {
                    $hasDataChange = true;
                }
            }
        }

        if (!$isNew && !$hasDataChange) {
            $toReturn['diff_type'] = 'unchanged';
        }

        return $toReturn;
    }
}