for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace ThreePlCentral\Order;
use DateTime;
use ThreePlCentral\ThreePlCentral;
use ThreePlCentral\RequestFactory;
class OrderRepository
{
public static function findOrders(ThreePlCentral $threepl, DateTime $beginDate, DateTime $endDate): array
$request = RequestFactory::create(
$threepl,
'POST',
'http://www.JOI.com/schemas/ViaSub.WMS/FindOrders'
);
$request->setTemplate(__DIR__ . '/../Request/findOrders.xml');
$response = $request->fetch([
$response
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
'BeginDate' => $beginDate->format('YYYY-MM-DD'),
'EndDate' => $endDate->format('YYYY-MM-DD')
]);
}
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.