Complex classes like OrderEntity often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use OrderEntity, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
5 | class OrderEntity |
||
6 | { |
||
7 | private $customerName; |
||
8 | private $customerEmail; |
||
9 | private $customerPhone; |
||
10 | private $facility; |
||
11 | private $facilityID; |
||
12 | private $warehouseTransactionID; |
||
13 | private $referenceNum; |
||
14 | private $pONum; |
||
15 | private $retailer; |
||
16 | private $shipToCompanyName; |
||
17 | private $shipToName; |
||
18 | private $shipToEmail; |
||
19 | private $shipToPhone; |
||
20 | private $shipToAddress1; |
||
21 | private $shipToAddress2; |
||
22 | private $shipToCity; |
||
23 | private $shipToState; |
||
24 | private $shipToZip; |
||
25 | private $shipToCountry; |
||
26 | private $shipMethod; |
||
27 | private $markForName; |
||
28 | private $batchOrderID; |
||
29 | private $creationDate; |
||
30 | private $earliestShipDate; |
||
31 | private $shipCancelDate; |
||
32 | private $pickupDate; |
||
33 | private $carrier; |
||
34 | private $billingCode; |
||
35 | private $totWeight; |
||
36 | private $totCuFt; |
||
37 | private $totPackages; |
||
38 | private $totOrdQty; |
||
39 | private $totLines; |
||
40 | private $notes; |
||
41 | private $overAllocated; |
||
42 | private $pickTicketPrintDate; |
||
43 | private $processDate; |
||
44 | private $trackingNumber; |
||
45 | private $loadNumber; |
||
46 | private $billOfLading; |
||
47 | private $masterBillOfLading; |
||
48 | private $aSNSentDate; |
||
49 | private $confirmASNSentDate; |
||
50 | private $rememberRowInfo; |
||
51 | |||
52 | public function getCustomerName(): string |
||
56 | |||
57 | public function setCustomerName(string $customerName) |
||
61 | |||
62 | public function getCustomerEmail(): string |
||
66 | |||
67 | public function setCustomerEmail(string $customerEmail) |
||
71 | |||
72 | public function getCustomerPhone(): string |
||
76 | |||
77 | public function setCustomerPhone(string $customerPhone) |
||
81 | |||
82 | public function getFacility(): string |
||
86 | |||
87 | public function setFacility(string $facility) |
||
91 | |||
92 | public function getFacilityID(): string |
||
96 | |||
97 | public function setFacilityID(string $facilityID) |
||
101 | |||
102 | public function getWarehouseTransactionID(): string |
||
106 | |||
107 | public function setWarehouseTransactionID(string $warehouseTransactionID) |
||
111 | |||
112 | public function getReferenceNum(): string |
||
116 | |||
117 | public function setReferenceNum(string $referenceNum) |
||
121 | |||
122 | public function getPONum(): string |
||
126 | |||
127 | public function setPONum(string $pONum) |
||
131 | |||
132 | public function getRetailer(): string |
||
136 | |||
137 | public function setRetailer(string $retailer) |
||
141 | |||
142 | public function getShipToCompanyName(): string |
||
146 | |||
147 | public function setShipToCompanyName(string $shipToCompanyName) |
||
151 | |||
152 | public function getShipToName(): string |
||
156 | |||
157 | public function setShipToName(string $shipToName) |
||
161 | |||
162 | public function getShipToEmail(): string |
||
166 | |||
167 | public function setShipToEmail(string $shipToEmail) |
||
171 | |||
172 | public function getShipToPhone(): string |
||
176 | |||
177 | public function setShipToPhone(string $shipToPhone) |
||
181 | |||
182 | public function getShipToAddress1(): string |
||
186 | |||
187 | public function setShipToAddress1(string $shipToAddress1) |
||
191 | |||
192 | public function getShipToAddress2(): string |
||
196 | |||
197 | public function setShipToAddress2(string $shipToAddress2) |
||
201 | |||
202 | public function getShipToCity(): string |
||
206 | |||
207 | public function setShipToCity(string $shipToCity) |
||
211 | |||
212 | public function getShipToState(): string |
||
216 | |||
217 | public function setShipToState(string $shipToState) |
||
221 | |||
222 | public function getShipToZip(): string |
||
226 | |||
227 | public function setShipToZip(string $shipToZip) |
||
231 | |||
232 | public function getShipToCountry(): string |
||
236 | |||
237 | public function setShipToCountry(string $shipToCountry) |
||
241 | |||
242 | public function getShipMethod(): string |
||
246 | |||
247 | public function setShipMethod(string $shipMethod) |
||
251 | |||
252 | public function getMarkForName(): string |
||
256 | |||
257 | public function setMarkForName(string $markForName) |
||
261 | |||
262 | public function getBatchOrderID(): string |
||
266 | |||
267 | public function setBatchOrderID(string $batchOrderID) |
||
271 | |||
272 | public function getCreationDate(): string |
||
276 | |||
277 | public function setCreationDate(string $creationDate) |
||
281 | |||
282 | public function getEarliestShipDate(): string |
||
286 | |||
287 | public function setEarliestShipDate(string $earliestShipDate) |
||
291 | |||
292 | public function getShipCancelDate(): string |
||
296 | |||
297 | public function setShipCancelDate(string $shipCancelDate) |
||
301 | |||
302 | public function getPickupDate(): string |
||
306 | |||
307 | public function setPickupDate(string $pickupDate) |
||
311 | |||
312 | public function getCarrier(): string |
||
316 | |||
317 | public function setCarrier(string $carrier) |
||
321 | |||
322 | public function getBillingCode(): string |
||
326 | |||
327 | public function setBillingCode(string $billingCode) |
||
331 | |||
332 | public function getTotWeight(): string |
||
336 | |||
337 | public function setTotWeight(string $totWeight) |
||
341 | |||
342 | public function getTotCuFt(): string |
||
346 | |||
347 | public function setTotCuFt(string $totCuFt) |
||
351 | |||
352 | public function getTotPackages(): string |
||
356 | |||
357 | public function setTotPackages(string $totPackages) |
||
361 | |||
362 | public function getTotOrdQty(): string |
||
366 | |||
367 | public function setTotOrdQty(string $totOrdQty) |
||
371 | |||
372 | public function getTotLines(): string |
||
376 | |||
377 | public function setTotLines(string $totLines) |
||
381 | |||
382 | public function getNotes(): string |
||
386 | |||
387 | public function setNotes(string $notes) |
||
391 | |||
392 | public function getOverAllocated(): string |
||
396 | |||
397 | public function setOverAllocated(string $overAllocated) |
||
401 | |||
402 | public function getPickTicketPrintDate(): string |
||
406 | |||
407 | public function setPickTicketPrintDate(string $pickTicketPrintDate) |
||
411 | |||
412 | public function getProcessDate(): string |
||
416 | |||
417 | public function setProcessDate(string $processDate) |
||
421 | |||
422 | public function getTrackingNumber(): string |
||
426 | |||
427 | public function setTrackingNumber(string $trackingNumber) |
||
431 | |||
432 | public function getLoadNumber(): string |
||
436 | |||
437 | public function setLoadNumber(string $loadNumber) |
||
441 | |||
442 | public function getBillOfLading(): string |
||
446 | |||
447 | public function setBillOfLading(string $billOfLading) |
||
451 | |||
452 | public function getMasterBillOfLading(): string |
||
456 | |||
457 | public function setMasterBillOfLading(string $masterBillOfLading) |
||
461 | |||
462 | public function getASNSentDate(): string |
||
466 | |||
467 | public function setASNSentDate(string $aSNSentDate) |
||
471 | |||
472 | public function getConfirmASNSentDate(): string |
||
476 | |||
477 | public function setConfirmASNSentDate(string $confirmASNSentDate) |
||
481 | |||
482 | public function getRememberRowInfo(): string |
||
486 | |||
487 | public function setRememberRowInfo(string $rememberRowInfo) |
||
491 | } |
||
492 |