Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace jwa\cryptographic_algorithms\key_management\rsa\PKCS1; |
||
21 | View Code Duplication | final class RSA1_5_KeyManagementAlgorithm extends RSA_KeyManagementAlgorithm |
|
|
|||
22 | { |
||
23 | |||
24 | /** |
||
25 | * @return string |
||
26 | */ |
||
27 | public function getHashingAlgorithm() |
||
31 | |||
32 | /** |
||
33 | * @return string |
||
34 | */ |
||
35 | public function getName() |
||
39 | |||
40 | /** |
||
41 | * @return int |
||
42 | */ |
||
43 | public function getEncryptionMode() |
||
47 | |||
48 | /** |
||
49 | * @return string |
||
50 | */ |
||
51 | public function getMGFHash() |
||
55 | |||
56 | /** |
||
57 | * hash key size in bits |
||
58 | * @return int |
||
59 | */ |
||
60 | public function getHashKeyLen() |
||
64 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.