smarcet / JOSE4PHP

src/jwe/impl/ContentEncryptionKeyFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
     /**
      * @param Key $management_key
-     * @param $key_management_mode
+     * @param string $key_management_mode
      * @param ContentEncryptionAlgorithm $enc
      * @return Key
      * @throws \Exception

src/jwe/impl/IVFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 final class IVFactory {
 
     /**
-     * @param $size
+     * @param integer $size
      * @return string
      */
     static public function build($size){

src/jwk/impl/RSAJWK.php

Doc Comments +1 added lines, -1 removed lines

@@ -144,7 +144,7 @@
 
     /**
      * @param PrivateKey $private_key
-     * @return IAsymmetricJWK|null
+     * @return RSAJWK
      * @throws InvalidJWKType
      */
     static public function fromPrivateKey(PrivateKey $private_key)

Braces +21 added lines, -11 removed lines

@@ -53,11 +53,14 @@ 
 
         parent::__construct($headers);
 
-        if (count($headers) === 0) return;
+        if (count($headers) === 0) {
+         return;
+        }
 
         foreach (RSAKeysParameters::$public_key_params as $p) {
-            if (!array_key_exists($p, $headers))
-                throw new RSAJWKMissingPublicKeyParamException();
+            if (!array_key_exists($p, $headers)) {
+                            throw new RSAJWKMissingPublicKeyParamException();
+            }
             $this->set[$p] = new Base64urlUInt($headers[$p]);
         }
 
@@ -74,8 +77,9 @@ 
             //its has one private param, must have all ...
             if (in_array(RSAKeysParameters::FirstPrimeFactor, $headers)) {
                 foreach (RSAKeysParameters::$producers_private_key_params as $p) {
-                    if (!array_key_exists($p, $headers))
-                        throw new RSAJWKMissingPrivateKeyParamException();
+                    if (!array_key_exists($p, $headers)) {
+                                            throw new RSAJWKMissingPrivateKeyParamException();
+                    }
                     $this->set[$p] = new Base64urlUInt($headers[$p]);
                 }
                 $this->private_key = RSAFacade::getInstance()->buildPrivateKey(
@@ -112,11 +116,13 @@ 
      */
     static public function fromKeys(KeyPair $keys)
     {
-        if(!($keys->getPrivate() instanceof RSAPrivateKey))
-            throw new \RuntimeException('Private key of invalid type!');
+        if(!($keys->getPrivate() instanceof RSAPrivateKey)) {
+                    throw new \RuntimeException('Private key of invalid type!');
+        }
 
-        if(!($keys->getPublic() instanceof RSAPublicKey))
-            throw new \RuntimeException('Public key of invalid type!');
+        if(!($keys->getPublic() instanceof RSAPublicKey)) {
+                    throw new \RuntimeException('Public key of invalid type!');
+        }
 
         $jwk                                          = new RSAJWK();
         $jwk->public_key                              = $keys->getPublic();
@@ -134,7 +140,9 @@ 
      */
     static public function fromPublicKey(PublicKey $public_key)
     {
-        if (!($public_key instanceof RSAPublicKey)) throw new InvalidJWKType();
+        if (!($public_key instanceof RSAPublicKey)) {
+         throw new InvalidJWKType();
+        }
         $jwk = new RSAJWK();
         $jwk->public_key = $public_key;
         $jwk->set[RSAKeysParameters::Exponent] = Base64urlUInt::fromBigInt($public_key->getPublicExponent());
@@ -149,7 +157,9 @@ 
      */
     static public function fromPrivateKey(PrivateKey $private_key)
     {
-        if (!($private_key instanceof RSAPrivateKey)) throw new InvalidJWKType();
+        if (!($private_key instanceof RSAPrivateKey)) {
+         throw new InvalidJWKType();
+        }
         $jwk = new RSAJWK();
         $jwk->private_key = $private_key;
         $jwk->set[RSAKeysParameters::Exponent] = Base64urlUInt::fromBigInt($private_key->getPublicExponent());

src/jwa/cryptographic_algorithms/macs/HSMAC_Algorithm.php

Braces +6 added lines, -3 removed lines

@@ -37,8 +37,9 @@ 
      */
     public function digest(SharedKey $key, $message){
 
-        if($this->getMinKeyLen() > $key->getBitLength())
-            throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $key->getBitLength()));
+        if($this->getMinKeyLen() > $key->getBitLength()) {
+                    throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $key->getBitLength()));
+        }
 
         return hash_hmac($this->getHashingAlgorithm(), $message, $key->getSecret(), true);
     }
@@ -52,7 +53,9 @@ 
      * @throws InvalidKeyTypeAlgorithmException
      */
     public function verify(Key $key, $message, $digest){
-        if(!($key instanceof SharedKey)) throw new InvalidKeyTypeAlgorithmException;
+        if(!($key instanceof SharedKey)) {
+         throw new InvalidKeyTypeAlgorithmException;
+        }
 
         return $digest === $this->digest($key, $message);
     }

src/jwa/cryptographic_algorithms/ContentEncryptionAlgorithms_Registry.php

Braces +3 added lines, -1 removed lines

@@ -68,7 +68,9 @@
      * @return null|ContentEncryptionAlgorithm
      */
     public function get($alg) {
-        if (!$this->isSupported($alg)) return null;
+        if (!$this->isSupported($alg)) {
+         return null;
+        }
         return $this->algorithms[$alg];
     }
 }
\ No newline at end of file

src/jwa/cryptographic_algorithms/digital_signatures/rsa/RSA_Algorithm.php

Braces +18 added lines, -8 removed lines

@@ -45,14 +45,19 @@ 
      */
     public function sign(PrivateKey $private_key, $message)
     {
-        if(!($private_key instanceof RSAPrivateKey)) throw new InvalidKeyTypeAlgorithmException;
+        if(!($private_key instanceof RSAPrivateKey)) {
+         throw new InvalidKeyTypeAlgorithmException;
+        }
 
-        if($this->getMinKeyLen() > $private_key->getBitLength())
-            throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $private_key->getBitLength()));
+        if($this->getMinKeyLen() > $private_key->getBitLength()) {
+                    throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $private_key->getBitLength()));
+        }
 
         $res = $this->rsa_impl->loadKey($private_key->getEncoded());
 
-        if(!$res) throw new InvalidKeyTypeAlgorithmException;
+        if(!$res) {
+         throw new InvalidKeyTypeAlgorithmException;
+        }
 
         $this->rsa_impl->setHash($this->getHashingAlgorithm());
         $this->rsa_impl->setMGFHash($this->getHashingAlgorithm());
@@ -70,14 +75,19 @@ 
      */
     public function verify(Key $key, $message, $signature)
     {
-        if(!($key instanceof RSAPublicKey)) throw new InvalidKeyTypeAlgorithmException;
+        if(!($key instanceof RSAPublicKey)) {
+         throw new InvalidKeyTypeAlgorithmException;
+        }
 
-        if($this->getMinKeyLen() > $key->getBitLength())
-            throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $key->getBitLength()));
+        if($this->getMinKeyLen() > $key->getBitLength()) {
+                    throw new InvalidKeyLengthAlgorithmException(sprintf('min len %s - cur len %s.',$this->getMinKeyLen(), $key->getBitLength()));
+        }
 
         $res = $this->rsa_impl->loadKey($key->getEncoded());
 
-        if(!$res) throw new InvalidKeyTypeAlgorithmException;
+        if(!$res) {
+         throw new InvalidKeyTypeAlgorithmException;
+        }
 
         $this->rsa_impl->setHash($this->getHashingAlgorithm());
         $this->rsa_impl->setMGFHash($this->getHashingAlgorithm());

src/jwa/cryptographic_algorithms/key_management/rsa/RSA_KeyManagementAlgorithm.php

Braces +24 added lines, -16 removed lines

@@ -47,19 +47,23 @@ 
      */
     public function encrypt(Key $key, $message)
     {
-        if(!($key instanceof RSAPublicKey))
-            throw new InvalidKeyTypeAlgorithmException('key is not public');
+        if(!($key instanceof RSAPublicKey)) {
+                    throw new InvalidKeyTypeAlgorithmException('key is not public');
+        }
 
-        if($key->getFormat() !== 'PKCS8')
-            throw new InvalidKeyTypeAlgorithmException('keys is not on PKCS1 format');
+        if($key->getFormat() !== 'PKCS8') {
+                    throw new InvalidKeyTypeAlgorithmException('keys is not on PKCS1 format');
+        }
 
         $res = $this->rsa_impl->loadKey($key->getEncoded());
 
-        if(!$res)
-            throw new InvalidKeyTypeAlgorithmException('could not parse the key');
+        if(!$res) {
+                    throw new InvalidKeyTypeAlgorithmException('could not parse the key');
+        }
 
-        if($this->rsa_impl->getSize() < $this->getMinKeyLen())
-            throw new InvalidKeyTypeAlgorithmException('len is invalid');
+        if($this->rsa_impl->getSize() < $this->getMinKeyLen()) {
+                    throw new InvalidKeyTypeAlgorithmException('len is invalid');
+        }
 
         return $this->rsa_impl->encrypt($message);
     }
@@ -72,20 +76,24 @@ 
      */
     public function decrypt(Key $key, $enc_message){
 
-        if(!($key instanceof RSAPrivateKey))
-            throw new InvalidKeyTypeAlgorithmException('key is not private');
+        if(!($key instanceof RSAPrivateKey)) {
+                    throw new InvalidKeyTypeAlgorithmException('key is not private');
+        }
 
 
-        if($key->getFormat() !== 'PKCS1')
-            throw new InvalidKeyTypeAlgorithmException('keys is not on PKCS1 format');
+        if($key->getFormat() !== 'PKCS1') {
+                    throw new InvalidKeyTypeAlgorithmException('keys is not on PKCS1 format');
+        }
 
         $res = $this->rsa_impl->loadKey($key->getEncoded());
 
-        if(!$res)
-            throw new InvalidKeyTypeAlgorithmException('could not parse the key');
+        if(!$res) {
+                    throw new InvalidKeyTypeAlgorithmException('could not parse the key');
+        }
 
-        if($this->rsa_impl->getSize() < $this->getMinKeyLen())
-            throw new InvalidKeyTypeAlgorithmException('len is invalid');
+        if($this->rsa_impl->getSize() < $this->getMinKeyLen()) {
+                    throw new InvalidKeyTypeAlgorithmException('len is invalid');
+        }
 
         return $this->rsa_impl->decrypt($enc_message);
     }

src/jwa/cryptographic_algorithms/content_encryption/AES_CBC_HS/AES_CBC_HMAC_SHA2_Algorithm.php

Braces +6 added lines, -4 removed lines

@@ -60,8 +60,9 @@ 
     {
         $key_len = strlen($key);
 
-        if($this->getMinKeyLen() > ByteUtil::bitLength($key_len))
-            throw new InvalidKeyLengthAlgorithmException;
+        if($this->getMinKeyLen() > ByteUtil::bitLength($key_len)) {
+                    throw new InvalidKeyLengthAlgorithmException;
+        }
 
         $enc_key_len = $key_len / 2;
         // ENC_KEY = final ENC_KEY_LEN octets of K
@@ -133,8 +134,9 @@ 
      */
     public function decrypt($cypher_text, $key, $iv, $aad, $tag)
     {
-        if(!$this->checkAuthenticationTag($cypher_text, $key, $iv, $aad, $tag))
-            throw new InvalidAuthenticationTagException;
+        if(!$this->checkAuthenticationTag($cypher_text, $key, $iv, $aad, $tag)) {
+                    throw new InvalidAuthenticationTagException;
+        }
 
         $enc_key_len = strlen($key) / 2;
         // ENC_KEY = final ENC_KEY_LEN octets of K

src/jwt/impl/JWT.php

Braces +6 added lines, -2 removed lines

@@ -108,9 +108,13 @@
     {
         $now = new \DateTime();
         $exp = $this->getClaimSet()->getExpirationTime()->getDateTime();
-        if($exp < $now) return true;
+        if($exp < $now) {
+         return true;
+        }
         $iat = $this->getClaimSet()->getIssuedAt()->getDateTime();
-        if($iat > $now) return true;
+        if($iat > $now) {
+         return true;
+        }
         $diff = $now->getTimestamp() - $iat->getTimestamp();
         return $diff > $tolerance;
     }