smarcet / JOSE4PHP

src/jwk/IAsymmetricJWK.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwk/RSAKeysParameters.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 use jwa\JSONWebSignatureAndEncryptionAlgorithms;

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
      */
     const Exponent = 'e';
 
-    public static $public_key_params = array ( self::Modulus, self::Exponent);
+    public static $public_key_params = array(self::Modulus, self::Exponent);
 
     /**
      * The "d" (private exponent) parameter contains the private exponent
@@ -79,7 +79,7 @@ 
 
 
 
-    public static $producers_private_key_params = array (
+    public static $producers_private_key_params = array(
         self::FirstPrimeFactor,
         self::SecondPrimeFactor,
         self::FirstFactorCRTExponent,

src/jwk/JSONWebKeyKeyOperationsValues.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwk/JSONWebKeyTypes.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwk/impl/OctetSequenceJWK.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk\impl;
 

Spacing +5 added lines, -5 removed lines

@@ -40,14 +40,14 @@ 
     protected function __construct(Key $secret, $headers = array())
     {
 
-        if(empty($secret))
+        if (empty($secret))
             throw new InvalidOctetSequenceJWKException('secret is not set!.');
 
         $this->set[JSONWebKeyParameters::KeyType] = new StringOrURI(JSONWebKeyTypes::OctetSequence);
 
         parent::__construct($headers);
 
-        if(count($headers) === 0 ) return;
+        if (count($headers) === 0) return;
 
         $b64 = new Base64UrlRepresentation();
 
@@ -72,17 +72,17 @@ 
      * @param string $use
      * @return IJWK
      */
-    static public function fromSecret(Key $key, $alg = null, $use = JSONWebKeyPublicKeyUseValues::Signature){
+    static public function fromSecret(Key $key, $alg = null, $use = JSONWebKeyPublicKeyUseValues::Signature) {
 
         $headers = array();
 
-        if(!empty($alg)) {
+        if (!empty($alg)) {
 
             $headers[JSONWebKeyParameters::Algorithm] = $alg;
         }
 
         $headers[JSONWebKeyParameters::PublicKeyUse] = $use;
 
-        return new OctetSequenceJWK($key, $headers) ;
+        return new OctetSequenceJWK($key, $headers);
     }
 }
\ No newline at end of file

Braces +6 added lines, -3 removed lines

@@ -40,14 +40,17 @@
     protected function __construct(Key $secret, $headers = array())
     {
 
-        if(empty($secret))
-            throw new InvalidOctetSequenceJWKException('secret is not set!.');
+        if(empty($secret)) {
+                    throw new InvalidOctetSequenceJWKException('secret is not set!.');
+        }
 
         $this->set[JSONWebKeyParameters::KeyType] = new StringOrURI(JSONWebKeyTypes::OctetSequence);
 
         parent::__construct($headers);
 
-        if(count($headers) === 0 ) return;
+        if(count($headers) === 0 ) {
+         return;
+        }
 
         $b64 = new Base64UrlRepresentation();
 

src/jwk/impl/JWKSpecification.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk\impl;
 

Spacing +2 added lines, -3 removed lines

@@ -46,8 +46,7 @@ 
      * @param string $use
      * @param null|string $kid
      */
-    public function __construct
-    (
+    public function __construct(
         $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256,
         $use = JSONWebKeyPublicKeyUseValues::Signature,
         $kid = null
@@ -58,7 +57,7 @@ 
         $this->kid  = $kid;
     }
 
-    public function getAlg(){
+    public function getAlg() {
         return $this->alg;
     }
 

src/jwk/impl/RSAJWKPEMPrivateKeySpecification.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk\impl;
 

Spacing +2 added lines, -3 removed lines

@@ -36,15 +36,14 @@
      * @param string $alg
      * @param string $use
      */
-    public function __construct
-    (
+    public function __construct(
         $key_pem,
         $password = self::WithoutPassword,
         $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256,
         $use = JSONWebKeyPublicKeyUseValues::Signature
     )
     {
-        parent::__construct($key_pem , $alg, $use);
+        parent::__construct($key_pem, $alg, $use);
         $this->password = $password;
     }
     /**

src/jwk/impl/OctetSequenceJWKFactory.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk\impl;
 

Spacing +15 added lines, -23 removed lines

@@ -41,28 +41,24 @@ 
     static public function build(IJWKSpecification $spec)
     {
 
-        if(is_null($spec)) throw new \InvalidArgumentException('missing spec param');
+        if (is_null($spec)) throw new \InvalidArgumentException('missing spec param');
 
-        $algorithm = DigitalSignatures_MACs_Registry::getInstance()->get
-        (
+        $algorithm = DigitalSignatures_MACs_Registry::getInstance()->get(
             $spec->getAlg()
         );
 
-        if(is_null($algorithm))
-            $algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
-            (
+        if (is_null($algorithm))
+            $algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get(
                 $spec->getAlg()
             );
 
-        if(is_null($algorithm))
-            $algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
-            (
+        if (is_null($algorithm))
+            $algorithm = KeyManagementAlgorithms_Registry::getInstance()->get(
                 $spec->getAlg()
             );
 
-        if(is_null($algorithm))
-            throw new InvalidJWKAlgorithm
-            (
+        if (is_null($algorithm))
+            throw new InvalidJWKAlgorithm(
                 sprintf(
                     'alg %s not supported!',
                     $spec->getAlg()
@@ -70,31 +66,27 @@ 
             );
 
 
-        if($algorithm->getKeyType() !== JSONWebKeyTypes::OctetSequence)
-            throw new InvalidJWKAlgorithm
-            (
-                sprintf
-                (
+        if ($algorithm->getKeyType() !== JSONWebKeyTypes::OctetSequence)
+            throw new InvalidJWKAlgorithm(
+                sprintf(
                     'key type %s not supported!',
                     $algorithm->getKeyType()
                 )
             );
 
-        if(!($spec instanceof OctetSequenceJWKSpecification)) throw new JWKInvalidSpecException;
+        if (!($spec instanceof OctetSequenceJWKSpecification)) throw new JWKInvalidSpecException;
 
         $shared_secret = $spec->getSharedSecret();
         $secret_len    = strlen($shared_secret);
 
-        if($secret_len === 0 )
+        if ($secret_len === 0)
         {
             $generator = Utils_Registry::getInstance()->get(Utils_Registry::RandomNumberGeneratorService);
             $shared_secret = $generator->invoke($algorithm->getMinKeyLen() / 8);
         }
 
-        return OctetSequenceJWK::fromSecret
-        (
-            new SymmetricSharedKey
-            (
+        return OctetSequenceJWK::fromSecret(
+            new SymmetricSharedKey(
                 $shared_secret
             ),
             $spec->getAlg(),

Braces +18 added lines, -10 removed lines

@@ -41,37 +41,42 @@ 
     static public function build(IJWKSpecification $spec)
     {
 
-        if(is_null($spec)) throw new \InvalidArgumentException('missing spec param');
+        if(is_null($spec)) {
+         throw new \InvalidArgumentException('missing spec param');
+        }
 
         $algorithm = DigitalSignatures_MACs_Registry::getInstance()->get
         (
             $spec->getAlg()
         );
 
-        if(is_null($algorithm))
-            $algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
+        if(is_null($algorithm)) {
+                    $algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
             (
                 $spec->getAlg()
             );
+        }
 
-        if(is_null($algorithm))
-            $algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
+        if(is_null($algorithm)) {
+                    $algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
             (
                 $spec->getAlg()
             );
+        }
 
-        if(is_null($algorithm))
-            throw new InvalidJWKAlgorithm
+        if(is_null($algorithm)) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf(
                     'alg %s not supported!',
                     $spec->getAlg()
                 )
             );
+        }
 
 
-        if($algorithm->getKeyType() !== JSONWebKeyTypes::OctetSequence)
-            throw new InvalidJWKAlgorithm
+        if($algorithm->getKeyType() !== JSONWebKeyTypes::OctetSequence) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf
                 (
@@ -79,8 +84,11 @@ 
                     $algorithm->getKeyType()
                 )
             );
+        }
 
-        if(!($spec instanceof OctetSequenceJWKSpecification)) throw new JWKInvalidSpecException;
+        if(!($spec instanceof OctetSequenceJWKSpecification)) {
+         throw new JWKInvalidSpecException;
+        }
 
         $shared_secret = $spec->getSharedSecret();
         $secret_len    = strlen($shared_secret);

src/jwk/impl/JWKSet.php

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk\impl;
 

Spacing +16 added lines, -16 removed lines

@@ -42,11 +42,11 @@ 
      * @param JWK[] $keys
      * @throws JWKInvalidIdentifierException
      */
-    public function __construct(array $keys = array()){
+    public function __construct(array $keys = array()) {
 
         $this->set[JWKSetParameters::Keys] = new JsonArray(array());
 
-        foreach($keys as $k){
+        foreach ($keys as $k) {
             $this->addKey($k);
         }
     }
@@ -56,7 +56,7 @@ 
      */
     public function getKeys()
     {
-        if(isset($this->set[JWKSetParameters::Keys]))
+        if (isset($this->set[JWKSetParameters::Keys]))
             return $this->set[JWKSetParameters::Keys]->getValue();
         return array();
     }
@@ -70,18 +70,18 @@ 
     {
         $id = $key->getId();
 
-        if(empty($id))
+        if (empty($id))
             throw new JWKInvalidIdentifierException('key id is empty!');
 
-        if(array_key_exists($id->getValue(), $this->keys_ids))
+        if (array_key_exists($id->getValue(), $this->keys_ids))
             throw new JWKInvalidIdentifierException(sprintf('id %s already exists!'), $key->getId()->getValue());
 
-        if(!isset($this->set[JWKSetParameters::Keys]))
+        if (!isset($this->set[JWKSetParameters::Keys]))
             $this->set[JWKSetParameters::Keys] = new JsonArray(array());
 
         $keys = $this->set[JWKSetParameters::Keys];
         $keys->append($key);
-        $this->set[JWKSetParameters::Keys] = $keys ;
+        $this->set[JWKSetParameters::Keys] = $keys;
         $this->keys_ids[$id->getValue()] = $key;
     }
 
@@ -91,7 +91,7 @@ 
      */
     public function getKeyById($kid)
     {
-        if(!array_key_exists($kid, $this->keys_ids)) return null;
+        if (!array_key_exists($kid, $this->keys_ids)) return null;
         return $this->keys_ids[$kid];
     }
 
@@ -101,27 +101,27 @@ 
      * @throws InvalidJWKAlgorithm
      * @throws JWKInvalidIdentifierException
      */
-    static public function fromJson($json){
-        $json = str_replace( array("\n","\r","\t"), '', trim($json));
+    static public function fromJson($json) {
+        $json = str_replace(array("\n", "\r", "\t"), '', trim($json));
         $res  = json_decode($json, true);
-        if(!isset($res[JWKSetParameters::Keys])) throw new JWKInvalidIdentifierException;
+        if (!isset($res[JWKSetParameters::Keys])) throw new JWKInvalidIdentifierException;
         $keys = $res[JWKSetParameters::Keys];
         $jwk_set = new JWKSet;
-        foreach($keys as $key){
+        foreach ($keys as $key) {
             $kty = @$key[JSONWebKeyParameters::KeyType];
             $kid = @$key[JSONWebKeyParameters::KeyId];
             $use = @$key[JSONWebKeyParameters::PublicKeyUse];
             $alg = @$key[JSONWebKeyParameters::Algorithm];
-            if(empty($alg)) $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256;
+            if (empty($alg)) $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256;
 
-            if(empty($kty) || empty($kid) || empty($use)) continue;
+            if (empty($kty) || empty($kid) || empty($use)) continue;
 
-            if(!in_array($kty, JSONWebKeyTypes::$supported_keys)) continue;
+            if (!in_array($kty, JSONWebKeyTypes::$supported_keys)) continue;
 
             $n        = @$key[RSAKeysParameters::Modulus];
             $e        = @$key[RSAKeysParameters::Exponent];
             $x5c      = @$key[PublicJSONWebKeyParameters::X_509CertificateChain];
-            if(is_null($x5c)) $x5c = array();
+            if (is_null($x5c)) $x5c = array();
             $x5u      = @$key[PublicJSONWebKeyParameters::X_509Url];
             $x5t      = @$key[PublicJSONWebKeyParameters::X_509CertificateSHA_1_Thumbprint];
             $x5t_S256 = @$key[PublicJSONWebKeyParameters::X_509CertificateSHA_256_Thumbprint];

Braces +30 added lines, -14 removed lines

@@ -56,8 +56,9 @@ 
      */
     public function getKeys()
     {
-        if(isset($this->set[JWKSetParameters::Keys]))
-            return $this->set[JWKSetParameters::Keys]->getValue();
+        if(isset($this->set[JWKSetParameters::Keys])) {
+                    return $this->set[JWKSetParameters::Keys]->getValue();
+        }
         return array();
     }
 
@@ -70,14 +71,17 @@ 
     {
         $id = $key->getId();
 
-        if(empty($id))
-            throw new JWKInvalidIdentifierException('key id is empty!');
+        if(empty($id)) {
+                    throw new JWKInvalidIdentifierException('key id is empty!');
+        }
 
-        if(array_key_exists($id->getValue(), $this->keys_ids))
-            throw new JWKInvalidIdentifierException(sprintf('id %s already exists!'), $key->getId()->getValue());
+        if(array_key_exists($id->getValue(), $this->keys_ids)) {
+                    throw new JWKInvalidIdentifierException(sprintf('id %s already exists!'), $key->getId()->getValue());
+        }
 
-        if(!isset($this->set[JWKSetParameters::Keys]))
-            $this->set[JWKSetParameters::Keys] = new JsonArray(array());
+        if(!isset($this->set[JWKSetParameters::Keys])) {
+                    $this->set[JWKSetParameters::Keys] = new JsonArray(array());
+        }
 
         $keys = $this->set[JWKSetParameters::Keys];
         $keys->append($key);
@@ -91,7 +95,9 @@ 
      */
     public function getKeyById($kid)
     {
-        if(!array_key_exists($kid, $this->keys_ids)) return null;
+        if(!array_key_exists($kid, $this->keys_ids)) {
+         return null;
+        }
         return $this->keys_ids[$kid];
     }
 
@@ -104,7 +110,9 @@ 
     static public function fromJson($json){
         $json = str_replace( array("\n","\r","\t"), '', trim($json));
         $res  = json_decode($json, true);
-        if(!isset($res[JWKSetParameters::Keys])) throw new JWKInvalidIdentifierException;
+        if(!isset($res[JWKSetParameters::Keys])) {
+         throw new JWKInvalidIdentifierException;
+        }
         $keys = $res[JWKSetParameters::Keys];
         $jwk_set = new JWKSet;
         foreach($keys as $key){
@@ -112,16 +120,24 @@ 
             $kid = @$key[JSONWebKeyParameters::KeyId];
             $use = @$key[JSONWebKeyParameters::PublicKeyUse];
             $alg = @$key[JSONWebKeyParameters::Algorithm];
-            if(empty($alg)) $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256;
+            if(empty($alg)) {
+             $alg = JSONWebSignatureAndEncryptionAlgorithms::RS256;
+            }
 
-            if(empty($kty) || empty($kid) || empty($use)) continue;
+            if(empty($kty) || empty($kid) || empty($use)) {
+             continue;
+            }
 
-            if(!in_array($kty, JSONWebKeyTypes::$supported_keys)) continue;
+            if(!in_array($kty, JSONWebKeyTypes::$supported_keys)) {
+             continue;
+            }
 
             $n        = @$key[RSAKeysParameters::Modulus];
             $e        = @$key[RSAKeysParameters::Exponent];
             $x5c      = @$key[PublicJSONWebKeyParameters::X_509CertificateChain];
-            if(is_null($x5c)) $x5c = array();
+            if(is_null($x5c)) {
+             $x5c = array();
+            }
             $x5u      = @$key[PublicJSONWebKeyParameters::X_509Url];
             $x5t      = @$key[PublicJSONWebKeyParameters::X_509CertificateSHA_1_Thumbprint];
             $x5t_S256 = @$key[PublicJSONWebKeyParameters::X_509CertificateSHA_256_Thumbprint];