smarcet / JOSE4PHP

src/jwe/impl/specs/JWE_ParamsSpecification.php

Spacing +3 added lines, -3 removed lines

@@ -63,13 +63,13 @@
      * @throws JWEInvalidPayloadException
      * @throws JWEInvalidRecipientKeyException
      */
-    public function __construct(IJWK $key, StringOrURI $alg, StringOrURI $enc, $payload,  JsonValue $zip = null)
+    public function __construct(IJWK $key, StringOrURI $alg, StringOrURI $enc, $payload, JsonValue $zip = null)
     {
 
-        if(is_null($key))
+        if (is_null($key))
             throw new JWEInvalidRecipientKeyException();
 
-        if(is_null($payload))
+        if (is_null($payload))
             throw new JWEInvalidPayloadException('missing payload');
 
         $this->key     = $key;

Braces +6 added lines, -4 removed lines

@@ -66,11 +66,13 @@
     public function __construct(IJWK $key, StringOrURI $alg, StringOrURI $enc, $payload,  JsonValue $zip = null)
     {
 
-        if(is_null($key))
-            throw new JWEInvalidRecipientKeyException();
+        if(is_null($key)) {
+                    throw new JWEInvalidRecipientKeyException();
+        }
 
-        if(is_null($payload))
-            throw new JWEInvalidPayloadException('missing payload');
+        if(is_null($payload)) {
+                    throw new JWEInvalidPayloadException('missing payload');
+        }
 
         $this->key     = $key;
         $this->alg     = $alg;

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwe/impl/_ContentEncryptionKey.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
      * @param string $format
      * @param string $value
      */
-    public function __construct($alg, $format, $value){
+    public function __construct($alg, $format, $value) {
         $this->alg    = $alg;
         $this->format = $format;
         $this->value  = $value;

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwe/impl/JWE.php

Braces +60 added lines, -39 removed lines

@@ -98,8 +98,9 @@ 
     protected function __construct(IJWEJOSEHeader $header, IJWSPayloadSpec $payload = null)
     {
         $this->header = $header;
-        if(!is_null($payload))
-            $this->setPayload($payload);
+        if(!is_null($payload)) {
+                    $this->setPayload($payload);
+        }
     }
 
     /**
@@ -155,8 +156,9 @@ 
             $this->decrypt();
         }
 
-        if (is_null($this->payload))
-            $this->payload = JWSPayloadFactory::build('');
+        if (is_null($this->payload)) {
+                    $this->payload = JWSPayloadFactory::build('');
+        }
 
         return $this->payload->getRaw();
     }
@@ -212,16 +214,21 @@ 
      */
     private function getKeyManagementMode(EncryptionAlgorithm $alg)
     {
-        if($alg instanceof KeyEncryption)
-            return KeyManagementModeValues::KeyEncryption;
-        if($alg instanceof KeyWrapping)
-            return KeyManagementModeValues::KeyWrapping;
-        if($alg instanceof DirectKeyAgreement)
-            return KeyManagementModeValues::DirectKeyAgreement;
-        if($alg instanceof KeyAgreementWithKeyWrapping)
-            return KeyManagementModeValues::KeyAgreementWithKeyWrapping;
-        if($alg instanceof DirectEncryption)
-            return KeyManagementModeValues::DirectEncryption;
+        if($alg instanceof KeyEncryption) {
+                    return KeyManagementModeValues::KeyEncryption;
+        }
+        if($alg instanceof KeyWrapping) {
+                    return KeyManagementModeValues::KeyWrapping;
+        }
+        if($alg instanceof DirectKeyAgreement) {
+                    return KeyManagementModeValues::DirectKeyAgreement;
+        }
+        if($alg instanceof KeyAgreementWithKeyWrapping) {
+                    return KeyManagementModeValues::KeyAgreementWithKeyWrapping;
+        }
+        if($alg instanceof DirectEncryption) {
+                    return KeyManagementModeValues::DirectEncryption;
+        }
     }
 
     /**
@@ -236,11 +243,12 @@ 
     private function encrypt()
     {
 
-        if (is_null($this->jwk))
-            throw new JWEInvalidRecipientKeyException;
+        if (is_null($this->jwk)) {
+                    throw new JWEInvalidRecipientKeyException;
+        }
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
+        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString()) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf
                 (
@@ -249,16 +257,18 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $recipient_public_key     = $this->jwk->getKey(JSONWebKeyKeyOperationsValues::EncryptContent);
 
         $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get($this->header->getAlgorithm()->getString());
 
-        if (is_null($key_management_algorithm))
-            throw new JWEUnsupportedKeyManagementAlgorithmException(sprintf('alg %s', $this->header->getAlgorithm()->getString()));
+        if (is_null($key_management_algorithm)) {
+                    throw new JWEUnsupportedKeyManagementAlgorithmException(sprintf('alg %s', $this->header->getAlgorithm()->getString()));
+        }
 
-        if($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
+        if($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm()) {
+                    throw new InvalidKeyTypeAlgorithmException
             (
                 sprintf
                 (
@@ -267,14 +277,15 @@ 
                     $recipient_public_key->getAlgorithm()
                 )
             );
+        }
 
         $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
         (
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
-        if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
+        if (is_null($content_encryption_algorithm)) {
+                    throw new JWEUnsupportedContentEncryptionAlgorithmException
             (
                 sprintf
                 (
@@ -282,6 +293,7 @@ 
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
             );
+        }
 
         $key_management_mode = $this->getKeyManagementMode($key_management_algorithm);
 
@@ -354,8 +366,8 @@ 
         $key_management_mode   = $this->getKeyManagementMode($alg);
         $recipient_private_key = $this->jwk->getKey(JSONWebKeyKeyOperationsValues::DecryptContentAndValidateDecryption);
 
-        if($alg->getKeyType() !== $recipient_private_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
+        if($alg->getKeyType() !== $recipient_private_key->getAlgorithm()) {
+                    throw new InvalidKeyTypeAlgorithmException
             (
                 sprintf
                 (
@@ -364,6 +376,7 @@ 
                     $recipient_private_key->getAlgorithm()
                 )
             );
+        }
 
         switch($key_management_mode){
             /**
@@ -387,13 +400,15 @@ 
              * symmetric key.
              */
             case KeyManagementModeValues::DirectEncryption:
-                if(!empty($this->enc_cek))
-                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                if(!empty($this->enc_cek)) {
+                                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                }
                 return $recipient_private_key;
             break;
             case KeyManagementModeValues::DirectKeyAgreement:
-                if(!empty($this->enc_cek))
-                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                if(!empty($this->enc_cek)) {
+                                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                }
                 throw new \Exception('unsupported Key Management Mode!');
             break;
         }
@@ -412,13 +427,16 @@ 
      */
     private function decrypt()
     {
-        if (is_null($this->jwk))
-            throw new JWEInvalidRecipientKeyException();
+        if (is_null($this->jwk)) {
+                    throw new JWEInvalidRecipientKeyException();
+        }
 
-        if (!$this->should_decrypt) return $this;
+        if (!$this->should_decrypt) {
+         return $this;
+        }
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
+        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString()) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf
                 (
@@ -427,14 +445,15 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
         (
             $this->header->getAlgorithm()->getString()
         );
 
-        if (is_null($key_management_algorithm))
-            throw new JWEUnsupportedKeyManagementAlgorithmException
+        if (is_null($key_management_algorithm)) {
+                    throw new JWEUnsupportedKeyManagementAlgorithmException
             (
                 sprintf
                 (
@@ -442,14 +461,15 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
         (
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
-        if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
+        if (is_null($content_encryption_algorithm)) {
+                    throw new JWEUnsupportedContentEncryptionAlgorithmException
             (
                 sprintf
                 (
@@ -457,6 +477,7 @@ 
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
             );
+        }
 
         $this->cek = $this->decryptJWEEncryptedKey($key_management_algorithm);
 

Doc Comments +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      * @throws JWEInvalidRecipientKeyException
      * @throws JWEUnsupportedContentEncryptionAlgorithmException
      * @throws JWEUnsupportedKeyManagementAlgorithmException

Spacing +42 added lines, -62 removed lines

@@ -97,7 +97,7 @@ 
     protected function __construct(IJWEJOSEHeader $header, IJWSPayloadSpec $payload = null)
     {
         $this->header = $header;
-        if(!is_null($payload))
+        if (!is_null($payload))
             $this->setPayload($payload);
     }
 
@@ -157,7 +157,7 @@ 
         if (is_null($this->payload))
             $this->payload = JWSPayloadFactory::build('');
 
-        return ($this->payload instanceof IJWSPayloadRawSpec) ? $this->payload->getRaw():'';
+        return ($this->payload instanceof IJWSPayloadRawSpec) ? $this->payload->getRaw() : '';
     }
 
     /**
@@ -183,7 +183,7 @@ 
          * the result be the JWE Encrypted Key.
          */
          $key_management_mode = $this->getKeyManagementMode($alg);
-         switch($key_management_mode){
+         switch ($key_management_mode) {
              case KeyManagementModeValues::KeyEncryption:
              case KeyManagementModeValues::KeyWrapping:
              case KeyManagementModeValues::KeyAgreementWithKeyWrapping:
@@ -211,15 +211,15 @@ 
      */
     private function getKeyManagementMode(EncryptionAlgorithm $alg)
     {
-        if($alg instanceof KeyEncryption)
+        if ($alg instanceof KeyEncryption)
             return KeyManagementModeValues::KeyEncryption;
-        if($alg instanceof KeyWrapping)
+        if ($alg instanceof KeyWrapping)
             return KeyManagementModeValues::KeyWrapping;
-        if($alg instanceof DirectKeyAgreement)
+        if ($alg instanceof DirectKeyAgreement)
             return KeyManagementModeValues::DirectKeyAgreement;
-        if($alg instanceof KeyAgreementWithKeyWrapping)
+        if ($alg instanceof KeyAgreementWithKeyWrapping)
             return KeyManagementModeValues::KeyAgreementWithKeyWrapping;
-        if($alg instanceof DirectEncryption)
+        if ($alg instanceof DirectEncryption)
             return KeyManagementModeValues::DirectEncryption;
     }
 
@@ -238,11 +238,9 @@ 
         if (is_null($this->jwk))
             throw new JWEInvalidRecipientKeyException;
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
-            (
-                sprintf
-                (
+        if ($this->jwk->getAlgorithm()->getValue() !== $this->header->getAlgorithm()->getString())
+            throw new InvalidJWKAlgorithm(
+                sprintf(
                     'mismatch between algorithm intended for use with the key %s and the cryptographic algorithm used to encrypt or determine the value of the CEK %s',
                     $this->jwk->getAlgorithm()->getValue(),
                     $this->header->getAlgorithm()->getString()
@@ -256,27 +254,22 @@ 
         if (is_null($key_management_algorithm))
             throw new JWEUnsupportedKeyManagementAlgorithmException(sprintf('alg %s', $this->header->getAlgorithm()->getString()));
 
-        if($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
-            (
-                sprintf
-                (
+        if ($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm())
+            throw new InvalidKeyTypeAlgorithmException(
+                sprintf(
                     'key should be for alg %s, %s instead.',
                     $key_management_algorithm->getKeyType(),
                     $recipient_public_key->getAlgorithm()
                 )
             );
 
-        $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
-        (
+        $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get(
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
         if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
-            (
-                sprintf
-                (
+            throw new JWEUnsupportedContentEncryptionAlgorithmException(
+                sprintf(
                     'enc %s',
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
@@ -284,8 +277,7 @@ 
 
         $key_management_mode = $this->getKeyManagementMode($key_management_algorithm);
 
-        $this->cek     = ContentEncryptionKeyFactory::build
-        (
+        $this->cek = ContentEncryptionKeyFactory::build(
             $recipient_public_key,
             $key_management_mode,
             $content_encryption_algorithm
@@ -299,7 +291,7 @@ 
          * algorithm); otherwise, let the JWE Initialization Vector be the
          * empty octet sequence.
          */
-        $this->iv      = '';
+        $this->iv = '';
 
         if (!is_null($iv_size = $content_encryption_algorithm->getIVSize()))
         {
@@ -308,7 +300,7 @@ 
         // We encrypt the payload and get the tag
         $jwt_shared_protected_header = JOSEHeaderSerializer::serialize($this->header);
 
-        $payload = ($this->payload instanceof IJWSPayloadRawSpec) ? $this->payload->getRaw():'';
+        $payload = ($this->payload instanceof IJWSPayloadRawSpec) ? $this->payload->getRaw() : '';
         $zip     = $this->header->getCompressionAlgorithm();
         /**
          * If a "zip" parameter was included, compress the plaintext using
@@ -316,10 +308,10 @@ 
          * sequence representing the compressed plaintext; otherwise, let M
          * be the octet sequence representing the plaintext.
          */
-        if(!is_null($zip))
+        if (!is_null($zip))
         {
             $compression__algorithm = CompressionAlgorithms_Registry::getInstance()->get($zip->getValue());
-            $payload  = $compression__algorithm->compress($payload);
+            $payload = $compression__algorithm->compress($payload);
         }
 
         /**
@@ -329,8 +321,7 @@ 
          * JWE Authentication Tag (which is the Authentication Tag output
          * from the encryption operation).
          */
-        list($this->cipher_text, $this->tag) = $content_encryption_algorithm->encrypt
-        (
+        list($this->cipher_text, $this->tag) = $content_encryption_algorithm->encrypt(
             $payload,
             $this->cek->getEncoded(),
             $this->iv,
@@ -348,23 +339,21 @@ 
      * @throws InvalidKeyTypeAlgorithmException
      * @throws \Exception
      */
-    private function decryptJWEEncryptedKey(EncryptionAlgorithm $alg){
+    private function decryptJWEEncryptedKey(EncryptionAlgorithm $alg) {
 
         $key_management_mode   = $this->getKeyManagementMode($alg);
         $recipient_private_key = $this->jwk->getKey(JSONWebKeyKeyOperationsValues::DecryptContentAndValidateDecryption);
 
-        if($alg->getKeyType() !== $recipient_private_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
-            (
-                sprintf
-                (
+        if ($alg->getKeyType() !== $recipient_private_key->getAlgorithm())
+            throw new InvalidKeyTypeAlgorithmException(
+                sprintf(
                     'key should be for alg %s, %s instead.',
                     $alg->getKeyType(),
                     $recipient_private_key->getAlgorithm()
                 )
             );
 
-        switch($key_management_mode){
+        switch ($key_management_mode) {
             /**
              * When Key Wrapping, Key Encryption, or Key Agreement with Key
              * Wrapping are employed, decrypt the JWE Encrypted Key to produce
@@ -386,12 +375,12 @@ 
              * symmetric key.
              */
             case KeyManagementModeValues::DirectEncryption:
-                if(!empty($this->enc_cek))
+                if (!empty($this->enc_cek))
                     throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
                 return $recipient_private_key;
             break;
             case KeyManagementModeValues::DirectKeyAgreement:
-                if(!empty($this->enc_cek))
+                if (!empty($this->enc_cek))
                     throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
                 throw new \Exception('unsupported Key Management Mode!');
             break;
@@ -416,42 +405,34 @@ 
 
         if (!$this->should_decrypt) return $this;
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
-            (
-                sprintf
-                (
+        if ($this->jwk->getAlgorithm()->getValue() !== $this->header->getAlgorithm()->getString())
+            throw new InvalidJWKAlgorithm(
+                sprintf(
                     'mismatch between algorithm intended for use with the key %s and the cryptographic algorithm used to encrypt or determine the value of the CEK %s',
                     $this->jwk->getAlgorithm()->getValue(),
                     $this->header->getAlgorithm()->getString()
                 )
             );
 
-        $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
-        (
+        $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get(
             $this->header->getAlgorithm()->getString()
         );
 
         if (is_null($key_management_algorithm))
-            throw new JWEUnsupportedKeyManagementAlgorithmException
-            (
-                sprintf
-                (
+            throw new JWEUnsupportedKeyManagementAlgorithmException(
+                sprintf(
                     'alg %s',
                     $this->header->getAlgorithm()->getString()
                 )
             );
 
-        $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
-        (
+        $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get(
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
         if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
-            (
-                sprintf
-                (
+            throw new JWEUnsupportedContentEncryptionAlgorithmException(
+                sprintf(
                     'enc %s',
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
@@ -472,8 +453,7 @@ 
          * rejecting the input without emitting any decrypted output if the
          * JWE Authentication Tag is incorrect.
          */
-        $plain_text = $content_encryption_algorithm->decrypt
-        (
+        $plain_text = $content_encryption_algorithm->decrypt(
             $this->cipher_text,
             $this->cek->getEncoded(),
             $this->iv,
@@ -481,12 +461,12 @@ 
             $this->tag
         );
 
-        $zip     = $this->header->getCompressionAlgorithm();
+        $zip = $this->header->getCompressionAlgorithm();
         /**
          * If a "zip" parameter was included, uncompress the decrypted
          * plaintext using the specified compression algorithm.
          */
-        if(!is_null($zip))
+        if (!is_null($zip))
         {
             $compression__algorithm = CompressionAlgorithms_Registry::getInstance()->get($zip->getValue());
             $plain_text = $compression__algorithm->uncompress($plain_text);

src/jwe/RegisteredJWEJOSEHeaderNames.php

Spacing +3 added lines, -3 removed lines

@@ -64,7 +64,7 @@ 
     const CompressionAlgorithm = 'zip';
 
 
-    public static $registered_basic_headers_set = array (
+    public static $registered_basic_headers_set = array(
         self::Algorithm,
         self::EncryptionAlgorithm,
         self::KeyID,
@@ -73,8 +73,8 @@ 
         self::ContentType,
     );
 
-    public static $registered_basic_headers_set_types = array (
-        self::Algorithm            => JsonTypes::StringOrURI ,
+    public static $registered_basic_headers_set_types = array(
+        self::Algorithm            => JsonTypes::StringOrURI,
         self::Type                 => JsonTypes::StringOrURI,
         self::ContentType          => JsonTypes::StringOrURI,
         self::KeyID                => JsonTypes::JsonValue,

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwe/KeyManagementModeValues.php

Spacing +2 added lines, -2 removed lines

@@ -24,9 +24,9 @@
 
     const KeyWrapping = 'wrap';
 
-    const DirectKeyAgreement ='agree';
+    const DirectKeyAgreement = 'agree';
 
-    const KeyAgreementWithKeyWrapping ='agree_wrap';
+    const KeyAgreementWithKeyWrapping = 'agree_wrap';
 
     const DirectEncryption = 'dir';
 }
\ No newline at end of file

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/jwe/JWEFactory.php

Spacing +11 added lines, -16 removed lines

@@ -37,41 +37,36 @@ 
     static public function build(IJWE_Specification $spec)
     {
 
-        if($spec instanceof IJWE_ParamsSpecification)
+        if ($spec instanceof IJWE_ParamsSpecification)
         {
 
-            if($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption)
-                throw new InvalidJWKType
-                (
-                    sprintf
-                    (
+            if ($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption)
+                throw new InvalidJWKType(
+                    sprintf(
                         'use %s not supported (should be "enc")',
                         $spec->getRecipientKey()->getKeyUse()->getString()
                     )
                 );
 
-            if($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString())
-                throw new InvalidJWKAlgorithm
-                (
-                    sprintf
-                    (
+            if ($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString())
+                throw new InvalidJWKAlgorithm(
+                    sprintf(
                         'mismatch between algorithm intended for use with the key %s and the cryptographic algorithm used to encrypt or determine the value of the CEK %s',
                         $spec->getAlg()->getString(),
                         $spec->getRecipientKey()->getAlgorithm()->getString()
                     )
                 );
 
-            $header = new JWEJOSEHeader
-            (
+            $header = new JWEJOSEHeader(
                 $spec->getAlg(),
                 $spec->getEnc(),
                 $spec->getRecipientKey()->getId()
             );
 
             //set zip alg
-            $zip    = $spec->getZip();
+            $zip = $spec->getZip();
 
-            if(!is_null($zip))
+            if (!is_null($zip))
                 $header->setCompressionAlgorithm($zip);
 
             $jwe = JWE::fromHeaderAndPayload($header, $spec->getPayload());
@@ -81,7 +76,7 @@ 
             return $jwe;
         }
 
-        if($spec instanceof IJWE_CompactFormatSpecification)
+        if ($spec instanceof IJWE_CompactFormatSpecification)
         {
             return JWE::fromCompactSerialization($spec->getCompactFormat());
         }

Braces +9 added lines, -6 removed lines

@@ -40,8 +40,8 @@ 
         if($spec instanceof IJWE_ParamsSpecification)
         {
 
-            if($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption)
-                throw new InvalidJWKType
+            if($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption) {
+                            throw new InvalidJWKType
                 (
                     sprintf
                     (
@@ -49,9 +49,10 @@ 
                         $spec->getRecipientKey()->getKeyUse()->getString()
                     )
                 );
+            }
 
-            if($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString())
-                throw new InvalidJWKAlgorithm
+            if($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString()) {
+                            throw new InvalidJWKAlgorithm
                 (
                     sprintf
                     (
@@ -60,6 +61,7 @@ 
                         $spec->getRecipientKey()->getAlgorithm()->getString()
                     )
                 );
+            }
 
             $header = new JWEJOSEHeader
             (
@@ -71,8 +73,9 @@ 
             //set zip alg
             $zip    = $spec->getZip();
 
-            if(!is_null($zip))
-                $header->setCompressionAlgorithm($zip);
+            if(!is_null($zip)) {
+                            $header->setCompressionAlgorithm($zip);
+            }
 
             $jwe = JWE::fromHeaderAndPayload($header, $spec->getPayload());
 

src/jwe/compression_algorithms/CompressionAlgorithms_Registry.php

Spacing +7 added lines, -7 removed lines

@@ -31,7 +31,7 @@ 
 
     private $algorithms = array();
 
-    private function __construct(){
+    private function __construct() {
 
         $this->algorithms[CompressionAlgorithmsNames::Deflate] = new Deflate;
         $this->algorithms[CompressionAlgorithmsNames::GZip]    = new GZip;
@@ -39,13 +39,13 @@ 
 
     }
 
-    private function __clone(){}
+    private function __clone() {}
 
     /**
      * @return CompressionAlgorithms_Registry
      */
-    public static function getInstance(){
-        if(!is_object(self::$instance)){
+    public static function getInstance() {
+        if (!is_object(self::$instance)) {
             self::$instance = new CompressionAlgorithms_Registry();
         }
         return self::$instance;
@@ -55,7 +55,7 @@ 
      * @param string $alg
      * @return bool
      */
-    public function isSupported($alg){
+    public function isSupported($alg) {
         return array_key_exists($alg, $this->algorithms);
     }
 
@@ -63,8 +63,8 @@ 
      * @param $alg
      * @return null|CompressionAlgorithm
      */
-    public function get($alg){
-        if(!$this->isSupported($alg)) return null;
+    public function get($alg) {
+        if (!$this->isSupported($alg)) return null;
         return $this->algorithms[$alg];
     }
 }
\ No newline at end of file

Braces +3 added lines, -1 removed lines

@@ -64,7 +64,9 @@
      * @return null|CompressionAlgorithm
      */
     public function get($alg){
-        if(!$this->isSupported($alg)) return null;
+        if(!$this->isSupported($alg)) {
+         return null;
+        }
         return $this->algorithms[$alg];
     }
 }
\ No newline at end of file

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/security/SymmetricSharedKey.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     /**
      * @param string $secret
      */
-    public function __construct($secret){
+    public function __construct($secret) {
         $this->secret = $secret;
     }
 

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;
 

src/security/rsa/_RSAPrivateKeyPEMFornat.php

Spacing +5 added lines, -5 removed lines

@@ -33,11 +33,11 @@ 
      * @param string $password
      * @throws RSABadPEMFormat
      */
-    public function __construct($pem_format, $password = null){
+    public function __construct($pem_format, $password = null) {
 
         parent::__construct($pem_format, $password);
         $this->d = $this->rsa_imp->exponent;
-        if($this->d->toString() === $this->e->toString())
+        if ($this->d->toString() === $this->e->toString())
             throw new RSABadPEMFormat(sprintf('pem %s is a public key!', $pem_format));
     }
 
@@ -57,9 +57,9 @@ 
     public function getEncoded()
     {
         $pem = $this->rsa_imp->getPrivateKey(CRYPT_RSA_PUBLIC_FORMAT_PKCS1);
-        $pem = preg_replace('/\-+BEGIN RSA PRIVATE KEY\-+/','',$pem);
-        $pem = preg_replace('/\-+END RSA PRIVATE KEY\-+/','',$pem);
-        $pem = str_replace( array("\n","\r","\t"), '', trim($pem));
+        $pem = preg_replace('/\-+BEGIN RSA PRIVATE KEY\-+/', '', $pem);
+        $pem = preg_replace('/\-+END RSA PRIVATE KEY\-+/', '', $pem);
+        $pem = str_replace(array("\n", "\r", "\t"), '', trim($pem));
         return $pem;
     }
 

Braces +3 added lines, -2 removed lines

@@ -37,8 +37,9 @@
 
         parent::__construct($pem_format, $password);
         $this->d = $this->rsa_imp->exponent;
-        if($this->d->toString() === $this->e->toString())
-            throw new RSABadPEMFormat(sprintf('pem %s is a public key!', $pem_format));
+        if($this->d->toString() === $this->e->toString()) {
+                    throw new RSABadPEMFormat(sprintf('pem %s is a public key!', $pem_format));
+        }
     }
 
     /**

Indentation +11 added lines, -11 removed lines

@@ -1,16 +1,16 @@
 <?php
 /**
- * Copyright 2015 OpenStack Foundation
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- **/
+     * Copyright 2015 OpenStack Foundation
+     * Licensed under the Apache License, Version 2.0 (the "License");
+     * you may not use this file except in compliance with the License.
+     * You may obtain a copy of the License at
+     * http://www.apache.org/licenses/LICENSE-2.0
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     **/
 
 namespace jwk;