smarcet / JOSE4PHP

src/jwe/impl/JWEJOSEHeaderFactory.php

Braces +3 added lines, -1 removed lines

@@ -40,7 +40,9 @@
             $type  = @RegisteredJWEJOSEHeaderNames::$registered_basic_headers_set_types[$header_name];
             if(!is_null($value))
             {
-                if(is_null($type)) continue;
+                if(is_null($type)) {
+                 continue;
+                }
                 $class    = new \ReflectionClass($type);
                 $value    = $class->newInstanceArgs(array($value));
             }

src/jwe/impl/JWEJOSEHeader.php

Braces +3 added lines, -2 removed lines

@@ -50,8 +50,9 @@
 
         $this->set[RegisteredJWEJOSEHeaderNames::EncryptionAlgorithm] = $enc;
 
-        if(!is_null($zip) && CompressionAlgorithms_Registry::getInstance()->get($zip->getValue()))
-            $this->set[RegisteredJWEJOSEHeaderNames::CompressionAlgorithm] = $zip;
+        if(!is_null($zip) && CompressionAlgorithms_Registry::getInstance()->get($zip->getValue())) {
+                    $this->set[RegisteredJWEJOSEHeaderNames::CompressionAlgorithm] = $zip;
+        }
     }
 
     /**

src/jwe/impl/JWESerializer.php

Braces +3 added lines, -1 removed lines

@@ -47,7 +47,9 @@
 
     static public function deserialize($input){
         $parts = explode(IBasicJWT::SegmentSeparator, $input);
-        if (count($parts) !== 5) throw new JWEInvalidCompactFormatException;
+        if (count($parts) !== 5) {
+         throw new JWEInvalidCompactFormatException;
+        }
 
         $header = JWEJOSEHeaderSerializer::deserialize($parts[0]);
         $enc_cek = JWTRawSerializer::deserialize($parts[1]);

src/jwe/impl/specs/JWE_ParamsSpecification.php

Braces +6 added lines, -4 removed lines

@@ -66,11 +66,13 @@
     public function __construct(IJWK $key, StringOrURI $alg, StringOrURI $enc, $payload,  JsonValue $zip = null)
     {
 
-        if(is_null($key))
-            throw new JWEInvalidRecipientKeyException();
+        if(is_null($key)) {
+                    throw new JWEInvalidRecipientKeyException();
+        }
 
-        if(is_null($payload))
-            throw new JWEInvalidPayloadException('missing payload');
+        if(is_null($payload)) {
+                    throw new JWEInvalidPayloadException('missing payload');
+        }
 
         $this->key     = $key;
         $this->alg     = $alg;

src/jwe/impl/JWE.php

Braces +60 added lines, -39 removed lines

@@ -98,8 +98,9 @@ 
     protected function __construct(IJWEJOSEHeader $header, IJWSPayloadSpec $payload = null)
     {
         $this->header = $header;
-        if(!is_null($payload))
-            $this->setPayload($payload);
+        if(!is_null($payload)) {
+                    $this->setPayload($payload);
+        }
     }
 
     /**
@@ -155,8 +156,9 @@ 
             $this->decrypt();
         }
 
-        if (is_null($this->payload))
-            $this->payload = JWSPayloadFactory::build('');
+        if (is_null($this->payload)) {
+                    $this->payload = JWSPayloadFactory::build('');
+        }
 
         return $this->payload->getRaw();
     }
@@ -212,16 +214,21 @@ 
      */
     private function getKeyManagementMode(EncryptionAlgorithm $alg)
     {
-        if($alg instanceof KeyEncryption)
-            return KeyManagementModeValues::KeyEncryption;
-        if($alg instanceof KeyWrapping)
-            return KeyManagementModeValues::KeyWrapping;
-        if($alg instanceof DirectKeyAgreement)
-            return KeyManagementModeValues::DirectKeyAgreement;
-        if($alg instanceof KeyAgreementWithKeyWrapping)
-            return KeyManagementModeValues::KeyAgreementWithKeyWrapping;
-        if($alg instanceof DirectEncryption)
-            return KeyManagementModeValues::DirectEncryption;
+        if($alg instanceof KeyEncryption) {
+                    return KeyManagementModeValues::KeyEncryption;
+        }
+        if($alg instanceof KeyWrapping) {
+                    return KeyManagementModeValues::KeyWrapping;
+        }
+        if($alg instanceof DirectKeyAgreement) {
+                    return KeyManagementModeValues::DirectKeyAgreement;
+        }
+        if($alg instanceof KeyAgreementWithKeyWrapping) {
+                    return KeyManagementModeValues::KeyAgreementWithKeyWrapping;
+        }
+        if($alg instanceof DirectEncryption) {
+                    return KeyManagementModeValues::DirectEncryption;
+        }
     }
 
     /**
@@ -236,11 +243,12 @@ 
     private function encrypt()
     {
 
-        if (is_null($this->jwk))
-            throw new JWEInvalidRecipientKeyException;
+        if (is_null($this->jwk)) {
+                    throw new JWEInvalidRecipientKeyException;
+        }
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
+        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString()) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf
                 (
@@ -249,16 +257,18 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $recipient_public_key     = $this->jwk->getKey(JSONWebKeyKeyOperationsValues::EncryptContent);
 
         $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get($this->header->getAlgorithm()->getString());
 
-        if (is_null($key_management_algorithm))
-            throw new JWEUnsupportedKeyManagementAlgorithmException(sprintf('alg %s', $this->header->getAlgorithm()->getString()));
+        if (is_null($key_management_algorithm)) {
+                    throw new JWEUnsupportedKeyManagementAlgorithmException(sprintf('alg %s', $this->header->getAlgorithm()->getString()));
+        }
 
-        if($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
+        if($key_management_algorithm->getKeyType() !== $recipient_public_key->getAlgorithm()) {
+                    throw new InvalidKeyTypeAlgorithmException
             (
                 sprintf
                 (
@@ -267,14 +277,15 @@ 
                     $recipient_public_key->getAlgorithm()
                 )
             );
+        }
 
         $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
         (
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
-        if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
+        if (is_null($content_encryption_algorithm)) {
+                    throw new JWEUnsupportedContentEncryptionAlgorithmException
             (
                 sprintf
                 (
@@ -282,6 +293,7 @@ 
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
             );
+        }
 
         $key_management_mode = $this->getKeyManagementMode($key_management_algorithm);
 
@@ -354,8 +366,8 @@ 
         $key_management_mode   = $this->getKeyManagementMode($alg);
         $recipient_private_key = $this->jwk->getKey(JSONWebKeyKeyOperationsValues::DecryptContentAndValidateDecryption);
 
-        if($alg->getKeyType() !== $recipient_private_key->getAlgorithm())
-            throw new InvalidKeyTypeAlgorithmException
+        if($alg->getKeyType() !== $recipient_private_key->getAlgorithm()) {
+                    throw new InvalidKeyTypeAlgorithmException
             (
                 sprintf
                 (
@@ -364,6 +376,7 @@ 
                     $recipient_private_key->getAlgorithm()
                 )
             );
+        }
 
         switch($key_management_mode){
             /**
@@ -387,13 +400,15 @@ 
              * symmetric key.
              */
             case KeyManagementModeValues::DirectEncryption:
-                if(!empty($this->enc_cek))
-                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                if(!empty($this->enc_cek)) {
+                                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                }
                 return $recipient_private_key;
             break;
             case KeyManagementModeValues::DirectKeyAgreement:
-                if(!empty($this->enc_cek))
-                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                if(!empty($this->enc_cek)) {
+                                    throw new JWEInvalidCompactFormatException('JWE Encrypted Key value is not an empty octetsequence.');
+                }
                 throw new \Exception('unsupported Key Management Mode!');
             break;
         }
@@ -412,13 +427,16 @@ 
      */
     private function decrypt()
     {
-        if (is_null($this->jwk))
-            throw new JWEInvalidRecipientKeyException();
+        if (is_null($this->jwk)) {
+                    throw new JWEInvalidRecipientKeyException();
+        }
 
-        if (!$this->should_decrypt) return $this;
+        if (!$this->should_decrypt) {
+         return $this;
+        }
 
-        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString())
-            throw new InvalidJWKAlgorithm
+        if($this->jwk->getAlgorithm()->getValue()!== $this->header->getAlgorithm()->getString()) {
+                    throw new InvalidJWKAlgorithm
             (
                 sprintf
                 (
@@ -427,14 +445,15 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $key_management_algorithm = KeyManagementAlgorithms_Registry::getInstance()->get
         (
             $this->header->getAlgorithm()->getString()
         );
 
-        if (is_null($key_management_algorithm))
-            throw new JWEUnsupportedKeyManagementAlgorithmException
+        if (is_null($key_management_algorithm)) {
+                    throw new JWEUnsupportedKeyManagementAlgorithmException
             (
                 sprintf
                 (
@@ -442,14 +461,15 @@ 
                     $this->header->getAlgorithm()->getString()
                 )
             );
+        }
 
         $content_encryption_algorithm = ContentEncryptionAlgorithms_Registry::getInstance()->get
         (
             $this->header->getEncryptionAlgorithm()->getString()
         );
 
-        if (is_null($content_encryption_algorithm))
-            throw new JWEUnsupportedContentEncryptionAlgorithmException
+        if (is_null($content_encryption_algorithm)) {
+                    throw new JWEUnsupportedContentEncryptionAlgorithmException
             (
                 sprintf
                 (
@@ -457,6 +477,7 @@ 
                     $this->header->getEncryptionAlgorithm()->getString()
                 )
             );
+        }
 
         $this->cek = $this->decryptJWEEncryptedKey($key_management_algorithm);
 

src/jwe/JWEFactory.php

Braces +9 added lines, -6 removed lines

@@ -40,8 +40,8 @@ 
         if($spec instanceof IJWE_ParamsSpecification)
         {
 
-            if($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption)
-                throw new InvalidJWKType
+            if($spec->getRecipientKey()->getKeyUse()->getString() !== JSONWebKeyPublicKeyUseValues::Encryption) {
+                            throw new InvalidJWKType
                 (
                     sprintf
                     (
@@ -49,9 +49,10 @@ 
                         $spec->getRecipientKey()->getKeyUse()->getString()
                     )
                 );
+            }
 
-            if($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString())
-                throw new InvalidJWKAlgorithm
+            if($spec->getAlg()->getString() !== $spec->getRecipientKey()->getAlgorithm()->getString()) {
+                            throw new InvalidJWKAlgorithm
                 (
                     sprintf
                     (
@@ -60,6 +61,7 @@ 
                         $spec->getRecipientKey()->getAlgorithm()->getString()
                     )
                 );
+            }
 
             $header = new JWEJOSEHeader
             (
@@ -71,8 +73,9 @@ 
             //set zip alg
             $zip    = $spec->getZip();
 
-            if(!is_null($zip))
-                $header->setCompressionAlgorithm($zip);
+            if(!is_null($zip)) {
+                            $header->setCompressionAlgorithm($zip);
+            }
 
             $jwe = JWE::fromHeaderAndPayload($header, $spec->getPayload());
 

src/jwe/compression_algorithms/CompressionAlgorithms_Registry.php

Braces +3 added lines, -1 removed lines

@@ -64,7 +64,9 @@
      * @return null|CompressionAlgorithm
      */
     public function get($alg){
-        if(!$this->isSupported($alg)) return null;
+        if(!$this->isSupported($alg)) {
+         return null;
+        }
         return $this->algorithms[$alg];
     }
 }
\ No newline at end of file

src/security/rsa/_RSAPrivateKeyPEMFornat.php

Braces +3 added lines, -2 removed lines

@@ -37,8 +37,9 @@
 
         parent::__construct($pem_format, $password);
         $this->d = $this->rsa_imp->exponent;
-        if($this->d->toString() === $this->e->toString())
-            throw new RSABadPEMFormat(sprintf('pem %s is a public key!', $pem_format));
+        if($this->d->toString() === $this->e->toString()) {
+                    throw new RSABadPEMFormat(sprintf('pem %s is a public key!', $pem_format));
+        }
     }
 
     /**

src/security/rsa/_AbstractRSAKeyPEMFornat.php

Braces +6 added lines, -3 removed lines

@@ -48,12 +48,15 @@
         $this->pem_format = $pem_format;
         $this->rsa_imp    = new \Crypt_RSA();
 
-        if(!empty($password))
-            $this->rsa_imp->setPassword($password);
+        if(!empty($password)) {
+                    $this->rsa_imp->setPassword($password);
+        }
 
         $res = $this->rsa_imp->loadKey($this->pem_format, CRYPT_RSA_PRIVATE_FORMAT_PKCS1);
 
-        if(!$res) throw new RSABadPEMFormat(sprintf('pem %s',$pem_format ));
+        if(!$res) {
+         throw new RSABadPEMFormat(sprintf('pem %s',$pem_format ));
+        }
 
         $this->n = $this->rsa_imp->modulus;
     }