Conditions | 1 |
Paths | 1 |
Total Lines | 75 |
Code Lines | 58 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
45 | public function testParse(): void |
||
46 | { |
||
47 | // Skipped. |
||
48 | $offset = 0; |
||
49 | $element = ElementHexa::parse('ABC', null, $offset); |
||
50 | $this->assertFalse($element); |
||
51 | $this->assertEquals(0, $offset); |
||
52 | |||
53 | $offset = 0; |
||
54 | $element = ElementHexa::parse(' [ <0020> 5 6 ]', null, $offset); |
||
55 | $this->assertFalse($element); |
||
56 | $this->assertEquals(0, $offset); |
||
57 | |||
58 | $offset = 0; |
||
59 | $element = ElementHexa::parse(' << <0020> >>', null, $offset); |
||
60 | $this->assertFalse($element); |
||
61 | $this->assertEquals(0, $offset); |
||
62 | |||
63 | $offset = 0; |
||
64 | $element = ElementHexa::parse(' / <0020> ', null, $offset); |
||
65 | $this->assertFalse($element); |
||
66 | $this->assertEquals(0, $offset); |
||
67 | |||
68 | $offset = 0; |
||
69 | $element = ElementHexa::parse(' 0 <0020> ', null, $offset); |
||
70 | $this->assertFalse($element); |
||
71 | $this->assertEquals(0, $offset); |
||
72 | |||
73 | $offset = 0; |
||
74 | $element = ElementHexa::parse(" 0 \n <0020> ", null, $offset); |
||
75 | $this->assertFalse($element); |
||
76 | $this->assertEquals(0, $offset); |
||
77 | |||
78 | // Valid. |
||
79 | $offset = 0; |
||
80 | $element = ElementHexa::parse(' <0020> ', null, $offset); |
||
81 | $this->assertEquals(' ', $element->getContent()); |
||
82 | $this->assertEquals(7, $offset); |
||
83 | |||
84 | $offset = 0; |
||
85 | $element = ElementHexa::parse(' <0020> ', null, $offset); |
||
86 | $this->assertEquals(' ', $element->getContent()); |
||
87 | $this->assertEquals(7, $offset); |
||
88 | |||
89 | $offset = 0; |
||
90 | $element = ElementHexa::parse(' <0020>', null, $offset); |
||
91 | $this->assertEquals(' ', $element->getContent()); |
||
92 | $this->assertEquals(7, $offset); |
||
93 | |||
94 | $offset = 0; |
||
95 | $element = ElementHexa::parse('<0020>', null, $offset); |
||
96 | $this->assertEquals(' ', $element->getContent()); |
||
97 | $this->assertEquals(6, $offset); |
||
98 | |||
99 | $offset = 0; |
||
100 | $element = ElementHexa::parse(" \n <0020> ", null, $offset); |
||
101 | $this->assertEquals(' ', $element->getContent()); |
||
102 | $this->assertEquals(9, $offset); |
||
103 | |||
104 | $offset = 0; |
||
105 | $element = ElementHexa::parse(" \n <5465616d204d616e6167656d656e742053797374656d73> ", null, $offset); |
||
106 | $this->assertEquals('Team Management Systems', $element->getContent()); |
||
107 | $this->assertEquals(51, $offset); |
||
108 | |||
109 | $offset = 0; |
||
110 | $element = ElementHexa::parse(" \n <5265706f72744275696c646572> ", null, $offset); |
||
111 | $this->assertTrue($element instanceof ElementString); |
||
112 | $this->assertEquals('ReportBuilder', $element->getContent()); |
||
113 | $this->assertEquals(31, $offset); |
||
114 | |||
115 | $offset = 0; |
||
116 | $element = ElementHexa::parse(" \n <443a3230313331323137313334303435303027303027> ", null, $offset); |
||
117 | $this->assertTrue($element instanceof ElementDate); |
||
118 | $this->assertEquals('2013-12-17T13:40:45+00:00', (string) $element); |
||
119 | $this->assertEquals(49, $offset); |
||
120 | } |
||
122 |