Passed
Pull Request — master (#345)
by
unknown
02:11 queued 10s
created

ParserSub::exposedParseObject()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 2
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 1 Features 1
Metric Value
cc 1
eloc 1
c 1
b 1
f 1
nc 1
nop 3
dl 0
loc 2
rs 10
1
<?php
2
3
/**
4
 * @file This file is part of the PdfParser library.
5
 *
6
 * @author  Konrad Abicht <[email protected]>
7
 * @date    2020-06-01
8
 *
9
 * @author  Sébastien MALOT <[email protected]>
10
 * @date    2017-01-03
11
 *
12
 * @license LGPLv3
13
 * @url     <https://github.com/smalot/pdfparser>
14
 *
15
 *  PdfParser is a pdf library written in PHP, extraction oriented.
16
 *  Copyright (C) 2017 - Sébastien MALOT <[email protected]>
17
 *
18
 *  This program is free software: you can redistribute it and/or modify
19
 *  it under the terms of the GNU Lesser General Public License as published by
20
 *  the Free Software Foundation, either version 3 of the License, or
21
 *  (at your option) any later version.
22
 *
23
 *  This program is distributed in the hope that it will be useful,
24
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
25
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
26
 *  GNU Lesser General Public License for more details.
27
 *
28
 *  You should have received a copy of the GNU Lesser General Public License
29
 *  along with this program.
30
 *  If not, see <http://www.pdfparser.org/sites/default/LICENSE.txt>.
31
 */
32
33
namespace Tests\Smalot\PdfParser\Integration;
34
35
use Exception;
36
use Smalot\PdfParser\Parser;
37
use Smalot\PdfParser\Document;
38
use Smalot\PdfParser\XObject\Image;
39
use Tests\Smalot\PdfParser\TestCase;
40
41
class ParserTest extends TestCase
42
{
43
    public function setUp()
44
    {
45
        parent::setUp();
46
47
        $this->fixture = new Parser();
48
    }
49
50
    public function testParseFile()
51
    {
52
        $directory = $this->rootDir.'/samples/bugs';
53
54
        if (is_dir($directory)) {
55
            $files = scandir($directory);
56
57
            foreach ($files as $file) {
58
                if (preg_match('/^.*\.pdf$/i', $file)) {
59
                    try {
60
                        $document = $this->fixture->parseFile($directory.'/'.$file);
61
                        $pages = $document->getPages();
62
                        $this->assertTrue(0 < \count($pages));
63
64
                        foreach ($pages as $page) {
65
                            $content = $page->getText();
66
                            $this->assertTrue(0 < \strlen($content));
67
                        }
68
                    } catch (Exception $e) {
69
                        if (
70
                            'Secured pdf file are currently not supported.' !== $e->getMessage()
71
                            && 0 != strpos($e->getMessage(), 'TCPDF_PARSER')
72
                        ) {
73
                            throw $e;
74
                        }
75
                    }
76
                }
77
            }
78
        }
79
    }
80
81
    /**
82
     * Tests that xrefs with line breaks between id and position are parsed correctly
83
     *
84
     * @see https://github.com/smalot/pdfparser/issues/336
85
     */
86
    public function testIssue19()
87
    {
88
        $fixture = new ParserSub();
89
        $structure = [
90
            [
91
                '<<',
92
                [
93
                    [
94
                        '/',
95
                        'Type',
96
                        7735,
97
                    ],
98
                    [
99
                        '/',
100
                        'ObjStm',
101
                        7742,
102
                    ]
103
                ]
104
            ],
105
            [
106
                'stream',
107
                '',
108
                7804,
109
                [
110
                    "17\n0",
111
                    []
112
                ]
113
            ]
114
        ];
115
        $document = new Document();
116
117
        $fixture->exposedParseObject('19_0', $structure, $document);
118
        $objects = $fixture->getObjects();
119
120
        $this->assertArrayHasKey('17_0', $objects);
121
    }
122
123
    /**
124
     * Test that issue related pdf can now be parsed
125
     *
126
     * @see https://github.com/smalot/pdfparser/issues/267
127
     */
128
    public function testIssue267()
129
    {
130
        $filename = $this->rootDir.'/samples/bugs/Issue267_array_access_on_int.pdf';
131
132
        $document = $this->fixture->parseFile($filename);
133
134
        $this->assertEquals(Image::class, \get_class($document->getObjectById('128_0')));
135
        $this->assertStringContainsString('4 von 4', $document->getText());
136
    }
137
}
138
139
class ParserSub extends Parser {
140
    public function exposedParseObject($id, $structure, $document) {
141
        return $this->parseObject($id, $structure, $document);
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->parseObject($id, $structure, $document) targeting Smalot\PdfParser\Parser::parseObject() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
142
    }
143
144
    public function getObjects() {
145
        return $this->objects;
146
    }
147
}
148