Conditions | 1 |
Paths | 1 |
Total Lines | 100 |
Code Lines | 54 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
52 | public function testGetCommandsText() |
||
53 | { |
||
54 | $content = "/R14 30 Tf 0.999016 0 0 1 137.4 |
||
55 | 342.561 Tm |
||
56 | [(A)-168.854( BC D)-220.905(\\(E\\))20.905<20>] |
||
57 | TJ /R14 17.16 Tf <20> Tj |
||
58 | 0.999014 0 0 1 336.84 319.161 Tm T* ( \x00m)Tj |
||
59 | /R14 20.04 Tf |
||
60 | ET Q |
||
61 | q -124.774 124.127 5.64213 5.67154 930.307 4436.95 cm |
||
62 | BI"; |
||
63 | |||
64 | $offset = 0; |
||
65 | $parts = $this->getPdfObjectInstance(new Document())->getCommandsText($content, $offset); |
||
66 | $reference = [ |
||
67 | [ |
||
68 | self::TYPE => '/', |
||
69 | self::OPERATOR => 'Tf', |
||
70 | self::COMMAND => 'R14 30', |
||
71 | ], |
||
72 | [ |
||
73 | self::TYPE => '', |
||
74 | self::OPERATOR => 'Tm', |
||
75 | self::COMMAND => "0.999016 0 0 1 137.4\n342.561", |
||
76 | ], |
||
77 | [ |
||
78 | self::TYPE => '[', |
||
79 | self::OPERATOR => 'TJ', |
||
80 | self::COMMAND => [ |
||
81 | [ |
||
82 | self::TYPE => '(', |
||
83 | self::OPERATOR => '', |
||
84 | self::COMMAND => 'A', |
||
85 | ], |
||
86 | [ |
||
87 | self::TYPE => 'n', |
||
88 | self::OPERATOR => '', |
||
89 | self::COMMAND => '-168.854', |
||
90 | ], |
||
91 | [ |
||
92 | self::TYPE => '(', |
||
93 | self::OPERATOR => '', |
||
94 | self::COMMAND => ' BC D', |
||
95 | ], |
||
96 | [ |
||
97 | self::TYPE => 'n', |
||
98 | self::OPERATOR => '', |
||
99 | self::COMMAND => '-220.905', |
||
100 | ], |
||
101 | [ |
||
102 | self::TYPE => '(', |
||
103 | self::OPERATOR => '', |
||
104 | self::COMMAND => '\\(E\\)', |
||
105 | ], |
||
106 | [ |
||
107 | self::TYPE => 'n', |
||
108 | self::OPERATOR => '', |
||
109 | self::COMMAND => '20.905', |
||
110 | ], |
||
111 | [ |
||
112 | self::TYPE => '<', |
||
113 | self::OPERATOR => '', |
||
114 | self::COMMAND => '20', |
||
115 | ], |
||
116 | ], |
||
117 | ], |
||
118 | [ |
||
119 | self::TYPE => '/', |
||
120 | self::OPERATOR => 'Tf', |
||
121 | self::COMMAND => 'R14 17.16', |
||
122 | ], |
||
123 | [ |
||
124 | self::TYPE => '<', |
||
125 | self::OPERATOR => 'Tj', |
||
126 | self::COMMAND => '20', |
||
127 | ], |
||
128 | [ |
||
129 | self::TYPE => '', |
||
130 | self::OPERATOR => 'Tm', |
||
131 | self::COMMAND => '0.999014 0 0 1 336.84 319.161', |
||
132 | ], |
||
133 | [ |
||
134 | self::TYPE => '', |
||
135 | self::OPERATOR => 'T*', |
||
136 | self::COMMAND => '', |
||
137 | ], |
||
138 | [ |
||
139 | self::TYPE => '(', |
||
140 | self::OPERATOR => 'Tj', |
||
141 | self::COMMAND => " \x00m", |
||
142 | ], |
||
143 | [ |
||
144 | self::TYPE => '/', |
||
145 | self::OPERATOR => 'Tf', |
||
146 | self::COMMAND => 'R14 20.04', |
||
147 | ], |
||
148 | ]; |
||
149 | |||
150 | $this->assertEquals($parts, $reference); |
||
151 | $this->assertEquals(172, $offset); |
||
152 | } |
||
250 |