| Conditions | 1 | 
| Paths | 1 | 
| Total Lines | 58 | 
| Code Lines | 44 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 1 | ||
| Bugs | 0 | Features | 0 | 
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 40 | public function testParse() | ||
| 41 |     { | ||
| 42 | // Skipped. | ||
| 43 | $offset = 0; | ||
| 44 |         $element = ElementXRef::parse('ABC', null, $offset); | ||
| 45 | $this->assertFalse($element); | ||
| 46 | $this->assertEquals(0, $offset); | ||
| 47 | |||
| 48 | $offset = 0; | ||
| 49 |         $element = ElementXRef::parse(' [ 5 0 R ]', null, $offset); | ||
| 50 | $this->assertFalse($element); | ||
| 51 | $this->assertEquals(0, $offset); | ||
| 52 | |||
| 53 | $offset = 0; | ||
| 54 |         $element = ElementXRef::parse(' << 5 0 R >>', null, $offset); | ||
| 55 | $this->assertFalse($element); | ||
| 56 | $this->assertEquals(0, $offset); | ||
| 57 | |||
| 58 | $offset = 0; | ||
| 59 |         $element = ElementXRef::parse(' / 5 0 R ', null, $offset); | ||
| 60 | $this->assertFalse($element); | ||
| 61 | $this->assertEquals(0, $offset); | ||
| 62 | |||
| 63 | $offset = 0; | ||
| 64 |         $element = ElementXRef::parse(' 0 5 0 R ', null, $offset); | ||
| 65 | $this->assertFalse($element); | ||
| 66 | $this->assertEquals(0, $offset); | ||
| 67 | |||
| 68 | $offset = 0; | ||
| 69 |         $element = ElementXRef::parse(" 0 \n 5 0 R ", null, $offset); | ||
| 70 | $this->assertFalse($element); | ||
| 71 | $this->assertEquals(0, $offset); | ||
| 72 | |||
| 73 | // Valid. | ||
| 74 | $offset = 0; | ||
| 75 |         $element = ElementXRef::parse(' 5 0 R ', null, $offset); | ||
| 76 |         $this->assertEquals('5_0', $element->getContent()); | ||
| 77 | $this->assertEquals(6, $offset); | ||
| 78 | |||
| 79 | $offset = 0; | ||
| 80 |         $element = ElementXRef::parse(' 5 0 R ', null, $offset); | ||
| 81 |         $this->assertEquals('5_0', $element->getContent()); | ||
| 82 | $this->assertEquals(6, $offset); | ||
| 83 | |||
| 84 | $offset = 0; | ||
| 85 |         $element = ElementXRef::parse(' 5 0 R', null, $offset); | ||
| 86 |         $this->assertEquals('5_0', $element->getContent()); | ||
| 87 | $this->assertEquals(6, $offset); | ||
| 88 | |||
| 89 | $offset = 0; | ||
| 90 |         $element = ElementXRef::parse('5 0 R', null, $offset); | ||
| 91 |         $this->assertEquals('5_0', $element->getContent()); | ||
| 92 | $this->assertEquals(5, $offset); | ||
| 93 | |||
| 94 | $offset = 0; | ||
| 95 |         $element = ElementXRef::parse(" \n 5 0 R ", null, $offset); | ||
| 96 |         $this->assertEquals('5_0', $element->getContent()); | ||
| 97 | $this->assertEquals(8, $offset); | ||
| 98 | } | ||
| 134 |