| Conditions | 1 | 
| Paths | 1 | 
| Total Lines | 95 | 
| Code Lines | 76 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 1 | ||
| Bugs | 0 | Features | 0 | 
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 42 | public function testParse() | ||
| 43 |     { | ||
| 44 | // Skipped. | ||
| 45 | $offset = 0; | ||
| 46 |         $element = ElementDate::parse('ABC', null, $offset); | ||
| 47 | $this->assertFalse($element); | ||
| 48 | $this->assertEquals(0, $offset); | ||
| 49 | |||
| 50 | $offset = 0; | ||
| 51 |         $element = ElementDate::parse(' [ (ABC) 5 6 ]', null, $offset); | ||
| 52 | $this->assertFalse($element); | ||
| 53 | $this->assertEquals(0, $offset); | ||
| 54 | |||
| 55 | $offset = 0; | ||
| 56 |         $element = ElementDate::parse(' << (invalid) >>', null, $offset); | ||
| 57 | $this->assertFalse($element); | ||
| 58 | $this->assertEquals(0, $offset); | ||
| 59 | |||
| 60 | $offset = 0; | ||
| 61 |         $element = ElementDate::parse(' / (FlateDecode) ', null, $offset); | ||
| 62 | $this->assertFalse($element); | ||
| 63 | $this->assertEquals(0, $offset); | ||
| 64 | |||
| 65 | $offset = 0; | ||
| 66 |         $element = ElementDate::parse(' 0 (FlateDecode) ', null, $offset); | ||
| 67 | $this->assertFalse($element); | ||
| 68 | $this->assertEquals(0, $offset); | ||
| 69 | |||
| 70 | $offset = 0; | ||
| 71 |         $element = ElementDate::parse(" 0 \n (FlateDecode) ", null, $offset); | ||
| 72 | $this->assertFalse($element); | ||
| 73 | $this->assertEquals(0, $offset); | ||
| 74 | |||
| 75 | // Valid. | ||
| 76 | $offset = 0; | ||
| 77 |         $element = ElementDate::parse(' (D:20130901235555+02\'00\') ', null, $offset); | ||
| 78 |         $element->setFormat('c'); | ||
| 79 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 80 |         $this->assertEquals('2013-09-01T23:55:55+02:00', (string) $element); | ||
| 81 | $this->assertEquals(26, $offset); | ||
| 82 | |||
| 83 | $offset = 0; | ||
| 84 |         $element = ElementDate::parse(' (D:20130901235555+02\'00\') ', null, $offset); | ||
| 85 |         $element->setFormat('c'); | ||
| 86 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 87 |         $this->assertEquals('2013-09-01T23:55:55+02:00', (string) $element); | ||
| 88 | $this->assertEquals(26, $offset); | ||
| 89 | |||
| 90 | $offset = 0; | ||
| 91 |         $element = ElementDate::parse(' (D:20130901235555+02\'00\')', null, $offset); | ||
| 92 |         $element->setFormat('c'); | ||
| 93 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 94 |         $this->assertEquals('2013-09-01T23:55:55+02:00', (string) $element); | ||
| 95 | $this->assertEquals(26, $offset); | ||
| 96 | |||
| 97 | $offset = 0; | ||
| 98 |         $element = ElementDate::parse('(D:20130901235555+02\'00\')', null, $offset); | ||
| 99 |         $element->setFormat('c'); | ||
| 100 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 101 |         $this->assertEquals('2013-09-01T23:55:55+02:00', (string) $element); | ||
| 102 | $this->assertEquals(25, $offset); | ||
| 103 | |||
| 104 | $offset = 0; | ||
| 105 |         $element = ElementDate::parse(" \n (D:20130901235555+02'00') ", null, $offset); | ||
| 106 |         $element->setFormat('c'); | ||
| 107 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 108 |         $this->assertEquals('2013-09-01T23:55:55+02:00', (string) $element); | ||
| 109 | $this->assertEquals(28, $offset); | ||
| 110 | |||
| 111 | $offset = 0; | ||
| 112 |         $element = ElementDate::parse(" \n (D:20130901235555) ", null, $offset); | ||
| 113 |         $element->setFormat('c'); | ||
| 114 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 115 |         $this->assertEquals('2013-09-01T23:55:55+00:00', (string) $element); | ||
| 116 | $this->assertEquals(21, $offset); | ||
| 117 | |||
| 118 | $offset = 0; | ||
| 119 |         $element = ElementDate::parse("(D:20131206091846Z00'00')", null, $offset); | ||
| 120 |         $element->setFormat('c'); | ||
| 121 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 122 |         $this->assertEquals('2013-12-06T09:18:46+00:00', (string) $element); | ||
| 123 | $this->assertEquals(25, $offset); | ||
| 124 | |||
| 125 | $offset = 0; | ||
| 126 |         $element = ElementDate::parse(" \n (D:1-23-2014, 19:02:15-03'00') ", null, $offset); | ||
| 127 |         $element->setFormat('c'); | ||
| 128 | $this->assertTrue($element->getContent() instanceof DateTime); | ||
| 129 |         $this->assertEquals('2014-01-23T19:02:15-03:00', (string) $element); | ||
| 130 | $this->assertEquals(33, $offset); | ||
| 131 | |||
| 132 | // Format invalid | ||
| 133 | $offset = 0; | ||
| 134 |         $element = ElementDate::parse(" \n (D:2013+02'00') ", null, $offset); | ||
| 135 | $this->assertFalse($element); | ||
| 136 | $this->assertEquals(0, $offset); | ||
| 137 | } | ||
| 183 |