| Conditions | 1 |
| Paths | 1 |
| Total Lines | 53 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 44 | public function testParse() |
||
| 45 | { |
||
| 46 | $document = $this->getDocumentInstance(); |
||
| 47 | |||
| 48 | // Skipped. |
||
| 49 | $offset = 0; |
||
| 50 | $element = ElementArray::parse('ABC', $document, $offset); |
||
| 51 | $this->assertFalse($element); |
||
| 52 | $this->assertEquals(0, $offset); |
||
| 53 | |||
| 54 | $offset = 0; |
||
| 55 | $element = ElementArray::parse(' / [ 4 2 ] ', $document, $offset); |
||
| 56 | $this->assertFalse($element); |
||
| 57 | $this->assertEquals(0, $offset); |
||
| 58 | |||
| 59 | $offset = 0; |
||
| 60 | $element = ElementArray::parse(' 0 [ 4 2 ] ', $document, $offset); |
||
| 61 | $this->assertFalse($element); |
||
| 62 | $this->assertEquals(0, $offset); |
||
| 63 | |||
| 64 | $offset = 0; |
||
| 65 | $element = ElementArray::parse(" 0 \n [ 4 2 ] ", $document, $offset); |
||
| 66 | $this->assertFalse($element); |
||
| 67 | $this->assertEquals(0, $offset); |
||
| 68 | |||
| 69 | // Valid. |
||
| 70 | $offset = 0; |
||
| 71 | $element = ElementArray::parse(' [ 4 2 ] ', $document, $offset); |
||
| 72 | $this->assertTrue($element->contains(2)); |
||
| 73 | $this->assertTrue($element->contains(4)); |
||
| 74 | $this->assertFalse($element->contains(8)); |
||
| 75 | $this->assertEquals(8, $offset); |
||
| 76 | |||
| 77 | $offset = 0; |
||
| 78 | $element = ElementArray::parse(' [ 4 2 ]', $document, $offset); |
||
| 79 | $this->assertTrue($element->contains(2)); |
||
| 80 | $this->assertTrue($element->contains(4)); |
||
| 81 | $this->assertFalse($element->contains(8)); |
||
| 82 | $this->assertEquals(8, $offset); |
||
| 83 | |||
| 84 | $offset = 0; |
||
| 85 | $element = ElementArray::parse('[ 4 2 ]', $document, $offset); |
||
| 86 | $this->assertTrue($element->contains(2)); |
||
| 87 | $this->assertTrue($element->contains(4)); |
||
| 88 | $this->assertFalse($element->contains(8)); |
||
| 89 | $this->assertEquals(7, $offset); |
||
| 90 | |||
| 91 | $offset = 0; |
||
| 92 | $element = ElementArray::parse(" \n [ 4 2 ] ", $document, $offset); |
||
| 93 | $this->assertTrue($element->contains(2)); |
||
| 94 | $this->assertTrue($element->contains(4)); |
||
| 95 | $this->assertFalse($element->contains(8)); |
||
| 96 | $this->assertEquals(10, $offset); |
||
| 97 | } |
||
| 185 |