| Conditions | 1 |
| Paths | 1 |
| Total Lines | 75 |
| Code Lines | 68 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 2 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function testParse() |
||
| 43 | { |
||
| 44 | // Skipped. |
||
| 45 | $offset = 0; |
||
| 46 | $element = \Smalot\PdfParser\Element\ElementString::parse('ABC', null, $offset); |
||
| 47 | $this->assert->boolean($element)->isEqualTo(false); |
||
|
|
|||
| 48 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 49 | $offset = 0; |
||
| 50 | $element = \Smalot\PdfParser\Element\ElementString::parse(' [ (ABC) 5 6 ]', null, $offset); |
||
| 51 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 52 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 53 | $offset = 0; |
||
| 54 | $element = \Smalot\PdfParser\Element\ElementString::parse(' << (invalid) >>', null, $offset); |
||
| 55 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 56 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 57 | $offset = 0; |
||
| 58 | $element = \Smalot\PdfParser\Element\ElementString::parse(' / (FlateDecode) ', null, $offset); |
||
| 59 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 60 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 61 | $offset = 0; |
||
| 62 | $element = \Smalot\PdfParser\Element\ElementString::parse(' 0 (FlateDecode) ', null, $offset); |
||
| 63 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 64 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 65 | $offset = 0; |
||
| 66 | $element = \Smalot\PdfParser\Element\ElementString::parse(" 0 \n (FlateDecode) ", null, $offset); |
||
| 67 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 68 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 69 | |||
| 70 | // Valid. |
||
| 71 | $offset = 0; |
||
| 72 | $element = \Smalot\PdfParser\Element\ElementString::parse(' (Copyright) ', null, $offset); |
||
| 73 | $this->assert->string($element->getContent())->isEqualTo('Copyright'); |
||
| 74 | $this->assert->integer($offset)->isEqualTo(12); |
||
| 75 | $offset = 0; |
||
| 76 | $element = \Smalot\PdfParser\Element\ElementString::parse(' (Copyright) ', null, $offset); |
||
| 77 | $this->assert->string($element->getContent())->isEqualTo('Copyright'); |
||
| 78 | $this->assert->integer($offset)->isEqualTo(12); |
||
| 79 | $offset = 0; |
||
| 80 | $element = \Smalot\PdfParser\Element\ElementString::parse(' (Copyright)', null, $offset); |
||
| 81 | $this->assert->string($element->getContent())->isEqualTo('Copyright'); |
||
| 82 | $this->assert->integer($offset)->isEqualTo(12); |
||
| 83 | $offset = 0; |
||
| 84 | $element = \Smalot\PdfParser\Element\ElementString::parse('(Copyright)', null, $offset); |
||
| 85 | $this->assert->string($element->getContent())->isEqualTo('Copyright'); |
||
| 86 | $this->assert->integer($offset)->isEqualTo(11); |
||
| 87 | $offset = 0; |
||
| 88 | $element = \Smalot\PdfParser\Element\ElementString::parse('(Copy-right2)', null, $offset); |
||
| 89 | $this->assert->string($element->getContent())->isEqualTo('Copy-right2'); |
||
| 90 | $this->assert->integer($offset)->isEqualTo(13); |
||
| 91 | $offset = 0; |
||
| 92 | $element = \Smalot\PdfParser\Element\ElementString::parse(" \n (Copyright) ", null, $offset); |
||
| 93 | $this->assert->string($element->getContent())->isEqualTo('Copyright'); |
||
| 94 | $this->assert->integer($offset)->isEqualTo(14); |
||
| 95 | $offset = 0; |
||
| 96 | $element = \Smalot\PdfParser\Element\ElementString::parse('()', null, $offset); |
||
| 97 | $this->assert->string($element->getContent())->isEqualTo(''); |
||
| 98 | $this->assert->integer($offset)->isEqualTo(2); |
||
| 99 | |||
| 100 | // Complex study case : Unicode + octal. |
||
| 101 | $offset = 0; |
||
| 102 | $element = \Smalot\PdfParser\Element\ElementString::parse("(ABC\\))", null, $offset); |
||
| 103 | $this->assert->string($element->getContent())->isEqualTo('ABC)'); |
||
| 104 | $this->assert->integer($offset)->isEqualTo(7); |
||
| 105 | $offset = 0; |
||
| 106 | $element = \Smalot\PdfParser\Element\ElementString::parse("(\xFE\xFF\\000M)", null, $offset); |
||
| 107 | $this->assert->string($element->getContent())->isEqualTo('M'); |
||
| 108 | $this->assert->integer($offset)->isEqualTo(9); |
||
| 109 | $offset = 0; |
||
| 110 | $element = \Smalot\PdfParser\Element\ElementString::parse("(<20>)", null, $offset); |
||
| 111 | $this->assert->string($element->getContent())->isEqualTo(' '); |
||
| 112 | $this->assert->integer($offset)->isEqualTo(6); |
||
| 113 | $offset = 0; |
||
| 114 | $element = \Smalot\PdfParser\Element\ElementString::parse("(Gutter\\ console\\ assembly)", null, $offset); |
||
| 115 | $this->assert->string($element->getContent())->isEqualTo('Gutter console assembly'); |
||
| 116 | $this->assert->integer($offset)->isEqualTo(27); |
||
| 117 | } |
||
| 157 |