| Conditions | 1 |
| Paths | 1 |
| Total Lines | 53 |
| Code Lines | 48 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function testParse() |
||
| 43 | { |
||
| 44 | // Skipped. |
||
| 45 | $offset = 0; |
||
| 46 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse('ABC', null, $offset); |
||
| 47 | $this->assert->boolean($element)->isEqualTo(false); |
||
|
|
|||
| 48 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 49 | $offset = 0; |
||
| 50 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' [ false ]', null, $offset); |
||
| 51 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 52 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 53 | $offset = 0; |
||
| 54 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' << true >>', null, $offset); |
||
| 55 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 56 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 57 | $offset = 0; |
||
| 58 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' / false ', null, $offset); |
||
| 59 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 60 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 61 | $offset = 0; |
||
| 62 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' 0 true ', null, $offset); |
||
| 63 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 64 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 65 | $offset = 0; |
||
| 66 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(" 0 \n true ", null, $offset); |
||
| 67 | $this->assert->boolean($element)->isEqualTo(false); |
||
| 68 | $this->assert->integer($offset)->isEqualTo(0); |
||
| 69 | |||
| 70 | // Valid. |
||
| 71 | $offset = 0; |
||
| 72 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' true ', null, $offset); |
||
| 73 | $this->assert->boolean($element->getContent())->isEqualTo(true); |
||
| 74 | $this->assert->integer($offset)->isEqualTo(5); |
||
| 75 | $offset = 0; |
||
| 76 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' TRUE ', null, $offset); |
||
| 77 | $this->assert->boolean($element->getContent())->isEqualTo(true); |
||
| 78 | $this->assert->integer($offset)->isEqualTo(5); |
||
| 79 | $offset = 0; |
||
| 80 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(' True', null, $offset); |
||
| 81 | $this->assert->boolean($element->getContent())->isEqualTo(true); |
||
| 82 | $this->assert->integer($offset)->isEqualTo(5); |
||
| 83 | $offset = 0; |
||
| 84 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse('true', null, $offset); |
||
| 85 | $this->assert->boolean($element->getContent())->isEqualTo(true); |
||
| 86 | $this->assert->integer($offset)->isEqualTo(4); |
||
| 87 | $offset = 0; |
||
| 88 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse('False', null, $offset); |
||
| 89 | $this->assert->boolean($element->getContent())->isEqualTo(false); |
||
| 90 | $this->assert->integer($offset)->isEqualTo(5); |
||
| 91 | $offset = 0; |
||
| 92 | $element = \Smalot\PdfParser\Element\ElementBoolean::parse(" \n true ", null, $offset); |
||
| 93 | $this->assert->boolean($element->getContent())->isEqualTo(true); |
||
| 94 | $this->assert->integer($offset)->isEqualTo(7); |
||
| 95 | } |
||
| 136 |