| Conditions | 15 |
| Paths | 46 |
| Total Lines | 50 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 134 | public static function parse($content, Document $document = null, &$position = 0) |
||
| 135 | { |
||
| 136 | $args = func_get_args(); |
||
| 137 | $only_values = isset($args[3]) ? $args[3] : false; |
||
| 138 | $content = trim($content); |
||
| 139 | $values = array(); |
||
| 140 | |||
| 141 | do { |
||
| 142 | $old_position = $position; |
||
| 143 | |||
| 144 | if (!$only_values) { |
||
| 145 | if (!preg_match('/^\s*(?P<name>\/[A-Z0-9\._]+)(?P<value>.*)/si', substr($content, $position), $match)) { |
||
| 146 | break; |
||
| 147 | } else { |
||
| 148 | $name = ltrim($match['name'], '/'); |
||
| 149 | $value = $match['value']; |
||
| 150 | $position = strpos($content, $value, $position + strlen($match['name'])); |
||
| 151 | } |
||
| 152 | } else { |
||
| 153 | $name = count($values); |
||
| 154 | $value = substr($content, $position); |
||
| 155 | } |
||
| 156 | |||
| 157 | if ($element = ElementName::parse($value, $document, $position)) { |
||
| 158 | $values[$name] = $element; |
||
| 159 | } elseif ($element = ElementXRef::parse($value, $document, $position)) { |
||
| 160 | $values[$name] = $element; |
||
| 161 | } elseif ($element = ElementNumeric::parse($value, $document, $position)) { |
||
| 162 | $values[$name] = $element; |
||
| 163 | } elseif ($element = ElementStruct::parse($value, $document, $position)) { |
||
| 164 | $values[$name] = $element; |
||
| 165 | } elseif ($element = ElementBoolean::parse($value, $document, $position)) { |
||
| 166 | $values[$name] = $element; |
||
| 167 | } elseif ($element = ElementNull::parse($value, $document, $position)) { |
||
| 168 | $values[$name] = $element; |
||
| 169 | } elseif ($element = ElementDate::parse($value, $document, $position)) { |
||
| 170 | $values[$name] = $element; |
||
| 171 | } elseif ($element = ElementString::parse($value, $document, $position)) { |
||
| 172 | $values[$name] = $element; |
||
| 173 | } elseif ($element = ElementHexa::parse($value, $document, $position)) { |
||
| 174 | $values[$name] = $element; |
||
| 175 | } elseif ($element = ElementArray::parse($value, $document, $position)) { |
||
| 176 | $values[$name] = $element; |
||
| 177 | } else { |
||
| 178 | $position = $old_position; |
||
| 179 | break; |
||
| 180 | } |
||
| 181 | } while ($position < strlen($content)); |
||
| 182 | |||
| 183 | return $values; |
||
| 184 | } |
||
| 186 |