Conditions | 1 |
Paths | 1 |
Total Lines | 91 |
Code Lines | 68 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
40 | public function testParse() |
||
41 | { |
||
42 | // Skipped. |
||
43 | $offset = 0; |
||
44 | $element = ElementString::parse('ABC', null, $offset); |
||
45 | $this->assertFalse($element); |
||
46 | $this->assertEquals(0, $offset); |
||
47 | |||
48 | $offset = 0; |
||
49 | $element = ElementString::parse(' [ (ABC) 5 6 ]', null, $offset); |
||
50 | $this->assertFalse($element); |
||
51 | $this->assertEquals(0, $offset); |
||
52 | |||
53 | $offset = 0; |
||
54 | $element = ElementString::parse(' << (invalid) >>', null, $offset); |
||
55 | $this->assertFalse($element); |
||
56 | $this->assertEquals(0, $offset); |
||
57 | |||
58 | $offset = 0; |
||
59 | $element = ElementString::parse(' / (FlateDecode) ', null, $offset); |
||
60 | $this->assertFalse($element); |
||
61 | $this->assertEquals(0, $offset); |
||
62 | |||
63 | $offset = 0; |
||
64 | $element = ElementString::parse(' 0 (FlateDecode) ', null, $offset); |
||
65 | $this->assertFalse($element); |
||
66 | $this->assertEquals(0, $offset); |
||
67 | |||
68 | $offset = 0; |
||
69 | $element = ElementString::parse(" 0 \n (FlateDecode) ", null, $offset); |
||
70 | $this->assertFalse($element); |
||
71 | $this->assertEquals(0, $offset); |
||
72 | |||
73 | // Valid. |
||
74 | $offset = 0; |
||
75 | $element = ElementString::parse(' (Copyright) ', null, $offset); |
||
76 | $this->assertEquals('Copyright', $element->getContent()); |
||
77 | $this->assertEquals(12, $offset); |
||
78 | |||
79 | $offset = 0; |
||
80 | $element = ElementString::parse(' (Copyright) ', null, $offset); |
||
81 | $this->assertEquals('Copyright', $element->getContent()); |
||
82 | $this->assertEquals(12, $offset); |
||
83 | |||
84 | $offset = 0; |
||
85 | $element = ElementString::parse(' (Copyright)', null, $offset); |
||
86 | $this->assertEquals('Copyright', $element->getContent()); |
||
87 | $this->assertEquals(12, $offset); |
||
88 | |||
89 | $offset = 0; |
||
90 | $element = ElementString::parse('(Copyright)', null, $offset); |
||
91 | $this->assertEquals('Copyright', $element->getContent()); |
||
92 | $this->assertEquals(11, $offset); |
||
93 | |||
94 | $offset = 0; |
||
95 | $element = ElementString::parse('(Copy-right2)', null, $offset); |
||
96 | $this->assertEquals('Copy-right2', $element->getContent()); |
||
97 | $this->assertEquals(13, $offset); |
||
98 | |||
99 | $offset = 0; |
||
100 | $element = ElementString::parse(" \n (Copyright) ", null, $offset); |
||
101 | $this->assertEquals('Copyright', $element->getContent()); |
||
102 | $this->assertEquals(14, $offset); |
||
103 | |||
104 | $offset = 0; |
||
105 | $element = ElementString::parse('()', null, $offset); |
||
106 | $this->assertEquals('', $element->getContent()); |
||
107 | $this->assertEquals(2, $offset); |
||
108 | |||
109 | /* |
||
110 | * Complex study case : Unicode + octal. |
||
111 | */ |
||
112 | $offset = 0; |
||
113 | $element = ElementString::parse('(ABC\\))', null, $offset); |
||
114 | $this->assertEquals('ABC)', $element->getContent()); |
||
115 | $this->assertEquals(7, $offset); |
||
116 | |||
117 | $offset = 0; |
||
118 | $element = ElementString::parse("(\xFE\xFF\\000M)", null, $offset); |
||
119 | $this->assertEquals('M', $element->getContent()); |
||
120 | $this->assertEquals(9, $offset); |
||
121 | |||
122 | $offset = 0; |
||
123 | $element = ElementString::parse('(<20>)', null, $offset); |
||
124 | $this->assertEquals(' ', $element->getContent()); |
||
125 | $this->assertEquals(6, $offset); |
||
126 | |||
127 | $offset = 0; |
||
128 | $element = ElementString::parse('(Gutter\\ console\\ assembly)', null, $offset); |
||
129 | $this->assertEquals('Gutter console assembly', $element->getContent()); |
||
130 | $this->assertEquals(27, $offset); |
||
131 | } |
||
171 |