smalot /
pdfparser
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 75 |
| Code Lines | 58 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function testParse() |
||
| 43 | { |
||
| 44 | // Skipped. |
||
| 45 | $offset = 0; |
||
| 46 | $element = ElementHexa::parse('ABC', null, $offset); |
||
| 47 | $this->assertFalse($element); |
||
|
Bug
introduced
by
|
|||
| 48 | $this->assertEquals(0, $offset); |
||
| 49 | |||
| 50 | $offset = 0; |
||
| 51 | $element = ElementHexa::parse(' [ <0020> 5 6 ]', null, $offset); |
||
| 52 | $this->assertFalse($element); |
||
| 53 | $this->assertEquals(0, $offset); |
||
| 54 | |||
| 55 | $offset = 0; |
||
| 56 | $element = ElementHexa::parse(' << <0020> >>', null, $offset); |
||
| 57 | $this->assertFalse($element); |
||
| 58 | $this->assertEquals(0, $offset); |
||
| 59 | |||
| 60 | $offset = 0; |
||
| 61 | $element = ElementHexa::parse(' / <0020> ', null, $offset); |
||
| 62 | $this->assertFalse($element); |
||
| 63 | $this->assertEquals(0, $offset); |
||
| 64 | |||
| 65 | $offset = 0; |
||
| 66 | $element = ElementHexa::parse(' 0 <0020> ', null, $offset); |
||
| 67 | $this->assertFalse($element); |
||
| 68 | $this->assertEquals(0, $offset); |
||
| 69 | |||
| 70 | $offset = 0; |
||
| 71 | $element = ElementHexa::parse(" 0 \n <0020> ", null, $offset); |
||
| 72 | $this->assertFalse($element); |
||
| 73 | $this->assertEquals(0, $offset); |
||
| 74 | |||
| 75 | // Valid. |
||
| 76 | $offset = 0; |
||
| 77 | $element = ElementHexa::parse(' <0020> ', null, $offset); |
||
| 78 | $this->assertEquals(' ', $element->getContent()); |
||
| 79 | $this->assertEquals(7, $offset); |
||
| 80 | |||
| 81 | $offset = 0; |
||
| 82 | $element = ElementHexa::parse(' <0020> ', null, $offset); |
||
| 83 | $this->assertEquals(' ', $element->getContent()); |
||
| 84 | $this->assertEquals(7, $offset); |
||
| 85 | |||
| 86 | $offset = 0; |
||
| 87 | $element = ElementHexa::parse(' <0020>', null, $offset); |
||
| 88 | $this->assertEquals(' ', $element->getContent()); |
||
| 89 | $this->assertEquals(7, $offset); |
||
| 90 | |||
| 91 | $offset = 0; |
||
| 92 | $element = ElementHexa::parse('<0020>', null, $offset); |
||
| 93 | $this->assertEquals(' ', $element->getContent()); |
||
| 94 | $this->assertEquals(6, $offset); |
||
| 95 | |||
| 96 | $offset = 0; |
||
| 97 | $element = ElementHexa::parse(" \n <0020> ", null, $offset); |
||
| 98 | $this->assertEquals(' ', $element->getContent()); |
||
| 99 | $this->assertEquals(9, $offset); |
||
| 100 | |||
| 101 | $offset = 0; |
||
| 102 | $element = ElementHexa::parse(" \n <5465616d204d616e6167656d656e742053797374656d73> ", null, $offset); |
||
| 103 | $this->assertEquals('Team Management Systems', $element->getContent()); |
||
| 104 | $this->assertEquals(51, $offset); |
||
| 105 | |||
| 106 | $offset = 0; |
||
| 107 | $element = ElementHexa::parse(" \n <5265706f72744275696c646572> ", null, $offset); |
||
| 108 | $this->assertTrue($element instanceof ElementString); |
||
| 109 | $this->assertEquals('ReportBuilder', $element->getContent()); |
||
| 110 | $this->assertEquals(31, $offset); |
||
| 111 | |||
| 112 | $offset = 0; |
||
| 113 | $element = ElementHexa::parse(" \n <443a3230313331323137313334303435303027303027> ", null, $offset); |
||
| 114 | $this->assertTrue($element instanceof ElementDate); |
||
| 115 | $this->assertEquals('2013-12-17T13:40:45+00:00', (string) $element); |
||
| 116 | $this->assertEquals(49, $offset); |
||
| 117 | } |
||
| 119 |
Loading history...