ParserTest::testIssue19() - Code Metrics - Inspection of "allow for line breaks when splitting xrefs for id..." - smalot/pdfparser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#345)

unknown

created 2020-09-29 16:19 UTC

ParserTest::testIssue19() A

↳ Parent: ParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	30
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
cc	1
eloc	14
c	3
b	1
f	1
nc	1
nop	0
dl	0
loc	30
rs	9.7998

<?php

/**
 * @file This file is part of the PdfParser library.
 *
 * @author  Konrad Abicht <[email protected]>
 * @date    2020-06-01
 *
 * @author  Sébastien MALOT <[email protected]>
 * @date    2017-01-03
 *
 * @license LGPLv3
 * @url     <https://github.com/smalot/pdfparser>
 *
 *  PdfParser is a pdf library written in PHP, extraction oriented.
 *  Copyright (C) 2017 - Sébastien MALOT <[email protected]>
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Lesser General Public License as published by
 *  the Free Software Foundation, either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Lesser General Public License for more details.
 *
 *  You should have received a copy of the GNU Lesser General Public License
 *  along with this program.
 *  If not, see <http://www.pdfparser.org/sites/default/LICENSE.txt>.
 */

namespace Tests\Smalot\PdfParser\Integration;

use Exception;
use Smalot\PdfParser\Parser;
use Smalot\PdfParser\Document;
use Smalot\PdfParser\XObject\Image;
use Tests\Smalot\PdfParser\TestCase;

class ParserTest extends TestCase
{
    public function setUp()
    {
        parent::setUp();

        $this->fixture = new Parser();
    }

    public function testParseFile()
    {
        $directory = $this->rootDir.'/samples/bugs';

        if (is_dir($directory)) {
            $files = scandir($directory);

            foreach ($files as $file) {
                if (preg_match('/^.*\.pdf$/i', $file)) {
                    try {
                        $document = $this->fixture->parseFile($directory.'/'.$file);
                        $pages = $document->getPages();
                        $this->assertTrue(0 < \count($pages));

                        foreach ($pages as $page) {
                            $content = $page->getText();
                            $this->assertTrue(0 < \strlen($content));
                        }
                    } catch (Exception $e) {
                        if (
                            'Secured pdf file are currently not supported.' !== $e->getMessage()
                            && 0 != strpos($e->getMessage(), 'TCPDF_PARSER')
                        ) {
                            throw $e;
                        }
                    }
                }
            }
        }
    }

    public function testIssue19()
    {
        $fixture = new ParserSub();

        $structure = [

            [
                '<<',
                [
                    [
                        '/',
                        'Type',
                        7735,
                    ],
                    [
                        '/',
                        'ObjStm',
                        7742,
                    ]
                ]
            ],
            [
                'stream',
                '',
                7804,
                [
                    "17\n0",
                    []
                ]
            ]
        ];
        $document = new Document();


    }

    /**
     * Test that issue related pdf can now be parsed
     *
     * @see https://github.com/smalot/pdfparser/issues/267
     */
    public function testIssue267()
    {
        $filename = $this->rootDir.'/samples/bugs/Issue267_array_access_on_int.pdf';

        $document = $this->fixture->parseFile($filename);

        $this->assertEquals(Image::class, \get_class($document->getObjectById('128_0')));
        $this->assertStringContainsString('4 von 4', $document->getText());
    }
}

class ParserSub extends Parser {
    public function exposedParseObject($id, $structure, $document) {
        return $this->parseObject($id, $structure, $document);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			/**
4			* @file This file is part of the PdfParser library.
5			*
6			* @author Konrad Abicht <[email protected]>
7			* @date 2020-06-01
8			*
9			* @author Sébastien MALOT <[email protected]>
10			* @date 2017-01-03
11			*
12			* @license LGPLv3
13			* @url <https://github.com/smalot/pdfparser>
14			*
15			* PdfParser is a pdf library written in PHP, extraction oriented.
16			* Copyright (C) 2017 - Sébastien MALOT <[email protected]>
17			*
18			* This program is free software: you can redistribute it and/or modify
19			* it under the terms of the GNU Lesser General Public License as published by
20			* the Free Software Foundation, either version 3 of the License, or
21			* (at your option) any later version.
22			*
23			* This program is distributed in the hope that it will be useful,
24			* but WITHOUT ANY WARRANTY; without even the implied warranty of
25			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
26			* GNU Lesser General Public License for more details.
27			*
28			* You should have received a copy of the GNU Lesser General Public License
29			* along with this program.
30			* If not, see <http://www.pdfparser.org/sites/default/LICENSE.txt>.
31			*/
32
33			namespace Tests\Smalot\PdfParser\Integration;
34
35			use Exception;
36			use Smalot\PdfParser\Parser;
37			use Smalot\PdfParser\Document;
38			use Smalot\PdfParser\XObject\Image;
39			use Tests\Smalot\PdfParser\TestCase;
40
41			class ParserTest extends TestCase
42			{
43			public function setUp()
44			{
45			parent::setUp();
46
47			$this->fixture = new Parser();
48			}
49
50			public function testParseFile()
51			{
52			$directory = $this->rootDir.'/samples/bugs';
53
54			if (is_dir($directory)) {
55			$files = scandir($directory);
56
57			foreach ($files as $file) {
58			if (preg_match('/^.*\.pdf$/i', $file)) {
59			try {
60			$document = $this->fixture->parseFile($directory.'/'.$file);
61			$pages = $document->getPages();
62			$this->assertTrue(0 < \count($pages));
63
64			foreach ($pages as $page) {
65			$content = $page->getText();
66			$this->assertTrue(0 < \strlen($content));
67			}
68			} catch (Exception $e) {
69			if (
70			'Secured pdf file are currently not supported.' !== $e->getMessage()
71			&& 0 != strpos($e->getMessage(), 'TCPDF_PARSER')
72			) {
73			throw $e;
74			}
75			}
76			}
77			}
78			}
79			}
80
81			public function testIssue19()
82			{
83			$fixture = new ParserSub();
			0 ignored issues – show Unused Code introduced 2020-09-29 16:21 UTC by Report Bug Copy Issue Report The assignment to `$fixture` is dead and can be removed. Loading history...
84			$structure = [
			0 ignored issues – show Unused Code introduced 2020-09-29 16:21 UTC by Report Bug Copy Issue Report The assignment to `$structure` is dead and can be removed. Loading history...
85			[
86			'<<',
87			[
88			[
89			'/',
90			'Type',
91			7735,
92			],
93			[
94			'/',
95			'ObjStm',
96			7742,
97			]
98			]
99			],
100			[
101			'stream',
102			'',
103			7804,
104			[
105			"17\n0",
106			[]
107			]
108			]
109			];
110			$document = new Document();
			0 ignored issues – show Unused Code introduced 2020-09-29 16:21 UTC by Report Bug Copy Issue Report The assignment to `$document` is dead and can be removed. Loading history...
111
112			}
113
114			/**
115			* Test that issue related pdf can now be parsed
116			*
117			* @see https://github.com/smalot/pdfparser/issues/267
118			*/
119			public function testIssue267()
120			{
121			$filename = $this->rootDir.'/samples/bugs/Issue267_array_access_on_int.pdf';
122
123			$document = $this->fixture->parseFile($filename);
124
125			$this->assertEquals(Image::class, \get_class($document->getObjectById('128_0')));
126			$this->assertStringContainsString('4 von 4', $document->getText());
127			}
128			}
129
130			class ParserSub extends Parser {
131			public function exposedParseObject($id, $structure, $document) {
132			return $this->parseObject($id, $structure, $document);
			0 ignored issues – show Bug introduced 2020-09-29 13:49 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->parseObject($id, $structure, $document)` targeting `Smalot\PdfParser\Parser::parseObject()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
133			}
134			}
135

smalot / pdfparser

Pull Request — master (#345)

ParserTest::testIssue19() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like