| Conditions | 1 |
| Paths | 1 |
| Total Lines | 91 |
| Code Lines | 68 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 43 | public function testParse(): void |
||
| 44 | { |
||
| 45 | // Skipped. |
||
| 46 | $offset = 0; |
||
| 47 | $element = ElementString::parse('ABC', null, $offset); |
||
| 48 | $this->assertFalse($element); |
||
| 49 | $this->assertEquals(0, $offset); |
||
| 50 | |||
| 51 | $offset = 0; |
||
| 52 | $element = ElementString::parse(' [ (ABC) 5 6 ]', null, $offset); |
||
| 53 | $this->assertFalse($element); |
||
| 54 | $this->assertEquals(0, $offset); |
||
| 55 | |||
| 56 | $offset = 0; |
||
| 57 | $element = ElementString::parse(' << (invalid) >>', null, $offset); |
||
| 58 | $this->assertFalse($element); |
||
| 59 | $this->assertEquals(0, $offset); |
||
| 60 | |||
| 61 | $offset = 0; |
||
| 62 | $element = ElementString::parse(' / (FlateDecode) ', null, $offset); |
||
| 63 | $this->assertFalse($element); |
||
| 64 | $this->assertEquals(0, $offset); |
||
| 65 | |||
| 66 | $offset = 0; |
||
| 67 | $element = ElementString::parse(' 0 (FlateDecode) ', null, $offset); |
||
| 68 | $this->assertFalse($element); |
||
| 69 | $this->assertEquals(0, $offset); |
||
| 70 | |||
| 71 | $offset = 0; |
||
| 72 | $element = ElementString::parse(" 0 \n (FlateDecode) ", null, $offset); |
||
| 73 | $this->assertFalse($element); |
||
| 74 | $this->assertEquals(0, $offset); |
||
| 75 | |||
| 76 | // Valid. |
||
| 77 | $offset = 0; |
||
| 78 | $element = ElementString::parse(' (Copyright) ', null, $offset); |
||
| 79 | $this->assertEquals('Copyright', $element->getContent()); |
||
| 80 | $this->assertEquals(12, $offset); |
||
| 81 | |||
| 82 | $offset = 0; |
||
| 83 | $element = ElementString::parse(' (Copyright) ', null, $offset); |
||
| 84 | $this->assertEquals('Copyright', $element->getContent()); |
||
| 85 | $this->assertEquals(12, $offset); |
||
| 86 | |||
| 87 | $offset = 0; |
||
| 88 | $element = ElementString::parse(' (Copyright)', null, $offset); |
||
| 89 | $this->assertEquals('Copyright', $element->getContent()); |
||
| 90 | $this->assertEquals(12, $offset); |
||
| 91 | |||
| 92 | $offset = 0; |
||
| 93 | $element = ElementString::parse('(Copyright)', null, $offset); |
||
| 94 | $this->assertEquals('Copyright', $element->getContent()); |
||
| 95 | $this->assertEquals(11, $offset); |
||
| 96 | |||
| 97 | $offset = 0; |
||
| 98 | $element = ElementString::parse('(Copy-right2)', null, $offset); |
||
| 99 | $this->assertEquals('Copy-right2', $element->getContent()); |
||
| 100 | $this->assertEquals(13, $offset); |
||
| 101 | |||
| 102 | $offset = 0; |
||
| 103 | $element = ElementString::parse(" \n (Copyright) ", null, $offset); |
||
| 104 | $this->assertEquals('Copyright', $element->getContent()); |
||
| 105 | $this->assertEquals(14, $offset); |
||
| 106 | |||
| 107 | $offset = 0; |
||
| 108 | $element = ElementString::parse('()', null, $offset); |
||
| 109 | $this->assertEquals('', $element->getContent()); |
||
| 110 | $this->assertEquals(2, $offset); |
||
| 111 | |||
| 112 | /* |
||
| 113 | * Complex study case : Unicode + octal. |
||
| 114 | */ |
||
| 115 | $offset = 0; |
||
| 116 | $element = ElementString::parse('(ABC\\))', null, $offset); |
||
| 117 | $this->assertEquals('ABC)', $element->getContent()); |
||
| 118 | $this->assertEquals(7, $offset); |
||
| 119 | |||
| 120 | $offset = 0; |
||
| 121 | $element = ElementString::parse("(\xFE\xFF\\000M)", null, $offset); |
||
| 122 | $this->assertEquals('M', $element->getContent()); |
||
| 123 | $this->assertEquals(9, $offset); |
||
| 124 | |||
| 125 | $offset = 0; |
||
| 126 | $element = ElementString::parse('(<20>)', null, $offset); |
||
| 127 | $this->assertEquals(' ', $element->getContent()); |
||
| 128 | $this->assertEquals(6, $offset); |
||
| 129 | |||
| 130 | $offset = 0; |
||
| 131 | $element = ElementString::parse('(Gutter\\ console\\ assembly)', null, $offset); |
||
| 132 | $this->assertEquals('Gutter console assembly', $element->getContent()); |
||
| 133 | $this->assertEquals(27, $offset); |
||
| 134 | } |
||
| 174 |