| Conditions | 1 |
| Paths | 1 |
| Total Lines | 58 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 43 | public function testParse(): void |
||
| 44 | { |
||
| 45 | // Skipped. |
||
| 46 | $offset = 0; |
||
| 47 | $element = ElementNumeric::parse('ABC', null, $offset); |
||
| 48 | $this->assertFalse($element); |
||
| 49 | $this->assertEquals(0, $offset); |
||
| 50 | |||
| 51 | $offset = 0; |
||
| 52 | $element = ElementNumeric::parse(' [ 2 ]', null, $offset); |
||
| 53 | $this->assertFalse($element); |
||
| 54 | $this->assertEquals(0, $offset); |
||
| 55 | |||
| 56 | $offset = 0; |
||
| 57 | $element = ElementNumeric::parse(' /2', null, $offset); |
||
| 58 | $this->assertFalse($element); |
||
| 59 | $this->assertEquals(0, $offset); |
||
| 60 | |||
| 61 | $offset = 0; |
||
| 62 | $element = ElementNumeric::parse(" /2 \n 2", null, $offset); |
||
| 63 | $this->assertFalse($element); |
||
| 64 | $this->assertEquals(0, $offset); |
||
| 65 | |||
| 66 | // Valid. |
||
| 67 | $offset = 0; |
||
| 68 | $element = ElementNumeric::parse(' -2', null, $offset); |
||
| 69 | $this->assertEquals(-2.0, $element->getContent()); |
||
| 70 | $this->assertEquals(3, $offset); |
||
| 71 | |||
| 72 | $offset = 0; |
||
| 73 | $element = ElementNumeric::parse('2BC', null, $offset); |
||
| 74 | $this->assertEquals(2.0, $element->getContent()); |
||
| 75 | $this->assertEquals(1, $offset); |
||
| 76 | |||
| 77 | $offset = 0; |
||
| 78 | $element = ElementNumeric::parse(' 2BC', null, $offset); |
||
| 79 | $this->assertEquals(2.0, $element->getContent()); |
||
| 80 | $this->assertEquals(2, $offset); |
||
| 81 | |||
| 82 | $offset = 0; |
||
| 83 | $element = ElementNumeric::parse(' -2BC', null, $offset); |
||
| 84 | $this->assertEquals(-2.0, $element->getContent()); |
||
| 85 | $this->assertEquals(3, $offset); |
||
| 86 | |||
| 87 | $offset = 0; |
||
| 88 | $element = ElementNumeric::parse(' -2', null, $offset); |
||
| 89 | $this->assertEquals(-2.0, $element->getContent()); |
||
| 90 | $this->assertEquals(3, $offset); |
||
| 91 | |||
| 92 | $offset = 0; |
||
| 93 | $element = ElementNumeric::parse(' 2 0 obj', null, $offset); |
||
| 94 | $this->assertEquals(2.0, $element->getContent()); |
||
| 95 | $this->assertEquals(2, $offset); |
||
| 96 | |||
| 97 | $offset = 0; |
||
| 98 | $element = ElementNumeric::parse(" \n -2 ", null, $offset); |
||
| 99 | $this->assertEquals(-2.0, $element->getContent()); |
||
| 100 | $this->assertEquals(5, $offset); |
||
| 101 | } |
||
| 200 |