Smalot\PdfParser\Parser::parseHeaderElement()

Complexity

Conditions	18
Paths	17

Size

Total Lines	54
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	32
CRAP Score	18.2039

Importance

Changes	3
Bugs	1	Features	0

<?php
    protected function parseHeaderElement($type, $value, $document)
    {
        switch ($type) {
            case '<<':
            case '>>':
                return $this->parseHeader($value, $document);

It seems like $value can also be of type string; however, parameter $structure of Smalot\PdfParser\Parser::parseHeader() does only seem to accept array, maybe add an additional type check?

            case 'numeric':
                return new ElementNumeric($value);

It seems like $value can also be of type array; however, parameter $value of Smalot\PdfParser\Element\ElementNumeric::__construct() does only seem to accept string, maybe add an additional type check?

            case 'boolean':
                return new ElementBoolean($value);

It seems like $value can also be of type array; however, parameter $value of Smalot\PdfParser\Element\ElementBoolean::__construct() does only seem to accept boolean|string, maybe add an additional type check?

            case 'null':
                return new ElementNull();

            case '(':
                if ($date = ElementDate::parse('('.$value.')', $document)) {

Are you sure $value of type array|string can be used in concatenation?

                    return $date;
                }

                return ElementString::parse('('.$value.')', $document);

The expression return Smalot\PdfParser\Element\ElementString::parse('(' . $value . ')', $document) could also return false which is incompatible with the documented return type Smalot\PdfParser\Element|Smalot\PdfParser\Header|null. Did you maybe forget to handle an error condition?

            case '<':
                return $this->parseHeaderElement('(', ElementHexa::decode($value, $document), $document);

It seems like $value can also be of type array; however, parameter $value of Smalot\PdfParser\Element\ElementHexa::decode() does only seem to accept string, maybe add an additional type check?

            case '/':
                return ElementName::parse('/'.$value, $document);

The expression return Smalot\PdfParser\Element\ElementName::parse('/' . $value, $document) could also return false which is incompatible with the documented return type Smalot\PdfParser\Element|Smalot\PdfParser\Header|null. Did you maybe forget to handle an error condition?

            case 'ojbref': // old mistake in tcpdf parser
            case 'objref':
                return new ElementXRef($value, $document);

            case '[':
                $values = [];

                if (\is_array($value)) {
                    foreach ($value as $sub_element) {
                        $sub_type = $sub_element[0];
                        $sub_value = $sub_element[1];
                        $values[] = $this->parseHeaderElement($sub_type, $sub_value, $document);
                    }
                }

                return new ElementArray($values, $document);

$values of type Smalot\PdfParser\Header[]|array is incompatible with the type string expected by parameter $value of Smalot\PdfParser\Element\ElementArray::__construct().

            case 'endstream':
            case 'obj': //I don't know what it means but got my project fixed.
            case '':
                // Nothing to do with.
                return null;

            default:
                throw new \Exception('Invalid type: "'.$type.'".');
        }