Conditions | 1 |
Paths | 1 |
Total Lines | 63 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
43 | public function testParse(): void |
||
44 | { |
||
45 | // Skipped. |
||
46 | $offset = 0; |
||
47 | $element = ElementBoolean::parse('ABC', null, $offset); |
||
48 | $this->assertFalse($element); |
||
49 | $this->assertEquals(0, $offset); |
||
50 | |||
51 | $offset = 0; |
||
52 | $element = ElementBoolean::parse(' [ false ]', null, $offset); |
||
53 | $this->assertFalse($element); |
||
54 | $this->assertEquals(0, $offset); |
||
55 | |||
56 | $offset = 0; |
||
57 | $element = ElementBoolean::parse(' << true >>', null, $offset); |
||
58 | $this->assertFalse($element); |
||
59 | $this->assertEquals(0, $offset); |
||
60 | |||
61 | $offset = 0; |
||
62 | $element = ElementBoolean::parse(' / false ', null, $offset); |
||
63 | $this->assertFalse($element); |
||
64 | $this->assertEquals(0, $offset); |
||
65 | |||
66 | $offset = 0; |
||
67 | $element = ElementBoolean::parse(' 0 true ', null, $offset); |
||
68 | $this->assertFalse($element); |
||
69 | $this->assertEquals(0, $offset); |
||
70 | |||
71 | $offset = 0; |
||
72 | $element = ElementBoolean::parse(" 0 \n true ", null, $offset); |
||
73 | $this->assertFalse($element); |
||
74 | $this->assertEquals(0, $offset); |
||
75 | |||
76 | // Valid. |
||
77 | $offset = 0; |
||
78 | $element = ElementBoolean::parse(' true ', null, $offset); |
||
79 | $this->assertTrue($element->getContent()); |
||
80 | $this->assertEquals(5, $offset); |
||
81 | |||
82 | $offset = 0; |
||
83 | $element = ElementBoolean::parse(' TRUE ', null, $offset); |
||
84 | $this->assertTrue($element->getContent()); |
||
85 | $this->assertEquals(5, $offset); |
||
86 | |||
87 | $offset = 0; |
||
88 | $element = ElementBoolean::parse(' True', null, $offset); |
||
89 | $this->assertTrue($element->getContent()); |
||
90 | $this->assertEquals(5, $offset); |
||
91 | |||
92 | $offset = 0; |
||
93 | $element = ElementBoolean::parse('true', null, $offset); |
||
94 | $this->assertTrue($element->getContent()); |
||
95 | $this->assertEquals(4, $offset); |
||
96 | |||
97 | $offset = 0; |
||
98 | $element = ElementBoolean::parse('False', null, $offset); |
||
99 | $this->assertFalse($element->getContent()); |
||
100 | $this->assertEquals(5, $offset); |
||
101 | |||
102 | $offset = 0; |
||
103 | $element = ElementBoolean::parse(" \n true ", null, $offset); |
||
104 | $this->assertTrue($element->getContent()); |
||
105 | $this->assertEquals(7, $offset); |
||
106 | } |
||
149 |