Cerbere\Parser\Yaml

Complexity

Total Complexity

11

Size/Duplication

Total Lines	104
Duplicated Lines	13.46 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getCode()	0	4	1
A	getProjects()	0	4	1
A	getProject()	0	4	1
A	processContent()	14	14	2
A	parseContent()	0	12	2
A	getRequiredKeys()	0	4	1
A	processFile()	0	6	1
A	supportedFile()	0	5	1

<?php

/**
 * Drush Cerbere command line tools.
 * Copyright (C) 2015 - Sebastien Malot <sebastien@malot.fr>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

namespace Cerbere\Parser;

use Cerbere\Model\Project;
use Symfony\Component\Yaml\Exception\ParseException;

/**
 * Class Yaml
 * @package Cerbere\Parser
 */
class Yaml extends Ini
{
    /**
     * @var Project
     */
    protected $project;

    /**
     *
     */
    public function __construct()
    {

    }

    /**
     * @return string
     */
    public function getCode()
    {
        return 'yaml';
    }

    /**
     * @return Project[]
     */
    public function getProjects()
    {
        return array($this->getProject());
    }

    /**
     * @return Project
     */
    public function getProject()
    {
        return $this->project;
    }

    /**
     * @param string $content
     * @param string $filename
     */
    public function processContent($content, $filename = null)

This method seems to be duplicated in your project.

    {
        $data = $this->parseContent($content);
        $data += array('project' => basename($filename, '.info.yml'), 'version' => '');

        $project = new Project($data['project'], $data['core'], $data['version']);
        $project->setDetails($data);

        if (!empty($filename)) {
            $project->setFilename(realpath($filename));
        }

        $this->project = $project;
    }

    /**
     * @param string $content
     * @return array
     * @throws ParseException
     */
    protected function parseContent($content)
    {
        $parsed_info = \Symfony\Component\Yaml\Yaml::parse($content);

The expression \Symfony\Component\Yaml\Yaml::parse($content); of type array|string adds the type string to the return on line 104 which is incompatible with the return type of the parent method Cerbere\Parser\Ini::parseContent of type array.

        $missing_keys = array_diff($this->getRequiredKeys(), array_keys($parsed_info));

        if (!empty($missing_keys)) {
            throw new ParseException('Missing required keys (' . implode(', ', $missing_keys) . ')');
        }

        return $parsed_info;
    }

    /**
     * @return array
     */
    protected function getRequiredKeys()
    {
        return array('type', 'core', 'name');
    }

    /**
     * @param string $filename
     */
    public function processFile($filename)
    {
        $content = file_get_contents($filename);

        $this->processContent($content, $filename);
    }

    /**
     * @parser string $filename
     * @return integer
     */
    public function supportedFile($filename)
    {
var_dump($filename);

var_dump($filename); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        return preg_match('/\.info\.yml$/i', $filename) > 0;
    }
}