Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
32 | class CerbereConsoleListener implements EventSubscriberInterface |
||
33 | { |
||
34 | /** |
||
35 | * @var OutputInterface |
||
36 | */ |
||
37 | protected $output; |
||
38 | |||
39 | /** |
||
40 | * CerbereConsoleListener constructor. |
||
41 | * @param OutputInterface|null $output |
||
42 | */ |
||
43 | View Code Duplication | public function __construct(OutputInterface $output = null) |
|
51 | |||
52 | /** |
||
53 | * @return OutputInterface |
||
54 | */ |
||
55 | public function getOutput() |
||
59 | |||
60 | /** |
||
61 | * @param OutputInterface $output |
||
62 | */ |
||
63 | public function setOutput($output) |
||
67 | |||
68 | /** |
||
69 | * Returns an array of event names this subscriber wants to listen to. |
||
70 | * |
||
71 | * The array keys are event names and the value can be: |
||
72 | * |
||
73 | * * The method name to call (priority defaults to 0) |
||
74 | * * An array composed of the method name to call and the priority |
||
75 | * * An array of arrays composed of the method names to call and respective |
||
76 | * priorities, or 0 if unset |
||
77 | * |
||
78 | * For instance: |
||
79 | * |
||
80 | * * array('eventName' => 'methodName') |
||
81 | * * array('eventName' => array('methodName', $priority)) |
||
82 | * * array('eventName' => array(array('methodName1', $priority), array('methodName2')) |
||
83 | * |
||
84 | * @return array The event names to listen to |
||
85 | */ |
||
86 | public static function getSubscribedEvents() |
||
92 | |||
93 | /** |
||
94 | * @param CerbereFileDiscoverEvent $event |
||
95 | */ |
||
96 | public function onCerbereFileDiscovered(CerbereFileDiscoverEvent $event) |
||
100 | } |
||
101 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.