routes/reports.js - Code Metrics - slistrom/me-express-back - Measure and Improve Code Quality continuously with Scrutinizer

routes/reports.js A
last analyzed 2020-10-09 08:46 UTC

↳ Parent: Project

Complexity

Total Complexity	9
Complexity/F	1.5

Size

Lines of Code	55
Function Count	6

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
wmc	9
eloc	32
mnd	3
bc	3
fnc	6
dl	0
loc	55
rs	10
bpm	0.5
cpm	1.5
noi	4
c	0
b	0
f	0

2 Functions

Rating	Name	Duplication	Size	Complexity
B	reports.js ➔ checkToken	0	15	6
A	reports.js ➔ reportedit	0	16	3

var express = require('express');
var router = express.Router();
const sqlite3 = require('sqlite3').verbose();

// const db = new sqlite3.Database('./db/texts.sqlite');
const db = require("../db/database.js");
const jwt = require('jsonwebtoken');

let config;

try {
    config = require('../config.js');
} catch (error) {
    console.error(error);
}

const jwtSecret = process.env.JWT_SECRET || config.secret;

router.post("/",
    (req, res, next) => checkToken(req, res, next),
    (req, res) => reportedit(res, req.body));

function checkToken(req, res, next) {
    const token = req.headers['x-access-token'];

    jwt.verify(token, jwtSecret, function(err, decoded) {

        if (err) {
            return res.status(401).json({
                data: {
                    message: "No valid token."
                }
            });
        }
        // Valid token send on the request
        next();

    });
}

function reportedit(res, body) {
    const week = body.week;
    const text = body.text;

    db.run("UPDATE reports SET text = '" + text + "' WHERE week = " + week,
        (err) => {
            if (err) {

                // console.log(err);
            }
            return res.status(201).json({
                data: {
                    message: "Report successfully updated."
                }
            });
        });
}

module.exports = router;


1			var express = require('express');
2			var router = express.Router();
3			const sqlite3 = require('sqlite3').verbose();
			0 ignored issues – show Unused Code introduced 2020-09-28 10:17 UTC by Report Bug Copy Issue Report The constant `sqlite3` seems to be never used. Consider removing it. Loading history...
4			// const db = new sqlite3.Database('./db/texts.sqlite');
5			const db = require("../db/database.js");
6			const jwt = require('jsonwebtoken');
7
8			let config;
9
10			try {
11			config = require('../config.js');
12			} catch (error) {
13			console.error(error);
14			}
15
16			const jwtSecret = process.env.JWT_SECRET \|\| config.secret;
17
18			router.post("/",
19			(req, res, next) => checkToken(req, res, next),
20			(req, res) => reportedit(res, req.body));
21
22			function checkToken(req, res, next) {
23			const token = req.headers['x-access-token'];
24
25			jwt.verify(token, jwtSecret, function(err, decoded) {
			0 ignored issues – show Unused Code introduced 2020-09-28 10:17 UTC by Report Bug Copy Issue Report The parameter `decoded` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
26			if (err) {
27			return res.status(401).json({
28			data: {
29			message: "No valid token."
30			}
31			});
32			}
33			// Valid token send on the request
34			next();
			0 ignored issues – show Best Practice introduced 2020-09-28 10:17 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
35			});
36			}
37
38			function reportedit(res, body) {
39			const week = body.week;
40			const text = body.text;
41
42			db.run("UPDATE reports SET text = '" + text + "' WHERE week = " + week,
43			(err) => {
44			if (err) {
			0 ignored issues – show Comprehensibility Documentation Best Practice introduced 2020-09-28 10:17 UTC by Report Bug Copy Issue Report This code block is empty. Consider removing it or adding a comment to explain. Loading history...
45			// console.log(err);
46			}
47			return res.status(201).json({
48			data: {
49			message: "Report successfully updated."
50			}
51			});
52			});
53			}
54
55			module.exports = router;
56

slistrom / me-express-back

routes/reports.js A last analyzed 2020-10-09 08:46 UTC

Complexity

Size

Duplication

Importance

2 Functions

Duplication Side-by-Side

Filter issues like

routes/reports.js A
last analyzed 2020-10-09 08:46 UTC