Lii\Model\WeatherReport::getHistoricWeather()

Complexity

Conditions	5
Paths	8

Size

Total Lines	40
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getHistoricWeather($days, $lat, $long)
    {
        $url = 'https://api.openweathermap.org/data/2.5/onecall/timemachine?lat='.$lat.'&lon='.$long.'&units=metric&appid='.$this->accessKey.'&dt=';

        $options = [
            CURLOPT_RETURNTRANSFER => true,
        ];

        // Add all curl handlers and remember them
        // Initiate the multi curl handler
        $mh1 = curl_multi_init();
        $chAll = [];
        foreach ($days as $day) {
            $ch1 = curl_init("$url$day");
            curl_setopt_array($ch1, $options);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

            curl_multi_add_handle($mh1, $ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

            $chAll[] = $ch1;
        }

        // Execute all queries simultaneously,
        // and continue when all are complete
        $running = null;
        do {
            curl_multi_exec($mh1, $running);
        } while ($running);

        // Close the handles
        foreach ($chAll as $ch1) {
            curl_multi_remove_handle($mh1, $ch1);
        }
        curl_multi_close($mh1);

        // All of our requests are done, we can now access the results
        $response = [];
        foreach ($chAll as $ch1) {
            $data = curl_multi_getcontent($ch1);
            $response[] = json_decode($data, true);
        }

        return $response;
    }