Local::__construct() - Code Metrics - Inspection of "Add make directory logic" - slince/upload - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2022-12-08 01:02 UTC

Local::__construct() A

↳ Parent: Local

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	5
c	2
b	0
f	0
dl	0
loc	11
rs	10
cc	3
nc	3
nop	1

<?php

namespace Slince\Upload\Filesystem;

use \RuntimeException;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\HttpFoundation\File\UploadedFile;

class Local implements FilesystemInterface
{
    /**
     * @var string
     */
    protected $savePath;

    public function __construct(string $savePath)
    {
        if (!$this->ensureDirectory($savePath)) {
            throw new \InvalidArgumentException(sprintf('Directory "%s" was not created', $savePath));
        }

        if (!is_writable($savePath)) {
            throw new \InvalidArgumentException(sprintf('The directory "%s" is invalid', $savePath));
        }

        $this->savePath = rtrim($savePath, '\\/');
    }

    /**
     * {@inheritdoc}
     */
    public function upload(string $key, UploadedFile $file, bool $overwrite = false)
    {
        $filePath = $this->getFilePath($key);
        if (file_exists($filePath) && !$overwrite) {
            throw new RuntimeException(sprintf('The file with key "%s" is exists.', $key));
        }
        return $file->move(dirname($filePath), basename($filePath));
    }

    protected function getFilePath(string $key): string
    {
        return "{$this->savePath}/{$key}";
    }

    protected function ensureDirectory(string $directory): bool
    {
        return is_dir($directory) || mkdir($directory, 0755, true);
    }
}


1			<?php
2
3			namespace Slince\Upload\Filesystem;
4
5			use \RuntimeException;
			0 ignored issues – show Bug introduced 2022-11-29 00:43 UTC by Report Bug Copy Issue Report The type `\RuntimeException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use Symfony\Component\HttpFoundation\File\UploadedFile;
7
8			class Local implements FilesystemInterface
9			{
10			/**
11			* @var string
12			*/
13			protected $savePath;
14
15			public function __construct(string $savePath)
16			{
17			if (!$this->ensureDirectory($savePath)) {
18			throw new \InvalidArgumentException(sprintf('Directory "%s" was not created', $savePath));
19			}
20
21			if (!is_writable($savePath)) {
22			throw new \InvalidArgumentException(sprintf('The directory "%s" is invalid', $savePath));
23			}
24
25			$this->savePath = rtrim($savePath, '\\/');
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function upload(string $key, UploadedFile $file, bool $overwrite = false)
32			{
33			$filePath = $this->getFilePath($key);
34			if (file_exists($filePath) && !$overwrite) {
35			throw new RuntimeException(sprintf('The file with key "%s" is exists.', $key));
36			}
37			return $file->move(dirname($filePath), basename($filePath));
38			}
39
40			protected function getFilePath(string $key): string
41			{
42			return "{$this->savePath}/{$key}";
43			}
44
45			protected function ensureDirectory(string $directory): bool
46			{
47			return is_dir($directory) \|\| mkdir($directory, 0755, true);
48			}
49			}
50

slince / upload

Pull Request — master (#5)

Local::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like