Slince\Upload\Filesystem\Flysystem

Complexity

Total Complexity

7

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	5	1
A	upload()	0	14	3
A	uploadToFlysystem()	0	6	2
A	__construct()	0	3	1

<?php

namespace Slince\Upload\Filesystem;

use League\Flysystem\Filesystem;

The type League\Flysystem\Filesystem was not found. Maybe you did not declare it correctly or list all dependencies?

use League\Flysystem\FilesystemException;

The type League\Flysystem\FilesystemException was not found. Maybe you did not declare it correctly or list all dependencies?

use RuntimeException;
use Slince\Upload\File;
use Symfony\Component\HttpFoundation\File\UploadedFile;

class Flysystem implements FilesystemInterface
{
    /**
     * @var Filesystem
     */
    protected $filesystem;

    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * {@inheritdoc}
     */
    public function upload(string $key, UploadedFile $file, bool $overwrite = false)
    {
        try {
            $this->uploadToFlysystem($key, $file);
        } catch (RuntimeException $exception) {
            if (!$overwrite) {
                throw new RuntimeException(sprintf('The file with key "%s" is exists.', $key));
            }
            $this->filesystem->delete($key);
            $this->uploadToFlysystem($key, $file);
        }
        @unlink($file->getPathname()); //remove old

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function delete(File $file): bool
    {
        $this->filesystem->delete($file->getName());

        return true;
    }

    /**
     * @param string $key
     * @param UploadedFile $file
     * @throws RuntimeException
     */
    protected function uploadToFlysystem(string $key, UploadedFile $file): void
    {
        try {
            $this->filesystem->writeStream($key, fopen($file->getPathname(), 'r'));
        } catch (FilesystemException $exception) {
            throw new RuntimeException('Failed to upload to flysystem');
        }
    }
}