Fulfillment::getTrackingNumbers() - Code Metrics - Inspection of "replace symfony serializer" - slince/shopify-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8e28ab...2236d8 )

by Taosikai

created 2018-01-30 06:26 UTC

Fulfillment::getTrackingNumbers() A

↳ Parent: Fulfillment

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * This file is part of the slince/shopify-api-php
 *
 * (c) Taosikai <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Slince\Shopify\Manager\Fulfillment;

use Slince\Shopify\Common\Model\Model;
use Slince\Shopify\Hydrator\Association\HasMany;
use Slince\Shopify\Manager\Order\LineItem;

class Fulfillment extends Model
{
    /**
     * @var int
     */
    protected $orderId;

    /**
     * @var string
     */
    protected $status;

    /**
     * @var string
     */
    protected $createdAt;

    /**
     * @var string
     */
    protected $updatedAt;

    /**
     * @var string
     */
    protected $service;

    /**
     * @var string
     */
    protected $shipmentStatus;

    /**
     * @var string
     */
    protected $trackingCompany;

    /**
     * @var string
     */
    protected $trackingNumber;

    /**
     * @var array
     */
    protected $trackingNumbers;

    /**
     * @var string
     */
    protected $trackingUrl;

    /**
     * @var array
     */
    protected $trackingUrls;

    /**
     * @var array
     */
    protected $receipt;

    /**
     * @var LineItem[]
     */
    protected $lineItems;

    /**
     * @return string
     */
    public function getService()
    {
        return $this->service;
    }

    /**
     * @param string $service
     *
     * @return Fulfillment
     */
    public function setService($service)
    {
        $this->service = $service;

        return $this;
    }

    /**
     * @return string
     */
    public function getShipmentStatus()
    {
        return $this->shipmentStatus;
    }

    /**
     * @param string $shipmentStatus
     *
     * @return Fulfillment
     */
    public function setShipmentStatus($shipmentStatus)
    {
        $this->shipmentStatus = $shipmentStatus;

        return $this;
    }

    /**
     * @return string
     */
    public function getTrackingUrl()
    {
        return $this->trackingUrl;
    }

    /**
     * @param string $trackingUrl
     *
     * @return Fulfillment
     */
    public function setTrackingUrl($trackingUrl)
    {
        $this->trackingUrl = $trackingUrl;

        return $this;
    }

    /**
     * @return array
     */
    public function getTrackingUrls()
    {
        return $this->trackingUrls;
    }

    /**
     * @param array $trackingUrls
     *
     * @return Fulfillment
     */
    public function setTrackingUrls($trackingUrls)
    {
        $this->trackingUrls = $trackingUrls;

        return $this;
    }

    /**
     * @return array
     */
    public function getReceipt()
    {
        return $this->receipt;
    }

    /**
     * @param array $receipt
     *
     * @return Fulfillment
     */
    public function setReceipt($receipt)
    {
        $this->receipt = $receipt;

        return $this;
    }

    /**
     * @return string
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @param string $createdAt
     *
     * @return Fulfillment
     */
    public function setCreatedAt($createdAt)
    {
        $this->createdAt = $createdAt;

        return $this;
    }

    /**
     * @return string
     */
    public function getUpdatedAt()
    {
        return $this->updatedAt;
    }

    /**
     * @param string $updatedAt
     *
     * @return Fulfillment
     */
    public function setUpdatedAt($updatedAt)
    {
        $this->updatedAt = $updatedAt;

        return $this;
    }

    /**
     * @return int
     */
    public function getOrderId()
    {
        return $this->orderId;
    }

    /**
     * @param int $orderId
     *
     * @return Fulfillment
     */
    public function setOrderId($orderId)
    {
        $this->orderId = $orderId;

        return $this;
    }

    /**
     * @return string
     */
    public function getStatus()
    {
        return $this->status;
    }

    /**
     * @param string $status
     *
     * @return Fulfillment
     */
    public function setStatus($status)
    {
        $this->status = $status;

        return $this;
    }

    /**
     * @return string
     */
    public function getTrackingCompany()
    {
        return $this->trackingCompany;
    }

    /**
     * @param string $trackingCompany
     *
     * @return Fulfillment
     */
    public function setTrackingCompany($trackingCompany)
    {
        $this->trackingCompany = $trackingCompany;

        return $this;
    }

    /**
     * @return string
     */
    public function getTrackingNumber()
    {
        return $this->trackingNumber;
    }

    /**
     * @param string $trackingNumber
     *
     * @return Fulfillment
     */
    public function setTrackingNumber($trackingNumber)
    {
        $this->trackingNumber = $trackingNumber;

        return $this;
    }

    /**
     * @return LineItem[]
     */
    public function getLineItems()
    {
        return $this->lineItems;
    }

    /**
     * @param LineItem[] $lineItems
     *
     * @return Fulfillment
     */
    public function setLineItems($lineItems)
    {
        $this->lineItems = $lineItems;

        return $this;
    }

    /**
     * @return array
     */
    public function getTrackingNumbers()
    {
        return $this->trackingNumbers;
    }

    /**
     * @param array $trackingNumbers
     * @return Fulfillment
     */
    public function setTrackingNumbers($trackingNumbers)
    {
        $this->trackingNumbers = $trackingNumbers;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public static function getTypeCollection()
    {
        return array_merge(parent::getTypeCollection(), [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            new HasMany('lineItems', LineItem::class),
        ]);
    }
}

1			<?php
2
3			/*
4			* This file is part of the slince/shopify-api-php
5			*
6			* (c) Taosikai <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Slince\Shopify\Manager\Fulfillment;
13
14			use Slince\Shopify\Common\Model\Model;
15			use Slince\Shopify\Hydrator\Association\HasMany;
16			use Slince\Shopify\Manager\Order\LineItem;
17
18			class Fulfillment extends Model
19			{
20			/**
21			* @var int
22			*/
23			protected $orderId;
24
25			/**
26			* @var string
27			*/
28			protected $status;
29
30			/**
31			* @var string
32			*/
33			protected $createdAt;
34
35			/**
36			* @var string
37			*/
38			protected $updatedAt;
39
40			/**
41			* @var string
42			*/
43			protected $service;
44
45			/**
46			* @var string
47			*/
48			protected $shipmentStatus;
49
50			/**
51			* @var string
52			*/
53			protected $trackingCompany;
54
55			/**
56			* @var string
57			*/
58			protected $trackingNumber;
59
60			/**
61			* @var array
62			*/
63			protected $trackingNumbers;
64
65			/**
66			* @var string
67			*/
68			protected $trackingUrl;
69
70			/**
71			* @var array
72			*/
73			protected $trackingUrls;
74
75			/**
76			* @var array
77			*/
78			protected $receipt;
79
80			/**
81			* @var LineItem[]
82			*/
83			protected $lineItems;
84
85			/**
86			* @return string
87			*/
88			public function getService()
89			{
90			return $this->service;
91			}
92
93			/**
94			* @param string $service
95			*
96			* @return Fulfillment
97			*/
98			public function setService($service)
99			{
100			$this->service = $service;
101
102			return $this;
103			}
104
105			/**
106			* @return string
107			*/
108			public function getShipmentStatus()
109			{
110			return $this->shipmentStatus;
111			}
112
113			/**
114			* @param string $shipmentStatus
115			*
116			* @return Fulfillment
117			*/
118			public function setShipmentStatus($shipmentStatus)
119			{
120			$this->shipmentStatus = $shipmentStatus;
121
122			return $this;
123			}
124
125			/**
126			* @return string
127			*/
128			public function getTrackingUrl()
129			{
130			return $this->trackingUrl;
131			}
132
133			/**
134			* @param string $trackingUrl
135			*
136			* @return Fulfillment
137			*/
138			public function setTrackingUrl($trackingUrl)
139			{
140			$this->trackingUrl = $trackingUrl;
141
142			return $this;
143			}
144
145			/**
146			* @return array
147			*/
148			public function getTrackingUrls()
149			{
150			return $this->trackingUrls;
151			}
152
153			/**
154			* @param array $trackingUrls
155			*
156			* @return Fulfillment
157			*/
158			public function setTrackingUrls($trackingUrls)
159			{
160			$this->trackingUrls = $trackingUrls;
161
162			return $this;
163			}
164
165			/**
166			* @return array
167			*/
168			public function getReceipt()
169			{
170			return $this->receipt;
171			}
172
173			/**
174			* @param array $receipt
175			*
176			* @return Fulfillment
177			*/
178			public function setReceipt($receipt)
179			{
180			$this->receipt = $receipt;
181
182			return $this;
183			}
184
185			/**
186			* @return string
187			*/
188			public function getCreatedAt()
189			{
190			return $this->createdAt;
191			}
192
193			/**
194			* @param string $createdAt
195			*
196			* @return Fulfillment
197			*/
198			public function setCreatedAt($createdAt)
199			{
200			$this->createdAt = $createdAt;
201
202			return $this;
203			}
204
205			/**
206			* @return string
207			*/
208			public function getUpdatedAt()
209			{
210			return $this->updatedAt;
211			}
212
213			/**
214			* @param string $updatedAt
215			*
216			* @return Fulfillment
217			*/
218			public function setUpdatedAt($updatedAt)
219			{
220			$this->updatedAt = $updatedAt;
221
222			return $this;
223			}
224
225			/**
226			* @return int
227			*/
228			public function getOrderId()
229			{
230			return $this->orderId;
231			}
232
233			/**
234			* @param int $orderId
235			*
236			* @return Fulfillment
237			*/
238			public function setOrderId($orderId)
239			{
240			$this->orderId = $orderId;
241
242			return $this;
243			}
244
245			/**
246			* @return string
247			*/
248			public function getStatus()
249			{
250			return $this->status;
251			}
252
253			/**
254			* @param string $status
255			*
256			* @return Fulfillment
257			*/
258			public function setStatus($status)
259			{
260			$this->status = $status;
261
262			return $this;
263			}
264
265			/**
266			* @return string
267			*/
268			public function getTrackingCompany()
269			{
270			return $this->trackingCompany;
271			}
272
273			/**
274			* @param string $trackingCompany
275			*
276			* @return Fulfillment
277			*/
278			public function setTrackingCompany($trackingCompany)
279			{
280			$this->trackingCompany = $trackingCompany;
281
282			return $this;
283			}
284
285			/**
286			* @return string
287			*/
288			public function getTrackingNumber()
289			{
290			return $this->trackingNumber;
291			}
292
293			/**
294			* @param string $trackingNumber
295			*
296			* @return Fulfillment
297			*/
298			public function setTrackingNumber($trackingNumber)
299			{
300			$this->trackingNumber = $trackingNumber;
301
302			return $this;
303			}
304
305			/**
306			* @return LineItem[]
307			*/
308			public function getLineItems()
309			{
310			return $this->lineItems;
311			}
312
313			/**
314			* @param LineItem[] $lineItems
315			*
316			* @return Fulfillment
317			*/
318			public function setLineItems($lineItems)
319			{
320			$this->lineItems = $lineItems;
321
322			return $this;
323			}
324
325			/**
326			* @return array
327			*/
328			public function getTrackingNumbers()
329			{
330			return $this->trackingNumbers;
331			}
332
333			/**
334			* @param array $trackingNumbers
335			* @return Fulfillment
336			*/
337			public function setTrackingNumbers($trackingNumbers)
338			{
339			$this->trackingNumbers = $trackingNumbers;
340
341			return $this;
342			}
343
344			/**
345			* {@inheritdoc}
346			*/
347			public static function getTypeCollection()
348			{
349			return array_merge(parent::getTypeCollection(), [
			0 ignored issues – show Best Practice introduced 2017-11-29 09:50 UTC by Report Bug Copy Issue Report The expression `return array_merge(paren...der\LineItem::class)));` seems to be an `array`, but some of its elements' types (`Slince\Shopify\Hydrator\Association\HasMany`) are incompatible with the return type of the parent method `Slince\Shopify\Common\Mo...odel::getTypeCollection` of type `Slince\Shopify\Hydrator\Type\DateTimeType[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
350			new HasMany('lineItems', LineItem::class),
351			]);
352			}
353			}

slince / shopify-api-php

Push — master ( 8e28ab...2236d8 )

Fulfillment::getTrackingNumbers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like