Slince\Shopify\Hydrator\Hydrator::instance()

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Hydrator::hydrate()	0	4	1

<?php

/*
 * This file is part of the slince/shopify-api-php
 *
 * (c) Slince <taosikai@yeah.net>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Slince\Shopify\Hydrator;

use JMS\Serializer\Context;
use JMS\Serializer\SerializationContext;
use JMS\Serializer\Serializer;
use JMS\Serializer\SerializerBuilder;

class Hydrator implements HydratorInterface
{
    /**
     * @var Serializer
     */
    protected $serializer;

    /**
     * @var Context
     */
    protected $serializationContext;

    public function __construct($cacheDir, $metaDir)
    {
        $this->serializer = SerializerBuilder::create()
            ->setCacheDir($cacheDir)
            ->addMetadataDir($metaDir)
            ->build();
        $this->serializationContext = SerializationContext::create()->setSerializeNull(true);
    }

    /**
     * {@inheritdoc}
     */
    public function extract($object)
    {
        return $this->serializer->toArray($object, $this->serializationContext);

$this->serializationContext is of type object<JMS\Serializer\Context>, but the function expects a null|object<JMS\Serializer\SerializationContext>.

    }

    /**
     * {@inheritdoc}
     */
    public function hydrate($target, array $data)
    {
        return $this->serializer->fromArray($data, $target);

It seems like $target defined by parameter $target on line 51 can also be of type object; however, JMS\Serializer\Serializer::fromArray() does only seem to accept string, maybe add an additional type check?

    }
}