Location - Code Metrics - Inspection of "增加location" - slince/shipment-tracking - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 253a49...7e5a4c )

by Taosikai

created 2017-10-31 09:05 UTC

Location A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	1
dl	0
loc	101
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	__construct()	6	2
A	toString()	4	1
A	applyCountry()	9	2
A	getCountryName()	4	1
A	setCountryName()	5	1
A	getState()	4	1
A	setState()	5	1
A	getCity()	4	1
A	setCity()	5	1

<?php
/**
 * Slince shipment tracker library
 * @author Tao <[email protected]>
 */

namespace Slince\ShipmentTracking\Common\Location;

use Rinvex\Country\Country;
use Slince\ShipmentTracking\Foundation\Location\AbstractLocation;
use Exception;

class Location extends AbstractLocation
{
    /**
     * @var string
     */
    protected $countryName;

    /**
     * @var string
     */
    protected $state;

    /**
     * @var string
     */
    protected $city;

    /**
     * @var Country
     */
    protected $country;

    public function __construct($countryCode, $state, $city)
    {
        $countryCode && $this->applyCountry($countryCode);
        $this->state = $state;
        $this->city = $city;
    }

    /**
     * {@inheritdoc}
     */
    public function toString()
    {
        return trim(implode(' ', [$this->city, $this->state, $this->countryName]));
    }

    protected function applyCountry($countryCode)
    {
        try {
            $this->country = country($countryCode);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            $this->countryName = $this->country->getName();
        } catch (Exception $exception) {
            $this->countryName = $countryCode;
        }
    }

    /**
     * @return string
     */
    public function getCountryName()
    {
        return $this->countryName;
    }

    /**
     * @param string $countryName
     * @return Location
     */
    public function setCountryName($countryName)
    {
        $this->countryName = $countryName;
        return $this;
    }

    /**
     * @return string
     */
    public function getState()
    {
        return $this->state;
    }

    /**
     * @param string $state
     * @return Location
     */
    public function setState($state)
    {
        $this->state = $state;
        return $this;
    }

    /**
     * @return string
     */
    public function getCity()
    {
        return $this->city;
    }

    /**
     * @param string $city
     * @return Location
     */
    public function setCity($city)
    {
        $this->city = $city;
        return $this;
    }
}

1			<?php
2			/**
3			* Slince shipment tracker library
4			* @author Tao <[email protected]>
5			*/
6
7			namespace Slince\ShipmentTracking\Common\Location;
8
9			use Rinvex\Country\Country;
10			use Slince\ShipmentTracking\Foundation\Location\AbstractLocation;
11			use Exception;
12
13			class Location extends AbstractLocation
14			{
15			/**
16			* @var string
17			*/
18			protected $countryName;
19
20			/**
21			* @var string
22			*/
23			protected $state;
24
25			/**
26			* @var string
27			*/
28			protected $city;
29
30			/**
31			* @var Country
32			*/
33			protected $country;
34
35			public function __construct($countryCode, $state, $city)
36			{
37			$countryCode && $this->applyCountry($countryCode);
38			$this->state = $state;
39			$this->city = $city;
40			}
41
42			/**
43			* {@inheritdoc}
44			*/
45			public function toString()
46			{
47			return trim(implode(' ', [$this->city, $this->state, $this->countryName]));
48			}
49
50			protected function applyCountry($countryCode)
51			{
52			try {
53			$this->country = country($countryCode);
			0 ignored issues – show Documentation Bug introduced 2017-10-31 09:22 UTC by Report Bug Copy Issue Report It seems like `country($countryCode)` can also be of type `array`. However, the property `$country` is declared as type `object<Rinvex\Country\Country>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
54			$this->countryName = $this->country->getName();
55			} catch (Exception $exception) {
56			$this->countryName = $countryCode;
57			}
58			}
59
60			/**
61			* @return string
62			*/
63			public function getCountryName()
64			{
65			return $this->countryName;
66			}
67
68			/**
69			* @param string $countryName
70			* @return Location
71			*/
72			public function setCountryName($countryName)
73			{
74			$this->countryName = $countryName;
75			return $this;
76			}
77
78			/**
79			* @return string
80			*/
81			public function getState()
82			{
83			return $this->state;
84			}
85
86			/**
87			* @param string $state
88			* @return Location
89			*/
90			public function setState($state)
91			{
92			$this->state = $state;
93			return $this;
94			}
95
96			/**
97			* @return string
98			*/
99			public function getCity()
100			{
101			return $this->city;
102			}
103
104			/**
105			* @param string $city
106			* @return Location
107			*/
108			public function setCity($city)
109			{
110			$this->city = $city;
111			return $this;
112			}
113			}

slince / shipment-tracking

Push — master ( 253a49...7e5a4c )

Location A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like