Slince\Config\Parser\XmlParser

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	parse()	0	10	2
A	dump()	0	6	1
A	getSupportedExtensions()	0	4	1

<?php
/**
 * slince config library
 * @author Tao <taosikai@yeah.net>
 */
namespace Slince\Config\Parser;

use LSS\Array2XML;
use LSS\XML2Array;
use Slince\Config\Exception\ParseException;

class XmlParser implements ParserInterface
{
    /**
     * The xml root node name
     * @var string
     */
    public static $rootNodeName = 'configuration';

    /**
     * {@inheritdoc}
     */
    public function parse($file)
    {
        $xml = file_get_contents($file);
        try {
            $data = XML2Array::createArray($xml);
        } catch (\Exception $exception) {
            throw new ParseException($exception->getMessage(), $exception->getCode());
        }
        return reset($data);
    }

    /**
     * {@inheritdoc}
     */
    public function dump($file, array $data)
    {
        $xml = Array2XML::createXML(static::$rootNodeName, $data);
        @mkdir(dirname($file), 0777, true);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        return @file_put_contents($file, $xml->saveXML()) !== false;
    }

    /**
     * {@inheritdoc}
     */
    public static function getSupportedExtensions()
    {
        return ['xml'];
    }
}