ResetCommand::execute() - Code Metrics - slince/composer-registry-manager - Measure and Improve Code Quality continuously with Scrutinizer

ResetCommand::execute() A
last analyzed 2017-07-19 03:29 UTC

↳ Parent: ResetCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	7
nc	2
nop	2

<?php
/**
 * CRM library
 * @author Tao <[email protected]>
 */
namespace Slince\Crm\Command;

use Slince\Crm\ConfigPath;
use Slince\Crm\Utils;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;

class ResetCommand extends Command
{
    /**
     * Command name
     * @var string
     */
    const NAME = 'reset';

    /**
     * {@inheritdoc}
     */
    public function configure()
    {
        $this->setName(static::NAME)
            ->setDescription('Reset registry configurations');
    }

    /**
     * {@inheritdoc}
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $question = new ConfirmationQuestion("Confirm to reset repository configurations? ", false);
        $output->write(PHP_EOL);
        if (!$this->getHelper('question')->ask($input, $output, $question)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return;
        }
        Utils::getFilesystem()->copy(ConfigPath::getDefaultConfigFile(), ConfigPath::getUserConfigFile(), true);

        $output->writeln("<info>Reset registry configurations success</info>");
    }
}


1			<?php
2			/**
3			* CRM library
4			* @author Tao <[email protected]>
5			*/
6			namespace Slince\Crm\Command;
7
8			use Slince\Crm\ConfigPath;
9			use Slince\Crm\Utils;
10			use Symfony\Component\Console\Input\InputInterface;
11			use Symfony\Component\Console\Output\OutputInterface;
12			use Symfony\Component\Console\Question\ConfirmationQuestion;
13
14			class ResetCommand extends Command
15			{
16			/**
17			* Command name
18			* @var string
19			*/
20			const NAME = 'reset';
21
22			/**
23			* {@inheritdoc}
24			*/
25			public function configure()
26			{
27			$this->setName(static::NAME)
28			->setDescription('Reset registry configurations');
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function execute(InputInterface $input, OutputInterface $output)
35			{
36			$question = new ConfirmationQuestion("Confirm to reset repository configurations? ", false);
37			$output->write(PHP_EOL);
38			if (!$this->getHelper('question')->ask($input, $output, $question)) {
			0 ignored issues – show Bug introduced 2017-07-07 08:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
39			return;
40			}
41			Utils::getFilesystem()->copy(ConfigPath::getDefaultConfigFile(), ConfigPath::getUserConfigFile(), true);
42
43			$output->writeln("<info>Reset registry configurations success</info>");
44			}
45			}
46

slince / composer-registry-manager

ResetCommand::execute() A last analyzed 2017-07-19 03:29 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ResetCommand::execute() A
last analyzed 2017-07-19 03:29 UTC