Application - Code Metrics - slince/composer-registry-manager - Measure and Improve Code Quality continuously with Scrutinizer

Application A
last analyzed 2017-07-19 03:29 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	10

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	7
c	3
b	0
f	1
lcom	2
cbo	10
dl	0
loc	78
rs	10

5 Methods

Rating	Name	Size	Complexity
A	__construct()	5	2
A	run()	5	1
A	initializeConfigFile()	7	2
A	getHelp()	4	1
A	getDefaultCommands()	10	1

<?php
/**
 * CRM library
 * @author Tao <[email protected]>
 */
namespace Slince\Crm;

use Symfony\Component\Console\Application as BaseApplication;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class Application extends BaseApplication
{
    /**
     * @var string
     */
    const VERSION = '1.2.1';

    /**
     * Application name
     * @var string
     */
    const NAME = 'Composer Registry Manager %s by Tao and contributors.';

    protected static $logo = <<<EOT
 _____   _____        ___  ___  
/  ___| |  _  \      /   |/   | 
| |     | |_| |     / /|   /| | 
| |     |  _  /    / / |__/ | | 
| |___  | | \ \   / /       | | 
\_____| |_|  \_\ /_/        |_| 


EOT;

    /**
     * @var RegistryManager
     */
    protected $manager;

    public function __construct(RegistryManager $manager = null)
    {
        $this->manager = $manager ?: new RegistryManager();
        parent::__construct(sprintf(static::NAME, static::VERSION));
    }

    /**
     * {@inheritdoc}
     * @codeCoverageIgnore
     */
    public function run(InputInterface $input = null, OutputInterface $output = null)
    {
        $this->initializeConfigFile();
        return parent::run($input, $output);
    }

    /**
     * @codeCoverageIgnore
     */
    protected function initializeConfigFile()
    {
        if (!file_exists(ConfigPath::getUserConfigFile())) {
            Utils::getFilesystem()->copy(ConfigPath::getDefaultConfigFile(), ConfigPath::getUserConfigFile());
        }
        $this->manager->readRegistriesFromFile(ConfigPath::getUserConfigFile());
    }

    /**
     * {@inheritdoc}
     */
    public function getHelp()
    {
        return static::$logo . parent::getHelp();
    }

    /**
     * {@inheritdoc}
     */
    public function getDefaultCommands()
    {
        return array_merge([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            new Command\ListCommand($this->manager),
            new Command\UseCommand($this->manager),
            new Command\AddCommand($this->manager),
            new Command\RemoveCommand($this->manager),
            new Command\ResetCommand($this->manager),
        ], parent::getDefaultCommands());
    }
}


1			<?php
2			/**
3			* CRM library
4			* @author Tao <[email protected]>
5			*/
6			namespace Slince\Crm;
7
8			use Symfony\Component\Console\Application as BaseApplication;
9			use Symfony\Component\Console\Input\InputInterface;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			class Application extends BaseApplication
13			{
14			/**
15			* @var string
16			*/
17			const VERSION = '1.2.1';
18
19			/**
20			* Application name
21			* @var string
22			*/
23			const NAME = 'Composer Registry Manager %s by Tao and contributors.';
24
25			protected static $logo = <<<EOT
26			_____ _____ ___ ___
27			/ ___\| \| _ \ / \|/ \|
28			\| \| \| \|_\| \| / /\| /\| \|
29			\| \| \| _ / / / \|__/ \| \|
30			\| \|___ \| \| \ \ / / \| \|
31			\_____\| \|_\| \_\ /_/ \|_\|
32
33
34			EOT;
35
36			/**
37			* @var RegistryManager
38			*/
39			protected $manager;
40
41			public function __construct(RegistryManager $manager = null)
42			{
43			$this->manager = $manager ?: new RegistryManager();
44			parent::__construct(sprintf(static::NAME, static::VERSION));
45			}
46
47			/**
48			* {@inheritdoc}
49			* @codeCoverageIgnore
50			*/
51			public function run(InputInterface $input = null, OutputInterface $output = null)
52			{
53			$this->initializeConfigFile();
54			return parent::run($input, $output);
55			}
56
57			/**
58			* @codeCoverageIgnore
59			*/
60			protected function initializeConfigFile()
61			{
62			if (!file_exists(ConfigPath::getUserConfigFile())) {
63			Utils::getFilesystem()->copy(ConfigPath::getDefaultConfigFile(), ConfigPath::getUserConfigFile());
64			}
65			$this->manager->readRegistriesFromFile(ConfigPath::getUserConfigFile());
66			}
67
68			/**
69			* {@inheritdoc}
70			*/
71			public function getHelp()
72			{
73			return static::$logo . parent::getHelp();
74			}
75
76			/**
77			* {@inheritdoc}
78			*/
79			public function getDefaultCommands()
80			{
81			return array_merge([
			0 ignored issues – show Best Practice introduced 2017-07-07 08:17 UTC by Report Bug Copy Issue Report The expression `return array_merge(array...:getDefaultCommands());` seems to be an `array`, but some of its elements' types (`Slince\Crm\Command\ListC...rm\Command\ResetCommand`) are incompatible with the return type of the parent method `Symfony\Component\Consol...ion::getDefaultCommands` of type `array<Symfony\Component\...le\Command\ListCommand>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
82			new Command\ListCommand($this->manager),
83			new Command\UseCommand($this->manager),
84			new Command\AddCommand($this->manager),
85			new Command\RemoveCommand($this->manager),
86			new Command\ResetCommand($this->manager),
87			], parent::getDefaultCommands());
88			}
89			}
90

slince / composer-registry-manager

Application A last analyzed 2017-07-19 03:29 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

Application A
last analyzed 2017-07-19 03:29 UTC