slince / composer-alias

src/AliasCollection.php

<?php
/*
 * This file is part of the slince/composer-alias package.
 *
 * (c) Slince <taosikai@yeah.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Slince\ComposerAlias;

use Composer\Config\JsonConfigSource;
use Composer\Json\JsonFile;
use Composer\Util\Silencer;

class AliasCollection implements \IteratorAggregate
{
    /**
     * @var JsonFile
     */
    protected $configFile;

    /**
     * @var JsonConfigSource
     */
    protected $configSource;

    /**
     * @var array
     */
    protected $aliases;

    /**
     * @param JsonFile $configFile
     *
     * @throws \Exception
     */
    public function __construct(JsonFile $configFile)
    {
        $this->configFile = $configFile;
        $this->configSource = new JsonConfigSource($this->configFile);
        if (!$this->configFile->exists()) {
            touch($this->configFile->getPath());
            $this->configFile->write(['config' => new \ArrayObject()]);
            Silencer::call('chmod', $this->configFile->getPath(), 0600);
        }
    }

    /**
     * Gets all aliases.
     *
     * @return array
     */
    public function all()
    {
        $this->readFromFile();

        return $this->aliases;
    }

    /**
     * Add an alias.
     *
     * @param string $alias
     * @param string $raw
     *
     * @return static
     */
    public function add($alias, $raw)
    {
        $this->readFromFile();
        $this->aliases[$alias] = $raw;
        $this->configSource->addConfigSetting('_alias', $this->aliases);

        return $this;
    }

    /**
     * Removes an alias.
     *
     * @param string $alias
     *
     * @return $this
     */
    public function remove($alias)
    {
        $this->readFromFile();
        unset($this->aliases[$alias]);
        $this->configSource->addConfigSetting('_alias', $this->aliases);

        return $this;
    }

    /**
     * Gets the alias.
     *
     * @param string $alias
     *
     * @return string
     */
    public function get($alias)
    {
        $this->readFromFile();

        return isset($this->aliases[$alias]) ? $this->aliases[$alias] : null;
    }

    /**
     * Checks whether the alias exists.
     *
     * @param string $alias
     *
     * @return bool
     */
    public function has($alias)
    {
        return isset($this->aliases[$alias]);
    }

    /**
     * {@inheritdoc}
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->all());
    }

    protected function readFromFile()
    {
        if ($this->aliases) {

The expression $this->aliases of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }
        $config = $this->configFile->read();
        if (!isset($config['config']['_alias']) || !is_array($config['config']['_alias'])) {
            $aliases = [];
        } else {
            $aliases = $config['config']['_alias'];
        }
        $this->aliases = $aliases;
    }
}