View GitHub Repository cakephp-permission

Schedule Inspection
Subscribe

UsersTableTrait::buildPermissionRelationship()   A
last analyzed

↳ Parent: UsersTableTrait

Complexity

Conditions 2
Paths 1

Size

Total Lines 10
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 10
c 0
b 0
f 0
rs 9.4285
cc 2
eloc 7
nc 1
nop 0
1 
<?php
2 
/**
3 
 * CakePHP permission handling library
4 
 * @author Tao <[email protected]>
5 
 */
6 
namespace Slince\CakePermission\Model\Table;
7 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
use Cake\Core\Configure;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
use Slince\CakePermission\TableFactory;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
trait UsersTableTrait

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    public function buildPermissionRelationship()

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
        $this->belongsToMany('Roles', [

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It seems like belongsToMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for methods that are used by a trait but not required by it.


To illustrate, let’s look at the following code example


trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}





The trait Idable provides a method equalsId that in turn relies on the
method getId(). If this method does not exist on a class mixing in this
trait, the method will fail.


Adding the getId() as an abstract method to the trait will make sure it
is available.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
            'className' => TableFactory::getModelClass('Roles'),

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
            'foreignKey' => 'user_id',

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
            'targetForeignKey' => 'role_id',

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
            'joinTable' => Configure::read('Permission.tableNameMap.users_roles') ?: 'users_roles',

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
            'saveStrategy' => 'append'

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
        ]);

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
}