China\Region\RegionService

Complexity

Total Complexity

10

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getProvinces()	0	4	1
A	findByIdCard()	0	9	2
A	filter()	0	15	3
A	traverseTree()	0	11	3

<?php
/*
 * This file is part of the Slince/China package.
 *
 * (c) Slince <taosikai@yeah.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace China\Region;

use China\Common\ResourceFile;
use China\IDCard\IDCard;
use China\Region\Location\AddressInterface;
use Doctrine\Common\Collections\Collection;

class RegionService implements RegionServiceInterface
{
    use AddressFinderTrait;
    /**
     * @var AddressInterface
     */
    protected $regions;

    /**
     * 根据code做索引.
     *
     * @var AddressInterface[]|Collection
     */
    protected $flattenRegions;

    public function __construct(ResourceFile $resourceFile)
    {
        $this->regions = new RegionLoader($resourceFile);

It seems like new \China\Region\RegionLoader($resourceFile) of type object<China\Region\RegionLoader> is incompatible with the declared type object<China\Region\Location\AddressInterface> of property $regions.

        $this->flattenRegions = new RegionCollection();
    }

    /**
     * {@inheritdoc}
     */
    public function getProvinces()
    {
        return $this->regions->first()->getChildren();

The method first() does not seem to exist on object<China\Region\Location\AddressInterface>.

    }

    /**
     * {@inheritdoc}
     */
    public function findByIdCard($idCard)
    {
        if (is_string($idCard)) {
            $idCard = new IDCard($idCard);
        }
        $areaCode = substr($idCard, 0, 6);

        return $this->findByCode($areaCode);
    }

    /**
     * {@inheritdoc}
     */
    public function filter(\Closure $callback)
    {
        if (!$this->flattenRegions->isEmpty()) {
            return $this->flattenRegions->filter($callback);
        }
        // 没有遍历过则自行遍历
        $addresses = [];
        $this->traverseTree($this->regions->first(), function(AddressInterface $address) use ($callback, &$addresses){

The method first() does not seem to exist on object<China\Region\Location\AddressInterface>.

            if ($callback($address) === true) {
                $addresses[] = $address;
            }
        });

        return new RegionCollection($addresses);
    }

    /**
     * 遍历地区树.
     *
     * @param AddressInterface $address
     * @param \Closure         $callback
     */
    protected function traverseTree(AddressInterface $address, \Closure $callback)
    {
        $callback($address);
        //将树形结构扁平化
        $this->flattenRegions->add($address);
        if ($address->getChildren()) {
            foreach ($address->getChildren() as $child) {
                $this->traverseTree($child, $callback);
            }
        }
    }
}