EntityRepository::get() - Code Metrics - Inspection of "Start developing relations" - slickframework/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5dcaed...1cb772 )

by Filipe

created 2016-03-07 15:39 UTC

EntityRepository::get() A

↳ Parent: EntityRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	5
cts	6
cp	0.8333
rs	9.4285
cc	2
eloc	5
nc	2
nop	1
crap	2.0185

<?php

/**
 * This file is part of slick/orm package
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Slick\Orm\Repository;

use Slick\Database\Sql;
use Slick\Orm\EntityInterface;
use Slick\Orm\Repository\QueryObject\QueryObject;
use Slick\Orm\Repository\QueryObject\QueryObjectInterface;
use Slick\Orm\RepositoryInterface;

/**
 * Class EntityRepository
 *
 * @package Slick\Orm\Repository
 * @author  Filipe Silva <[email protected]>
 */
class EntityRepository extends AbstractRepository implements
    RepositoryInterface
{

    /**
     * Finds entities
     *
     * @return QueryObjectInterface
     *
     * @see Slick\Database\Sql\Select
     */
    public function find()
    {
        return new QueryObject($this);
    }

    /**
     * Gets an entity by its id
     *
     * @param mixed $entityId
     *
     * @return EntityInterface|null
     */
    public function get($entityId)
    {
        $entity = $this->getIdentityMap()->get($entityId, false);
        if ($entity === false) {
            $entity = $this->load($entityId);
        }
        return $entity;
    }

    /**
     * Loads entity from database
     *
     * @param $entityId
     *
     * @return null|EntityInterface
     */
    protected function load($entityId)
    {
        $table = $this->getEntityDescriptor()->getTableName();
        $primaryKey = $this->getEntityDescriptor()
            ->getPrimaryKey()
            ->getField();
        return $this->find()
            ->where(
                [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    "{$table}.{$primaryKey} = :id" => [
                        ':id' => $entityId
                    ]
                ]
            )
            ->first();
    }
}

1		<?php
2
3		/**
4		* This file is part of slick/orm package
5		*
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*/
9
10		namespace Slick\Orm\Repository;
11
12		use Slick\Database\Sql;
13		use Slick\Orm\EntityInterface;
14		use Slick\Orm\Repository\QueryObject\QueryObject;
15		use Slick\Orm\Repository\QueryObject\QueryObjectInterface;
16		use Slick\Orm\RepositoryInterface;
17
18		/**
19		* Class EntityRepository
20		*
21		* @package Slick\Orm\Repository
22		* @author Filipe Silva <[email protected]>
23		*/
24		class EntityRepository extends AbstractRepository implements
25		RepositoryInterface
26		{
27
28		/**
29		* Finds entities
30		*
31		* @return QueryObjectInterface
32		*
33		* @see Slick\Database\Sql\Select
34		*/
35	4	public function find()
36		{
37	4	return new QueryObject($this);
38		}
39
40		/**
41		* Gets an entity by its id
42		*
43		* @param mixed $entityId
44		*
45		* @return EntityInterface\|null
46		*/
47	4	public function get($entityId)
48		{
49	4	$entity = $this->getIdentityMap()->get($entityId, false);
50	4	if ($entity === false) {
51	2	$entity = $this->load($entityId);
52		}
53	2	return $entity;
54		}
55
56		/**
57		* Loads entity from database
58		*
59		* @param $entityId
60		*
61		* @return null\|EntityInterface
62		*/
63	2	protected function load($entityId)
64		{
65	2	$table = $this->getEntityDescriptor()->getTableName();
66	2	$primaryKey = $this->getEntityDescriptor()
67	2	->getPrimaryKey()
68	2	->getField();
69	2	return $this->find()
70	2	->where(
71		[
		0 ignored issues – show Documentation introduced 2016-02-29 21:05 UTC by Report Bug Copy Issue Report `array("{$table}.{$primar...ay(':id' => $entityId))` is of type `array<string\|integer,array<string,?,{":id":"?"}>>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72	2	"{$table}.{$primaryKey} = :id" => [
73		':id' => $entityId
74	2	]
75	2	]
76	2	)
77	2	->first();
78		}
79		}

slickframework / orm

Push — master ( 5dcaed...1cb772 )

EntityRepository::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like