FlashMessages::get() - Code Metrics - slickframework/mvc - Measure and Improve Code Quality continuously with Scrutinizer

FlashMessages::get() A
last analyzed 2017-06-28 15:50 UTC

↳ Parent: FlashMessages

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0
crap	1

<?php

/**
 * This file is part of slick/mvc package
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Slick\Mvc\Http;

use Slick\Filter\StaticFilter;

/**
 * Session Flash Messages
 * 
 * @package Slick\Mvc\Http
 * @author  Filipe Silva <[email protected]>
 */
class FlashMessages
{

    /**#@+
     * @const string TYPE for message type constants
     */
    const TYPE_SUCCESS = 0;
    const TYPE_ERROR   = 1;
    const TYPE_WARNING = 2;
    const TYPE_INFO    = 3;
    /**#@-*/

    /**
     * Uses session
     */
    use SessionAwareMethods;

    /**
     * @var array message type descriptions
     */
    public $classes = [
        self::TYPE_SUCCESS => 'success',
        self::TYPE_WARNING => 'warning',
        self::TYPE_INFO    => 'info',
        self::TYPE_ERROR   => 'danger'
    ];

    /**
     * @var array
     */
    protected static $messages = [];

    /**
     * Set a flash message of a give type
     *
     * @param int $type
     * @param string $message
     *
     * @return self
     */
    public function set($type, $message)
    {
        $type = StaticFilter::filter('number', $type);
        if ($type < 0 || $type > 3) {
            $type = static::TYPE_INFO;
        }
        self::$messages[$type][] = $message;
        $this->getSessionDriver()
            ->set('_messages_', self::$messages)
        ;
        return $this;
    }

    /**
     * Retrieve all messages and flushes them all
     *
     * @return array
     */
    public function get()
    {
        self::$messages = $this->getSessionDriver()->get('_messages_', []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $messages = self::$messages;
        $this->flush();
        return $messages;
    }

    /**
     * clears all messages
     *
     * @return FlashMessages
     */
    public function flush()
    {
        self::$messages = [];
        $this->getSessionDriver()
            ->set('_messages_', self::$messages)
        ;
        return $this;
    }
}

1		<?php
2
3		/**
4		* This file is part of slick/mvc package
5		*
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*/
9
10		namespace Slick\Mvc\Http;
11
12		use Slick\Filter\StaticFilter;
13
14		/**
15		* Session Flash Messages
16		*
17		* @package Slick\Mvc\Http
18		* @author Filipe Silva <[email protected]>
19		*/
20		class FlashMessages
21		{
22
23		/**#@+
24		* @const string TYPE for message type constants
25		*/
26		const TYPE_SUCCESS = 0;
27		const TYPE_ERROR = 1;
28		const TYPE_WARNING = 2;
29		const TYPE_INFO = 3;
30		/*#@-/
31
32		/**
33		* Uses session
34		*/
35		use SessionAwareMethods;
36
37		/**
38		* @var array message type descriptions
39		*/
40		public $classes = [
41		self::TYPE_SUCCESS => 'success',
42		self::TYPE_WARNING => 'warning',
43		self::TYPE_INFO => 'info',
44		self::TYPE_ERROR => 'danger'
45		];
46
47		/**
48		* @var array
49		*/
50		protected static $messages = [];
51
52		/**
53		* Set a flash message of a give type
54		*
55		* @param int $type
56		* @param string $message
57		*
58		* @return self
59		*/
60	2	public function set($type, $message)
61		{
62	2	$type = StaticFilter::filter('number', $type);
63	2	if ($type < 0 \|\| $type > 3) {
64	2	$type = static::TYPE_INFO;
65	1	}
66	2	self::$messages[$type][] = $message;
67	2	$this->getSessionDriver()
68	2	->set('_messages_', self::$messages)
69		;
70	2	return $this;
71		}
72
73		/**
74		* Retrieve all messages and flushes them all
75		*
76		* @return array
77		*/
78	2	public function get()
79		{
80	2	self::$messages = $this->getSessionDriver()->get('_messages_', []);
		0 ignored issues – show Documentation introduced 2016-04-10 19:34 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation Bug introduced 2016-04-10 19:34 UTC by Report Bug Copy Issue Report It seems like `$this->getSessionDriver(...('_messages_', array())` of type `*` is incompatible with the declared type `array` of property `$messages`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
81	2	$messages = self::$messages;
82	2	$this->flush();
83	2	return $messages;
84		}
85
86		/**
87		* clears all messages
88		*
89		* @return FlashMessages
90		*/
91	2	public function flush()
92		{
93	2	self::$messages = [];
94	2	$this->getSessionDriver()
95	2	->set('_messages_', self::$messages)
96		;
97	2	return $this;
98		}
99		}

slickframework / mvc

FlashMessages::get() A last analyzed 2017-06-28 15:50 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

FlashMessages::get() A
last analyzed 2017-06-28 15:50 UTC