File\View\Helper\FileHelper

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	thumb()	0	11	3

<?php
namespace File\View\Helper;

use Cake\View\Helper;

class FileHelper extends Helper
{

    /**
     * {@inheritDoc}
     */
    public $helpers = [
        'Html',
    ];

    /**
     * Thumb image.
     *
     * @param string|array $path Path to the image file, relative to the app/webroot/img/ direct.
     * @param array $options Array of HTML attributes. See above for special options.
     * @param string $thumb Name of thumb.
     * @return string completed img tag.
     * @see https://book.cakephp.org/3.0/en/views/helpers/html.html#linking-to-images
     */
    public function thumb($path, array $options = [], string $thumb = 'default'): string
    {
        if ($thumb !== 'default') {
            $path = preg_replace('/default/', $thumb, $path);
        }

        if (!is_array($options)) {

The condition is_array($options) is always true.

            $options = [];
        }

        return $this->Html->image($path, $options);

Are you sure the usage of $this->Html->image($path, $options) targeting Cake\View\Helper::__call() seems to always return null.

The method image() does not exist on null.

The property Html does not exist on File\View\Helper\FileHelper. Since you implemented __get, consider adding a @property annotation.

The expression return $this->Html->image($path, $options) returns the type null which is incompatible with the type-hinted return string.

    }
}