slevomat / csob-gateway

src/Call/OneClick/InitOneClickPaymentRequest.php

<?php declare(strict_types = 1);

namespace SlevomatCsobGateway\Call\OneClick;

use DateTimeImmutable;
use SlevomatCsobGateway\Api\ApiClient;
use SlevomatCsobGateway\Call\PaymentResponse;
use SlevomatCsobGateway\Call\PaymentStatus;
use SlevomatCsobGateway\Call\ResultCode;
use SlevomatCsobGateway\Crypto\SignatureDataFormatter;
use SlevomatCsobGateway\Price;
use SlevomatCsobGateway\Validator;

class InitOneClickPaymentRequest
{

	/** @var string */
	private $merchantId;

	/** @var string */
	private $origPayId;

	/** @var string */
	private $orderId;

	/** @var Price|null */
	private $price;

	/** @var string|null */
	private $description;

	/** @var string */
	private $clientIp;

	public function __construct(
		string $merchantId,
		string $origPayId,
		string $orderId,
		string $clientIp,
		?Price $price = null,
		?string $description = null
	)
	{
		Validator::checkPayId($origPayId);
		Validator::checkOrderId($orderId);
		if ($description !== null) {
			Validator::checkDescription($description);
		}

		$this->merchantId = $merchantId;
		$this->origPayId = $origPayId;
		$this->orderId = $orderId;
		$this->clientIp = $clientIp;
		$this->price = $price;
		$this->description = $description;
	}

	public function send(ApiClient $apiClient): PaymentResponse
	{
		$requestData = [
			'merchantId' => $this->merchantId,
			'origPayId' => $this->origPayId,
			'orderNo' => $this->orderId,
			'clientIp' => $this->clientIp,
		];

		if ($this->price !== null) {
			$requestData['totalAmount'] = $this->price->getAmount();
			$requestData['currency'] = $this->price->getCurrency()->getValue();
		}

		if ($this->description !== null) {
			$requestData['description'] = $this->description;
		}

		$response = $apiClient->post(
			'oneclick/init',
			$requestData,
			new SignatureDataFormatter([
				'merchantId' => null,
				'origPayId' => null,
				'orderNo' => null,
				'dttm' => null,
				'clientIp' => null,
				'totalAmount' => null,
				'currency' => null,
				'description' => null,
			]),
			new SignatureDataFormatter([
				'payId' => null,
				'dttm' => null,
				'resultCode' => null,
				'resultMessage' => null,
				'paymentStatus' => null,
			])
		);

		$data = $response->getData();

		return new PaymentResponse(
			$data['payId'],
			DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']),

It seems like DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']) can also be of type false; however, parameter $responseDateTime of SlevomatCsobGateway\Call\PaymentResponse::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

			ResultCode::get($data['resultCode']),
			$data['resultMessage'],
			isset($data['paymentStatus']) ? PaymentStatus::get($data['paymentStatus']) : null
		);
	}

}