slevomat / csob-gateway

src/Call/Masterpass/StandardExtractRequest.php

<?php declare(strict_types = 1);

namespace SlevomatCsobGateway\Call\Masterpass;

use DateTimeImmutable;
use SlevomatCsobGateway\Api\ApiClient;
use SlevomatCsobGateway\Call\PaymentStatus;
use SlevomatCsobGateway\Call\ResultCode;
use SlevomatCsobGateway\Crypto\SignatureDataFormatter;
use SlevomatCsobGateway\Validator;

class StandardExtractRequest
{

	/** @var string */
	private $merchantId;

	/** @var string */
	private $payId;

	/** @var mixed[] */
	private $callbackParams;

	/**
	 * @param string $merchantId
	 * @param string $payId
	 * @param mixed[] $callbackParams
	 */
	public function __construct(
		string $merchantId,
		string $payId,
		array $callbackParams
	)
	{
		Validator::checkPayId($payId);

		$this->merchantId = $merchantId;
		$this->payId = $payId;
		$this->callbackParams = $callbackParams;
	}

	public function send(ApiClient $apiClient): ExtractResponse
	{
		$requestData = [
			'merchantId' => $this->merchantId,
			'payId' => $this->payId,
			'callbackParams' => $this->callbackParams,
		];

		$response = $apiClient->post(
			'masterpass/standard/extract',
			$requestData,
			new SignatureDataFormatter([
				'merchantId' => null,
				'payId' => null,
				'dttm' => null,
				'callbackParams' => [
					'mpstatus' => null,
					'oauthToken' => null,
					'checkoutResourceUrl' => null,
					'oauthVerifier' => null,
				],
			]),
			new SignatureDataFormatter([
				'payId' => null,
				'dttm' => null,
				'resultCode' => null,
				'resultMessage' => null,
				'paymentStatus' => null,
				'checkoutParams' => [
					'card' => [
						'maskedCln' => null,
						'expiration' => null,
						'billingAddress' => [
							'city' => null,
							'country' => null,
							'countrySubdivision' => null,
							'line1' => null,
							'line2' => null,
							'line3' => null,
							'postalCode' => null,
						],
					],
					'shippingAddress' => [
						'recipientName' => null,
						'recipientPhoneNumber' => null,
						'city' => null,
						'country' => null,
						'countrySubdivision' => null,
						'line1' => null,
						'line2' => null,
						'line3' => null,
						'postalCode' => null,
					],
					'contact' => [
						'firstName' => null,
						'middleName' => null,
						'lastName' => null,
						'country' => null,
						'emailAddress' => null,
						'phoneNumber' => null,
					],
					'rewardProgram' => [
						'rewardNumber' => null,
						'rewardId' => null,
						'rewardName' => null,
						'expiration' => null,
					],
				],
			])
		);

		$data = $response->getData();

		return new ExtractResponse(
			$data['payId'],
			DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']),

It seems like DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']) can also be of type false; however, parameter $responseDateTime of SlevomatCsobGateway\Call\Masterpass\ExtractResponse::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

			ResultCode::get($data['resultCode']),
			$data['resultMessage'],
			isset($data['paymentStatus']) ? PaymentStatus::get($data['paymentStatus']) : null,
			$data['checkoutParams'] ?? null
		);
	}

}