slevomat / csob-gateway

src/Call/Masterpass/BasicCheckoutRequest.php

<?php declare(strict_types = 1);

namespace SlevomatCsobGateway\Call\Masterpass;

use DateTimeImmutable;
use SlevomatCsobGateway\Api\ApiClient;
use SlevomatCsobGateway\Call\PaymentStatus;
use SlevomatCsobGateway\Call\ResultCode;
use SlevomatCsobGateway\Crypto\SignatureDataFormatter;
use SlevomatCsobGateway\Validator;

class BasicCheckoutRequest
{

	/** @var string */
	private $merchantId;

	/** @var string */
	private $payId;

	/** @var string */
	private $callbackUrl;

	public function __construct(
		string $merchantId,
		string $payId,
		string $callbackUrl
	)
	{
		Validator::checkPayId($payId);
		Validator::checkReturnUrl($callbackUrl);

		$this->merchantId = $merchantId;
		$this->payId = $payId;
		$this->callbackUrl = $callbackUrl;
	}

	public function send(ApiClient $apiClient): CheckoutResponse
	{
		$requestData = [
			'merchantId' => $this->merchantId,
			'payId' => $this->payId,
			'callbackUrl' => $this->callbackUrl,
		];

		$response = $apiClient->post(
			'masterpass/basic/checkout',
			$requestData,
			new SignatureDataFormatter([
				'merchantId' => null,
				'payId' => null,
				'dttm' => null,
				'callbackUrl' => null,
			]),
			new SignatureDataFormatter([
				'payId' => null,
				'dttm' => null,
				'resultCode' => null,
				'resultMessage' => null,
				'paymentStatus' => null,
				'lightboxParams' => [
					'requestToken' => null,
					'callbackUrl' => null,
					'merchantCheckoutId' => null,
					'allowedCardTypes' => null,
					'suppressShippingAddressEnable' => null,
					'loyaltyEnabled' => null,
					'version' => null,
					'shippingLocationProfile' => null,
				],
			])
		);

		$data = $response->getData();

		return new CheckoutResponse(
			$data['payId'],
			DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']),

It seems like DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']) can also be of type false; however, parameter $responseDateTime of SlevomatCsobGateway\Call\Masterpass\CheckoutResponse::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

			ResultCode::get($data['resultCode']),
			$data['resultMessage'],
			isset($data['paymentStatus']) ? PaymentStatus::get($data['paymentStatus']) : null,
			$data['lightboxParams'] ?? null
		);
	}

}