slevomat / csob-gateway

src/Call/Extension/TransactionSettlementExtension.php

<?php declare(strict_types = 1);

namespace SlevomatCsobGateway\Call\Extension;

use DateTimeImmutable;
use SlevomatCsobGateway\Call\ResponseExtensionHandler;
use SlevomatCsobGateway\Crypto\SignatureDataFormatter;
use function array_flip;

class TransactionSettlementExtension implements ResponseExtensionHandler
{

	public const NAME = 'trxDates';

	/**
	 * @param mixed[] $data
	 * @return TransactionSettlementResponse
	 */
	public function createResponse(array $data): TransactionSettlementResponse
	{
		return new TransactionSettlementResponse(
			new DateTimeImmutable($data['createdDate']),
			isset($data['authDate']) ? $this->parseAuthDate($data['authDate']) : null,
			isset($data['settlementDate']) ? $this->parseSettlementDate($data['settlementDate']) : null
		);
	}

	public function getSignatureDataFormatter(): SignatureDataFormatter
	{
		return new SignatureDataFormatter(array_flip(['extension', 'dttm', 'createdDate', 'authDate', 'settlementDate']));
	}

	private function parseAuthDate(string $authDate): DateTimeImmutable
	{
		return DateTimeImmutable::createFromFormat('ymdHis', $authDate);

The expression return DateTimeImmutable::createFromFormat('ymdHis', $authDate) could return the type false which is incompatible with the type-hinted return DateTimeImmutable. Consider adding an additional type-check to rule them out.

	}

	private function parseSettlementDate(string $settlementDate): DateTimeImmutable
	{
		return DateTimeImmutable::createFromFormat('Ymd', $settlementDate)->setTime(0, 0, 0);

The expression return DateTimeImmutable::createFromFormat('Ymd', $settlementDate)->setTime(0, 0, 0) could return the type false which is incompatible with the type-hinted return DateTimeImmutable. Consider adding an additional type-check to rule them out.

	}

}